Anaconda-devel July 2008

anaconda-devel@lists.stg.fedoraproject.org

26 participants
29 discussions

[PATCH] removal of libdhcp
by David Cantrell 21 Dec '08

21 Dec '08

No patch attached because it's quite large. I apologize for the length, but considering this replaces a library and introduces a new struct it meant a new file and changing calls everywhere. http://dcantrel.fedorapeople.org/anaconda/iface/ iface.h - Header file explaining the iface API. iface_t structure replacing pumpNetIntf and networkDeviceConfig, and all of the functions. iface.patch - The changes, it's about 90% complete at this point. *.txt - Explanations and notes. This patch removes anaconda's use of libdhcp, which also means removing libdhcp4client and libdhcp6client. For static network configuration, I am using libnl. To gather current network interface information, I am using libnl. To control IPv6 autoconf, I read/ write /proc since that's all we can do right now. For DHCP and DHCPv6, I run dhclient and dhcp6c, respectively. I'd like everyone to have a look at iface.h and the patch file. It's not complete yet, so I probably know about the obvious things (the FIXMEs and the useless debugging printfs and the incomplete isys.py code and so on). The goal with iface.patch is to get us closer to using NetworkManager in stage 1 and stage 2. I envision the NM changeover to be just as large, but hopefully by then we will have decided to nuke certain parts of loader entirely. Completely eliminating libdhcp and friends will be a nice step. There are some other things that need discussion as well. mkinitrd currently uses libdhcp, for example. This had me thinking we could generate libisys in an anaconda-devel package for things like mkinitrd, but I'm just brainstorming. Maybe I should put the iface code elsewhere? I dunno. At any rate, mkinitrd needs to be not left out. Work in progress, comments welcome. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

8 28

Reipl support
by Mark Hamzy 28 Aug '08

28 Aug '08

Hello, I am working on a feature for the 390 architecture called reipl. It allows the vm to be rebooted into a specific partition. On scenario where this would be usefull is after the initial install, the vm should boot from the newly installed partition and not from the reader (where it initially booted from). It constists of three peices. 1) A Python module, Reipl.py, which reads and writes the settings from the firmware (among other things). 2) A patch to anaconda main python module. At the end of the installation, it will call Reipl.py with the boot partition. It will then write the success of reipl into a file called /var/run/sigusr. 3) A patch to anaconda's loader to read the file /var/run/sigusr and send the appropriate signal (either shutdown or reboot) to linuxrc process. Open issues: 1) Currently, Reipl.py is hard installed into /usr/sbin. I would like to create an rpm package for Reipl consisting of just that file. Is /usr/sbin a good place for it? 2) /usr/sbin is not in sys.path. I have to append sys.path before importing Reipl. Is this okay? Are there any other issues with this code? (See attached file: anaconda-11.1.2.113.patch) (See attached file: Reipl.py) Mark Common Information Model/Web-Based Enterprise Management at http://www.openpegasus.org/ Take a look at the Linux Omni Printer Driver Framework at http://omniprint.sourceforge.net/

5 15

RFE: Support kickstart files in rescue mode - take 2
by Alexander Todorov 11 Aug '08

11 Aug '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hello folks, I've done some more work on this feature and here's the result: *) Add rescue command to pykickstart. Synopsis is: ~ rescue [--nomount | --romount] *) In loader.c - always pass --kickstart <url> to stage 2 *) Add setRescueModeFromKickstart function in anaconda to handle the flag for rescue mode from command line or kickstart. Similar to 'vnc'. *) In anaconda process the kickstart file if present and we're going in rescue mode. *) In rescue.py do: ~ - if nomount then execute %post else; ~ - mount rw by default or read only if kickstart tells us to ~ - write to the log instead of popping up windows ~ - at the end execute %post What is tested with F9 and works is: boot with the following options on cmd line and/or kickstart cmd line | ks.cfg - ---------------+-------- ~ | rescue ~ rescue | ~ rescue | rescue - ---------------+---------------------> shows that we properly enter rescue mode rescue nomount | rescue nomount | rescue ~ | rescue --nomount - ---------------+---------------------> shows that nomount works properly ~ | rescue --nomount --romount -----> expected kickstart error - ---------------+--------------------- ~ | rescue --romount - ---------------+----------------------> shows that read only mount works [1] [1] - rescue --romount will work only when we have %post --nochroot. Looks like it first does chroot and then saves the script text under /tmp for execution. This fails as /tmp is on the chrooted read-only file system. Sounds expected to me. Thanks, Alexander. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org iD8DBQFIjxJShmd3WOiFct4RCqtwAJ0d1igC6wf27Jedhx4a1jX8t8Y6dQCgtXVB 6BLXIvs/imXfQAfdvOV3pRc= =8Af3 -----END PGP SIGNATURE-----

3 7

[PATCH] add xfs tools to KEEPFILEGR
by Eric Sandeen 31 Jul '08

31 Jul '08

I guess these are somewhat big; maybe the reason for them being AWOL? -rwxr-xr-x 1 root root 518160 2007-10-23 21:34 /sbin/xfs_repair -rwxr-xr-x 1 root root 485584 2007-10-23 21:34 /usr/sbin/xfs_db If there's room.... Thanks, -Eric Index: devel/anaconda-11.4.1.9/scripts/upd-instroot =================================================================== --- devel.orig/anaconda-11.4.1.9/scripts/upd-instroot 2008-06-25 16:25:41.000000000 -0500 +++ devel/anaconda-11.4.1.9/scripts/upd-instroot 2008-07-31 15:42:41.212166111 -0500 @@ -597,6 +597,7 @@ sbin/fsck.ext2 sbin/fsck.ext3 sbin/fsck.jfs sbin/fsck.reiserfs +sbin/xfs_repair sbin/parted sbin/silo sbin/tune2fs @@ -662,6 +663,7 @@ usr/sbin/ddcprobe usr/sbin/fbset usr/sbin/prelink usr/sbin/smartctl +usr/sbin/xfs_db usr/share/anaconda usr/share/fonts/dejavu/DejaVuSans.ttf usr/share/fonts/dejavu/DejaVuSans-Bold.ttf

1 0

[PATCH] use newer mke2fs arguments for different filesystems
by Eric Sandeen 29 Jul '08

29 Jul '08

We had been hard-coding various args to mke2fs to try to get what we wanted, but newer mke2fs supports "-t $TYPE" which is much simpler, and harder to get wrong. I must admit to not actually testing this patch, though. -Eric Index: anaconda-11.4.1.20/anaconda.spec =================================================================== --- anaconda-11.4.1.20.orig/anaconda.spec 2008-07-25 15:20:13.000000000 -0500 +++ anaconda-11.4.1.20/anaconda.spec 2008-07-29 08:46:15.313290988 -0500 @@ -32,12 +32,13 @@ BuildRoot: %{_tmppath}/%{name}-%{version %define libbdevidver 5.1.2-1 %define rhpxlver 0.25 %define desktopfileutilsver 0.8 +%define e2fsver 1.41.0 BuildRequires: audit-libs-devel BuildRequires: booty BuildRequires: bzip2-devel BuildRequires: device-mapper-devel >= %{dmver} -BuildRequires: e2fsprogs-devel +BuildRequires: e2fsprogs-devel >= %{e2fsver} BuildRequires: elfutils-devel BuildRequires: gettext >= %{gettextver} BuildRequires: gtk2-devel @@ -84,7 +85,7 @@ Requires: system-config-date >= %{syscfg Requires: device-mapper >= %{dmver} Requires: device-mapper-libs >= %{dmver} Requires: dosfstools -Requires: e2fsprogs +Requires: e2fsprogs >= %{e2fsver} %ifarch %{ix86} x86_64 ia64 Requires: dmidecode %endif Index: anaconda-11.4.1.20/fsset.py =================================================================== --- anaconda-11.4.1.20.orig/fsset.py 2008-07-25 15:20:13.000000000 -0500 +++ anaconda-11.4.1.20/fsset.py 2008-07-29 08:42:36.711291619 -0500 @@ -723,7 +723,7 @@ class ext3FileSystem(extFileSystem): def __init__(self): extFileSystem.__init__(self) self.name = "ext3" - self.extraFormatArgs = [ "-j" ] + self.extraFormatArgs = [ "-t ext3" ] self.partedFileSystemType = parted.file_system_type_get("ext3") if flags.cmdline.has_key("ext4"): self.migratetofs = ['ext4dev'] @@ -757,8 +757,7 @@ class ext4FileSystem(extFileSystem): extFileSystem.__init__(self) self.name = "ext4dev" self.partedFileSystemType = parted.file_system_type_get("ext3") - # 256-byte inodes are actually default now, but let's be sure. - self.extraFormatArgs = [ "-j", "-I", "256", "-E", "test_fs" ] + self.extraFormatArgs = [ "-t ext4dev" ] # this is way way experimental at present... if flags.cmdline.has_key("ext4"):

1 0

Re: Re: Reipl support (David Cantrell)
by Mark Hamzy 28 Jul '08

28 Jul '08

On Tue, 2008-07-22 at 12:10 -1000, David Cantrell wrote: > There's got to be a better way to do this. I mean, it's stage 2 "ipc" > to loader so loader knows whether to send SIGUSR1 or SIGUSR2 to init > so it can do a shutdown or reboot. All of this is automatic, but > sloppy. > > Mark, can we just always reboot in linuxrc.s390 and skip the logic to > figure out if we should reboot or shutdown? This does bring s390 > closer to behavior we see on other platforms. Reboot after > installation. If reipl sets things up correctly, it should reboot in > to the installed system. If, for whatever reason, it failed, we get a > failure on boot, but the system is still shut down. The reason why s390 does a shutdown is to stop it from looping. The 390 reader is loaded with an install image of Redhat. And the reipl information points to that reader image. So, when a reboot is performed, it has the effect of booting into the installer again. Which is not what we want. What you do not see is a failure on reboot. It reboots. The system administrator sees a linux system booting up. It is just not the correct system. So, what issues are we against? The error checking on writing out reipl information? The additional "ipc" to the loader to shutdown on an error? Mark Common Information Model/Web-Based Enterprise Management at http://www.openpegasus.org/ Take a look at the Linux Omni Printer Driver Framework at http://omniprint.sourceforge.net/

4 5

adding testbuild to rhel5 makefile
by Joel Andres Granados 28 Jul '08

28 Jul '08

Hi list: Here is a patch to current Makefile that tries to avoid the build errors that I had last week. It basically adds a "testbuild" target so its easier for the person building anaconda to test the build. The testbuild target will not create a tag because its just a test build:) Commets greatly appreciated.

1 1

RFE: Support kickstart files in rescue mode
by Alexander Todorov 25 Jul '08

25 Jul '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Good morning folks, the requested feature will be useful for automation. I'm targeting rescue mode test automation but it can be used for automating common tasks in rescue mode if one is administering pool of machines. The minimal ks.cfg file is: - --- lang en_US keyboard us network --device eth0 --bootproto dhcp --onboot yes cdrom #url --url http://path/to/stage2.img %post --nochroot mkdir -p /mnt/sysimage mount -t ext3 /dev/sda1 /mnt/sysimage echo "system is mounted" >> /mnt/sysimage/root/rescue.log %end %post cat /etc/fedora-release >> /root/rescue.log uname -a >> /root/rescue.log %end %post --nochroot echo "system will be unmounted" >> /mnt/sysimage/root/rescue.log umount /mnt/sysimage %end Everything before %post is currently parsed and understood by the loader. Currently kickstart is supported only when booting in rescue mode with the "nomount" option because the changes are smaller and easier to review. Patches are coming shortly. Please review them. Thanks, Alexander. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org iD8DBQFIhtouhmd3WOiFct4RCkR4AJ4xjiaqU3xXvKWo926h7imt08SjKgCdHk0N VeNCqaqqftkdoDltYdkfA1o= =fMwO -----END PGP SIGNATURE-----

4 16

[PATCH] rescue.py - handle kickstart in all cases
by Alexander Todorov 25 Jul '08

25 Jul '08

Please review the attached patch. It uses 'rescue' command described here on the list and in: https://www.redhat.com/archives/kickstart-list/2008-July/msg00046.html It's not yet tested, so please consider it preliminary patch. I have to do some more work in anaconda to detect between 'rescue' on the command line or in the ks.cfg before executing runRescue. Will send final patches when this is done and tested. Thanks, Alexander.

1 0

[PATCH] loader will always pass the --kickstart option to stage2
by Alexander Todorov 25 Jul '08

25 Jul '08

diff --git a/loader2/loader.c b/loader2/loader.c index 3b68a93..052cff9 100644 --- a/loader2/loader.c +++ b/loader2/loader.c @@ -2000,6 +2000,11 @@ int main(int argc, char ** argv) { if (FL_NOIPV6(flags)) *argptr++ = "--noipv6"; + if (FL_KICKSTART(flags)) { + *argptr++ = "--kickstart"; + *argptr++ = loaderData.ksFile; + } + if (FL_RESCUE(flags)) { *argptr++ = "--rescue"; if (FL_SERIAL(flags)) @@ -2020,11 +2025,6 @@ int main(int argc, char ** argv) { else if (FL_SELINUX(flags)) *argptr++ = "--selinux"; - if (FL_KICKSTART(flags)) { - *argptr++ = "--kickstart"; - *argptr++ = loaderData.ksFile; - } - if (FL_VIRTPCONSOLE(flags)) { *argptr++ = "--virtpconsole"; *argptr++ = virtpcon;

1 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel July 2008