Anaconda-devel October 2009

anaconda-devel@lists.stg.fedoraproject.org

29 participants
138 discussions

[PATCH] - change our default partitioning scheme
by Chris Lumens 30 Apr '10

30 Apr '10

Here's a patch series that ends up with creating a /home by default. The algorithm is basically: - VG < 50 GB: make /boot, swap, rest as / - VG >= 50 GB: make /boot, swap, / with a 50 GB max, rest as /home Let the arguing begin. - Chris

11 26

[master] Clean up partitioning and rework partition growing
by David Lehman 04 Nov '09

04 Nov '09

partitioning.py | 931 +++++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 657 insertions(+), 274 deletions(-) Lots of cleanups to partitioning code in general. The functional changes are how we allocate growable partitions and the addition of per-disk partition alignment. Partition growing is completely reimplemented. A map of free space regions is collected prior to partition allocation. During partition allocation we choose which disk each growable partition will be allocated from, as well as which free space region on that disk. Partitions are grown as a group within each free space region. Growth rates are determined by the relative base sizes of the partitions within a free space region. All new partitions are aligned for the device from which they are allocated. For now, getDiskAlignment returns an alignment with offset 0 and grainSize of 1 sector, which is sort of a no-op alignment. Once pyparted exports functions/methods to determine the minimal alignment of devices we can replace this no-op alignment with the real deal.

4 26

[master] & [rhel6-branch] various fixes
by David Cantrell 03 Nov '09

03 Nov '09

These patches are intended for master and rhel6-branch. 1) In execWithCallback(), allow callers to disable the stdout printing. Useful when dasdfmt is run because without it all the of the progress information from dasdfmt scrolls by on the 3270 console and obscures other messages. 2) Stop writing the user-supplied hostname to the localhost line in /etc/hosts. What we do currently is breaking virt systems and other programs. 3) Copy over cio_ignore parameter on s390 systems to the /etc/zipl.conf file during post installation setup. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

3 12

[PATCH][master] Select drives in partition dialog, preserving settings. (#529931)
by David Lehman 01 Nov '09

01 Nov '09

--- iw/partition_dialog_gui.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/iw/partition_dialog_gui.py b/iw/partition_dialog_gui.py index bc40faa..c9781e0 100644 --- a/iw/partition_dialog_gui.py +++ b/iw/partition_dialog_gui.py @@ -402,9 +402,9 @@ class PartitionEditor: lbl = createAlignedLabel(_("Allowable _Drives:")) maintable.attach(lbl, 0, 1, row, row + 1) + req_disk_names = [d.name for d in self.origrequest.req_disks] self.driveview = createAllowedDrivesList(self.storage.disks, - self.origrequest.req_disks, - selectDrives=False, + req_disk_names, disallowDrives=[self.anaconda.updateSrc]) lbl.set_mnemonic_widget(self.driveview) sw = gtk.ScrolledWindow() -- 1.6.2.5

2 1

Update the icon used for liveinst (529267)
by Jesse Keating 30 Oct '09

30 Oct '09

Just sending this in so that it gets reviewed. -- Jes

2 4

[PATCH] Regardless of where load_policy is, we still need it in the intird (#532016).
by Chris Lumens 30 Oct '09

30 Oct '09

--- scripts/mk-images | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/scripts/mk-images b/scripts/mk-images index 1ddbe7b..3d32d7d 100755 --- a/scripts/mk-images +++ b/scripts/mk-images @@ -772,6 +772,7 @@ makeinitrd() { instbin $IMGPATH /usr/bin/grep $MBD_DIR /sbin/grep instbin $IMGPATH /usr/bin/kill $MBD_DIR /sbin/kill instbin $IMGPATH /usr/bin/ln $MBD_DIR /sbin/ln + instbin $IMGPATH /usr/sbin/load_policy $MBD_DIR /sbin/load_policy instbin $IMGPATH /usr/bin/mkdir $MBD_DIR /sbin/mkdir instbin $IMGPATH /usr/bin/readlink $MBD_DIR /sbin/readlink instbin $IMGPATH /usr/bin/rm $MBD_DIR /sbin/rm -- 1.6.5.1

2 1

[PATCH] [master] Fix logging of isys mount/umount into program.log.
by Radek Vykydal 30 Oct '09

30 Oct '09

--- isys/imount.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/isys/imount.c b/isys/imount.c index 30b6302..a62e223 100644 --- a/isys/imount.c +++ b/isys/imount.c @@ -119,7 +119,7 @@ int mountCommandWrapper(int mode, char *dev, char *where, char *fs, } programLogFD = open("/tmp/program.log", - O_APPEND|O_CREAT, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH); + O_APPEND|O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH); if (pipe(pipefd)) return IMOUNT_ERR_ERRNO; -- 1.6.0.6

2 1

[PATCH parted 1/7] libparted: add ped_device_get_xxx_alignment() functions
by Hans de Goede 30 Oct '09

30 Oct '09

Add ped_device_get_minimum_alignment() and ped_device_get_optimum_alignment() functions to libparted. Note this is a resent of my previous patchset with a number of typos corrected: aligment -> alignment minimal_alignment -> minimum_aligment optimal_alignment -> optimum_aligment Sorry for the noise. --- include/parted/device.h | 8 ++++++++ include/parted/natmath.h | 1 + libparted/device.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 52 insertions(+), 0 deletions(-) diff --git a/include/parted/device.h b/include/parted/device.h index 151305f..5095b18 100644 --- a/include/parted/device.h +++ b/include/parted/device.h @@ -92,6 +92,8 @@ struct _PedDevice { void* arch_specific; }; +#include <parted/natmath.h> + /** * List of functions implementing architecture-specific operations. */ @@ -112,6 +114,9 @@ struct _PedDeviceArchOps { PedSector (*check) (PedDevice* dev, void* buffer, PedSector start, PedSector count); void (*probe_all) (); + /* These functions are optional */ + PedAlignment *(*get_minimum_alignment)(const PedDevice *dev); + PedAlignment *(*get_optimum_alignment)(const PedDevice *dev); }; #include <parted/constraint.h> @@ -141,6 +146,9 @@ extern PedSector ped_device_check (PedDevice* dev, void* buffer, PedSector start, PedSector count); extern PedConstraint* ped_device_get_constraint (PedDevice* dev); +extern PedAlignment *ped_device_get_minimum_alignment(const PedDevice *dev); +extern PedAlignment *ped_device_get_optimum_alignment(const PedDevice *dev); + /* private stuff ;-) */ extern void _ped_device_probe (const char* path); diff --git a/include/parted/natmath.h b/include/parted/natmath.h index cd7679d..eaa84d1 100644 --- a/include/parted/natmath.h +++ b/include/parted/natmath.h @@ -31,6 +31,7 @@ typedef struct _PedAlignment PedAlignment; #include <parted/disk.h> #include <parted/device.h> +#include <parted/geom.h> #define PED_MIN(a, b) ( ((a)<(b)) ? (a) : (b) ) #define PED_MAX(a, b) ( ((a)>(b)) ? (a) : (b) ) diff --git a/libparted/device.c b/libparted/device.c index 294fec4..4fec1a9 100644 --- a/libparted/device.c +++ b/libparted/device.c @@ -444,5 +444,48 @@ ped_device_get_constraint (PedDevice* dev) return c; } +/** + * Get an alignment that represents minimum hardware requirements on alignment. + * When for example using media that has a physical sector size that is a + * multiple of the logical sector size, it is desirable to have disk accesses + * (and thus partitions) properly aligned. Having partitions not aligned to + * the minimum hardware requirements may lead to a performance penalty. + * + * The returned alignment describes the alignment for the start sector of the + * partition, the end sector should be aligned too, to get the end sector + * alignment decrease the returned alignment's offset by 1. + * + * \return the minimum alignment of partition start sectors, or NULL if this + * information is not available. + */ +PedAlignment* +ped_device_get_minimum_alignment(const PedDevice *dev) +{ + if (ped_architecture->dev_ops->get_minimum_alignment) + return ped_architecture->dev_ops->get_minimum_alignment(dev); + + return NULL; /* ped_alignment_none */ +} + +/** + * Get an alignment that represents the hardware requirements for optimal + * performance. + * + * The returned alignment describes the alignment for the start sector of the + * partition, the end sector should be aligned too, to get the end sector + * alignment decrease the returned alignment's offset by 1. + * + * \return the optimal alignment of partition start sectors, or NULL if this + * information is not available. + */ +PedAlignment* +ped_device_get_optimum_alignment(const PedDevice *dev) +{ + if (ped_architecture->dev_ops->get_optimum_alignment) + return ped_architecture->dev_ops->get_optimum_alignment(dev); + + return NULL; /* ped_alignment_none */ +} + /** @} */ -- 1.6.5.1

1 6

[PATCH parted 1/2] linux: fix crash (un-initialized pointer) when operating on regular files
by Hans de Goede 30 Oct '09

30 Oct '09

* libparted/arch/linux.c (linux_new): When compiled with blkid support initialize arch_specific->probe and arch_specific->topology to NULL, as get_blkid_topology(), which sets them, does not get called for regular files. * libparted/arch/linux.c (get_blkid_topology): No need to set arch_specific->topology to NULL, as this now gets done by linux_new(). --- libparted/arch/linux.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c index 3069c59..7908c46 100644 --- a/libparted/arch/linux.c +++ b/libparted/arch/linux.c @@ -598,8 +598,6 @@ _have_kern26 () static void get_blkid_topology (LinuxSpecific *arch_specific) { - arch_specific->topology = NULL; - arch_specific->probe = blkid_new_probe (); if (!arch_specific->probe) return; @@ -1249,6 +1247,10 @@ linux_new (const char* path) goto error_free_path; arch_specific = LINUX_SPECIFIC (dev); arch_specific->dmtype = NULL; +#if USE_BLKID + arch_specific->probe = NULL; + arch_specific->topology = NULL; +#endif dev->open_count = 0; dev->read_only = 0; -- 1.6.5.1

1 1

[PATCH parted 1/7] libparted: add ped_device_get_xxx_alignment() functions
by Hans de Goede 30 Oct '09

30 Oct '09

2 8

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel October 2009