Anaconda-devel March 2009

anaconda-devel@lists.stg.fedoraproject.org

29 participants
265 discussions

[PATCH storage] Fix member preselection in raid UI.
by Radek Vykydal 17 Apr '09

17 Apr '09

It was broken (empty) when editing non-preexisting array. --- iw/raid_dialog_gui.py | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/iw/raid_dialog_gui.py b/iw/raid_dialog_gui.py index 578e3e7..d74ddd0 100644 --- a/iw/raid_dialog_gui.py +++ b/iw/raid_dialog_gui.py @@ -63,12 +63,13 @@ class RaidEditor: partname = "%s" % part.name partsize = "%8.0f MB" % part.size - if not self.origrequest.exists: - partlist.append_row((partname, partsize), False) + if part in tempDevList: + #list the partition and put it as selected + partlist.append_row((partname, partsize), True) else: - if part in tempDevList: - #list the partition and put it as selected - partlist.append_row((partname, partsize), True) + if not self.origrequest.exists: + partlist.append_row((partname, partsize), False) + return (partlist, sw) -- 1.5.4.3

2 1

[PATCH] rhel5-branch
by Joel Granados Moreno 02 Apr '09

02 Apr '09

Hello list patch1 : checks for dns in s390. patch2 : makes sure ipv6 is setup correctly when defined review appreciated. FYI, the patches are small modifications of the ones contained in the bugs. Joel Andres Granados Brno, Czech Republic, Red Hat.

3 5

storage UI patches
by David Cantrell 31 Mar '09

31 Mar '09

Two patches to fix problems with the partition editor dialog box. For regular partitions (i.e., not LVM and not RAID), users could not uncheck 'Format' once they selected it. There were also some problems with UI flow between format, migrate, and resize. I've tried to clean that up with these patches. LVM and RAID partition editing will probably need some small changes to go along with these changes, but I wanted to do those after these are reviewed. -- David Cantrell <dcantrell(a)redhat.com> Red Hat, Inc. / Honolulu, HI

3 6

[PATCH 1/2] Look for a PReP "partition" by examining the format, not the flags (#492426).
by Chris Lumens 31 Mar '09

31 Mar '09

--- booty/ppc.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/booty/ppc.py b/booty/ppc.py index e87f69e..c187149 100644 --- a/booty/ppc.py +++ b/booty/ppc.py @@ -16,11 +16,11 @@ class ppcBootloaderInfo(bootloaderInfo): if machine == 'pSeries': for dev in self.storage.fsset.devices: - if dev.partedFlags[parted.PARTITION_PREP] and not dev.format.exists: + if dev.format.type == "prepboot": retval.append(dev.path) elif machine == 'PMac': for dev in self.storage.fsset.devices: - if dev.format.type == "hfs" and dev.format.bootable and not dev.format.exists: + if dev.format.type == "hfs" and dev.format.bootable: retval.append(dev.path) if len(retval) == 0: -- 1.6.1.3

2 3

[PATCH] Fix the check for if there's enough space available on / and /usr (#492614).
by Chris Lumens 31 Mar '09

31 Mar '09

--- yuminstall.py | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/yuminstall.py b/yuminstall.py index b91172a..42a74b5 100644 --- a/yuminstall.py +++ b/yuminstall.py @@ -1324,14 +1324,7 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon (self.dlpkgs, self.totalSize, self.totalFiles) = self.ayum.getDownloadPkgs() if not anaconda.id.getUpgrade(): - usrPart = None - for fs in anaconda.id.storage.devicetree.filesystems: - if fs.mountpoint == "/usr": - usrPart = fs - if usrPart is not None: - largePart = usrPart - else: - largePart = anaconda.id.storage.fsset.rootDevice + largePart = anaconda.id.storage.fsset.mountpoints.get("/usr", anaconda.id.storage.fsset.rootDevice) if largePart and largePart.size < self.totalSize / 1024: rc = anaconda.intf.messageWindow(_("Error"), -- 1.6.1.3

2 1

[PATCH 1/2] Fix some pylint warnings in iw/*.py
by Hans de Goede 31 Mar '09

31 Mar '09

--- iw/netconfig_dialog.py | 1 - iw/partition_gui.py | 10 +--------- iw/partition_ui_helpers_gui.py | 28 ++++++++++++++-------------- 3 files changed, 15 insertions(+), 24 deletions(-) diff --git a/iw/netconfig_dialog.py b/iw/netconfig_dialog.py index c87da21..3941d3a 100644 --- a/iw/netconfig_dialog.py +++ b/iw/netconfig_dialog.py @@ -27,7 +27,6 @@ from constants import * import gettext _ = lambda x: gettext.ldgettext("anaconda", x) -import gui import network import isys diff --git a/iw/partition_gui.py b/iw/partition_gui.py index 3f7aa95..24559ee 100644 --- a/iw/partition_gui.py +++ b/iw/partition_gui.py @@ -129,13 +129,6 @@ class DiskStripeSlice: return "cornsilk2" return "cornsilk1" - def hideOrShowText(self): - return - if self.box.get_bounds()[2] < self.text.get_bounds()[2]: - self.text.hide() - else: - self.text.show() - def sliceText(self): if self.partition.type & parted.PARTITION_EXTENDED: return "" @@ -178,7 +171,6 @@ class DiskStripeSlice: fill_color='black', anchor=gtk.ANCHOR_NW, clip=True, clip_width=xlength-1, clip_height=yheight-1) - self.hideOrShowText() def __init__(self, parent, partition, treeView, editCB): self.text = None @@ -483,8 +475,8 @@ class DiskTreeModel(gtk.TreeStore): # not found the partition raise RuntimeError, "could not find partition" - """ Return the device representing the current selection """ def getCurrentDevice(self): + """ Return the device representing the current selection """ selection = self.view.get_selection() model, iter = selection.get_selected() if not iter: diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py index ede0200..0ad1803 100644 --- a/iw/partition_ui_helpers_gui.py +++ b/iw/partition_ui_helpers_gui.py @@ -280,22 +280,22 @@ def formatMigrateOptionCB(widget, data): setMntPtComboStateFromType(ofstype, mntptcombo) -""" createPreExistFSOptionSection: given inputs for a preexisting partition, - create a section that will provide format and migrate options - - Returns the value of row after packing into the maintable, - and a dictionary consistenting of: - formatcb - checkbutton for 'format as new fs' - fstype - part of format fstype menu - fstypeMenu - part of format fstype menu - migratecb - checkbutton for migrate fs - migfstypeMenu - menu for migrate fs types - lukscb - checkbutton for 'encrypt using LUKS/dm-crypt' - resizecb - checkbutton for 'resize fs' - resizesb - spinbutton with resize target -""" def createPreExistFSOptionSection(origrequest, maintable, row, mountCombo, partitions, ignorefs=[], luksdev=None): + """ createPreExistFSOptionSection: given inputs for a preexisting partition, + create a section that will provide format and migrate options + + Returns the value of row after packing into the maintable, + and a dictionary consistenting of: + formatcb - checkbutton for 'format as new fs' + fstype - part of format fstype menu + fstypeMenu - part of format fstype menu + migratecb - checkbutton for migrate fs + migfstypeMenu - menu for migrate fs types + lukscb - checkbutton for 'encrypt using LUKS/dm-crypt' + resizecb - checkbutton for 'resize fs' + resizesb - spinbutton with resize target + """ rc = {} if luksdev: -- 1.6.2

2 2

[PATCH] Don't start our audit daemon with the livecd installer
by Jeremy Katz 31 Mar '09

31 Mar '09

On the livecd install, the normal audit daemon is running, so we don't need to start our own. This also keeps us from leaving around a stray process on exit (#492513) --- anaconda | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/anaconda b/anaconda index 4dcf113..ac9198a 100755 --- a/anaconda +++ b/anaconda @@ -674,7 +674,7 @@ if __name__ == "__main__": if iutil.isS390(): opts.isHeadless = True - if not flags.test and not flags.rootpath: + if not flags.test and not flags.rootpath and not flags.livecdInstall: isys.auditDaemon() users.createLuserConf(anaconda.rootPath) -- 1.6.1

2 1

pylint bugreport: fails on a relative import
by Hans de Goede 31 Mar '09

31 Mar '09

Hi All, Short intro: I'm a long time foss enthusiast / developer (10+ years), recently (6 months ago) I've started working for RedHat on the RHEL / Fedora installer: anaconda, which is written in python. I'm trying to use pylint to check anaconda's sources with varying success, and I'm hitting what I believe to be a pylint bug. Here is one of the messages I'm seeing which I believe are caused by this pylint bug: ************* Module storage.formats.swap F: 26: Unable to import 'devicelibs' (No module named devicelibs) The import line in question is: "from ..devicelibs import swap" Note that we have the following dir hierarchy: storage storage/__init__.py storage/errors.py storage/<other>.py storage/devicelibs/__init__.py storage/devicelibs/<other>.py storage/formats/__init__.py storage/formats/<other>.py Right above the failing import from devicelibs, we have: "from ..errors import *" pylint does sucessfully handle this, but the relative import of the devicelibs (sub)package seems to confuse it. Note that it does also give a number of the following (somewhat scary messages) while processing anaconda's storage module: Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored Exception RuntimeError: 'maximum recursion depth exceeded in __subclasscheck__' in <type 'exceptions.AttributeError'> ignored To get the anaconda sourcecode do the following: git clone http://git.fedorahosted.org/git/anaconda.git <go get some coffee, it contains years of history> cd anaconda If you want to reproduce the problem, you may need to take a few other steps to be able to run pylint successfully on the storage package: 1) You will need to make the native isys module: cd isys make 2) You will need to install pyparted: https://fedorahosted.org/releases/p/y/pyparted/ 3) You will need to install pyblock: git clone http://git.fedorahosted.org/git/pyblock.git 4) You will need to run pylint as root, as pyparted refuses to be imported as normal user (or patch pyparted to not do this check, which we need to remove anyways). Here is how I run pylint: sudo pylint --init-hook='import sys; sys.path.insert(1, "isys")' --disable-msg-cat=CRW -r n storage Thanks for your time & Regards, Hans

1 0

[PATCH] If there's a problem finding removable disks, disable save-to-disk.
by Chris Lumens 31 Mar '09

31 Mar '09

Catching all exception is really drastic, but this is the exception reporting code and we need it to be resiliant to extra errors so we stand a chance of getting things reported. --- gui.py | 5 ++++- text.py | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gui.py b/gui.py index 3c1b6fd..de165bf 100755 --- a/gui.py +++ b/gui.py @@ -743,7 +743,10 @@ class SaveExceptionWindow: store = gtk.ListStore(gobject.TYPE_STRING, gobject.TYPE_STRING) - dests = anaconda.id.storage.exceptionDisks() + try: + dests = anaconda.id.storage.exceptionDisks() + except: + dests = [] if flags.livecdInstall: self.destCombo.remove_text(0) diff --git a/text.py b/text.py index 8d6c6e5..93aea97 100644 --- a/text.py +++ b/text.py @@ -242,7 +242,10 @@ class SaveExceptionWindow: toplevel.add(scpGrid, 0, 5, (0, 0, 0, 1)) toplevel.add(buttons, 0, 6, growx=1) - dests = self.anaconda.id.storage.exceptionDisks() + try: + dests = self.anaconda.id.storage.exceptionDisks() + except: + dests = [] if len(dests) > 0: for (dev, desc) in dests: -- 1.6.1.3

2 2

[PATCH 2/2] Work around gcc bug #492973
by David Cantrell 31 Mar '09

31 Mar '09

Problem with -O2 and some string functions with the latest version of gcc in rawhide. Work around the problem for now so we can compile, ideally we can revert this patch in the future. gcc bug: https://bugzilla.redhat.com/show_bug.cgi?id=492973 --- isys/eddsupport.c | 2 +- loader/copy.c | 2 +- loader/dirbrowser.c | 4 ++-- loader/fwloader.c | 2 +- loader/getparts.c | 2 +- loader/loader.c | 2 +- loader/net.c | 2 +- loader/nfsinstall.c | 2 +- loader/undomounts.c | 4 ++-- loader/urls.c | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/isys/eddsupport.c b/isys/eddsupport.c index ae974c5..242021a 100644 --- a/isys/eddsupport.c +++ b/isys/eddsupport.c @@ -168,7 +168,7 @@ static int mapBiosDisks(struct device** devices,const char *path) { } while ((entry = readdir(dirHandle)) != NULL) { - if(!strncmp(entry->d_name,".",1) || !strncmp(entry->d_name,"..",2)) { + if(!(strncmp)(entry->d_name,".",1) || !(strncmp)(entry->d_name,"..",2)) { continue; } ret = sscanf((entry->d_name+9), "%x", &biosNum); diff --git a/loader/copy.c b/loader/copy.c index 1c61233..3a7a0c7 100644 --- a/loader/copy.c +++ b/loader/copy.c @@ -63,7 +63,7 @@ int copyDirectory(char * from, char * to, void (*warnFn)(char *), errno = 0; while ((ent = readdir(dir))) { - if (!strcmp(ent->d_name, ".") || !strcmp(ent->d_name, "..")) + if (!(strcmp)(ent->d_name, ".") || !(strcmp)(ent->d_name, "..")) continue; sprintf(filespec, "%s/%s", from, ent->d_name); diff --git a/loader/dirbrowser.c b/loader/dirbrowser.c index 6c713ec..eb10c5d 100644 --- a/loader/dirbrowser.c +++ b/loader/dirbrowser.c @@ -83,9 +83,9 @@ static char ** get_file_list(char * dirname, files = malloc(numfiles * sizeof(char *)); while ((entry = readdir(dir))) { - if ((strlen(entry->d_name) == 1) && !strncmp(entry->d_name, ".", 1)) + if ((strlen(entry->d_name) == 1) && !(strncmp)(entry->d_name, ".", 1)) continue; - if ((strlen(entry->d_name) == 2) && !strncmp(entry->d_name, "..", 2)) + if ((strlen(entry->d_name) == 2) && !(strncmp)(entry->d_name, "..", 2)) continue; if (filterfunc && filterfunc(dirname, entry)) continue; diff --git a/loader/fwloader.c b/loader/fwloader.c index 2ab8c7f..f4fac38 100644 --- a/loader/fwloader.c +++ b/loader/fwloader.c @@ -209,7 +209,7 @@ static int get_netlink_msg(struct fw_loader *fwl, struct uevent *uevent) size = sizeof (buffer) - 1; buffer[size] = '\0'; - len = strcspn(buffer, "@"); + len = (strcspn)(buffer, "@"); if (!buffer[len]) return -1; diff --git a/loader/getparts.c b/loader/getparts.c index 8d2b7c4..6907229 100644 --- a/loader/getparts.c +++ b/loader/getparts.c @@ -94,7 +94,7 @@ char **getPartitionsList(char * disk) { break; } else if (toknum == 2) { /* if size is exactly 1 then ignore it as an extended */ - if (!strcmp(b, "1")) + if (!(strcmp)(b, "1")) break; } else if (toknum == 3) { /* this should be the partition name */ diff --git a/loader/loader.c b/loader/loader.c index 98ea24c..019b2d7 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -2082,7 +2082,7 @@ int main(int argc, char ** argv) { path = getenv("PATH"); while (path && path[0]) { - int n = strcspn(path, ":"); + int n = (strcspn)(path, ":"); char c, *binpath; c = path[n]; diff --git a/loader/net.c b/loader/net.c index 3a3fae9..3da4f1e 100644 --- a/loader/net.c +++ b/loader/net.c @@ -86,7 +86,7 @@ static void cidrCallback(newtComponent co, void * dptr) { abort(); } - if (strcmp(data->ipv4, "")) + if ((strcmp)(data->ipv4, "")) upper = 32; #ifdef ENABLE_IPV6 } else if (co == data->cidr6Entry) { diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c index 1a81547..d15e7a6 100644 --- a/loader/nfsinstall.c +++ b/loader/nfsinstall.c @@ -89,7 +89,7 @@ static int nfsGetSetup(char ** hostptr, char ** dirptr) { do { rc = newtWinEntries(_("NFS Setup"), buf, 60, 5, 15, 24, entries, _("OK"), _("Back"), NULL); - } while (!strcmp(newServer, "") || !strcmp(newDir, "")); + } while (!(strcmp)(newServer, "") || !(strcmp)(newDir, "")); free(buf); free(entries[1].text); diff --git a/loader/undomounts.c b/loader/undomounts.c index 1884ce6..798bf11 100644 --- a/loader/undomounts.c +++ b/loader/undomounts.c @@ -156,8 +156,8 @@ void unmountFilesystems(void) { while (*chptr != ' ') chptr++; *chptr++ = '\0'; - if (strcmp(start, "/") && strcmp(start, "/tmp") && - strcmp(start, "/dev")) { + if ((strcmp)(start, "/") && (strcmp)(start, "/tmp") && + (strcmp)(start, "/dev")) { filesystems[numFilesystems].name = strdup(start); filesystems[numFilesystems].what = FS; filesystems[numFilesystems].mounted = 1; diff --git a/loader/urls.c b/loader/urls.c index a46e034..9158fa8 100644 --- a/loader/urls.c +++ b/loader/urls.c @@ -136,7 +136,7 @@ static char * getLoginName(char * login, struct iurlinfo *ui) { char *convertUIToURL(struct iurlinfo *ui) { char *login, *finalPrefix, *url, *p; - if (!strcmp(ui->prefix, "/")) + if (!(strcmp)(ui->prefix, "/")) finalPrefix = "/."; else finalPrefix = ui->prefix; -- 1.6.2

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel March 2009