Anaconda-devel May 2009

anaconda-devel@lists.stg.fedoraproject.org

26 participants
117 discussions

[PATCH 1/2] Don't populate flags.cmdline with "True" values when no = is used.
by Peter Jones 12 Aug '09

12 Aug '09

Since all tests are either flags.cmdline.has_key() or "if flags.cmdline.get()", we want this to be None when there's no equals sign, rather than True. --- flags.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/flags.py b/flags.py index 8dbcc9f..d49b252 100644 --- a/flags.py +++ b/flags.py @@ -59,7 +59,7 @@ class Flags: (key, val) = i.split("=", 1) except: key = i - val = True + val = None cmdlineDict[key] = val -- 1.6.2.2

3 3

[PATCH] Do not go interactive if timezone in ks is not valid (#473647).
by Radek Vykydal 07 Aug '09

07 Aug '09

Handle invalid timezones in ks the same way as in RHEL 5.4: in case that the timezone is invalid, the system time of install environment will be set correctly if it is in tzdata package, and even if it is not there the ks install will proceed. This will prevent possible breaking of installs with kickstarts working in older versions of RHEL. The question may be if we can/want to broaden valid timezones to all those present in tzdata package officialy (document it). Complete tzdata package is part of stage2 in Fedora and will be in RHEL 5.4. --- kickstart.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/kickstart.py b/kickstart.py index 474ecec..ae6ae3a 100644 --- a/kickstart.py +++ b/kickstart.py @@ -881,8 +881,7 @@ class Timezone(commands.timezone.FC6_Timezone): tab = zonetab.ZoneTab() if self.timezone not in (entry.tz.replace(' ','_') for entry in tab.getEntries()): - log.warning("Timezone %s set in kickstart is not valid, will ask" % (self.timezone,)) - return retval + log.warning("Timezone %s set in kickstart is not valid." % (self.timezone,)) self.handler.id.timezone.setTimezoneInfo(self.timezone, self.isUtc) self.handler.skipSteps.append("timezone") -- 1.5.4.3

2 1

[PATCH] Changes for using md on top isw format
by Jacek Danecki 18 Jun '09

18 Jun '09

Hi, This series of 6 patches obsoletes patches sent in topic "Changes for using mdadm for isw_raid_member". All patches were rebased to the version anaconda-11.5.0.42.1. These patches need pyparted >= 2.0.11 and patch for mdadm which add support for -E --export option. MD containers and arrays are created in directory /dev/md as links to devices in /dev Activation of MD arrays is done by adding disks to the array using command mdadm -I. MDRaidArrayDevice._devDir value was changed to "/dev/md" MD arrays are visible as HARD Drives, and can be partitioned. MD containers are displayed as RAID Devices. Support for new kernel parameter iswmd was changed. Please review. Regards

5 58

[PATCH][RHEL5.4] sleep for N seconds before getting ks file (#460566)
by Jeffrey Bastian 04 Jun '09

04 Jun '09

At least 3 customers have reported issues with reading the kickstart file from a USB device (hard drive, flash thumb drive, and CD-ROM). It appears the problem is simply some devices are slow to initialize after loading the usb-storage.ko driver, and anaconda doesn't wait long enough before trying to read from them. See https://bugzilla.redhat.com/show_bug.cgi?id=460566 The attached patch adds a kssleep=N command line option to sleep for N seconds before attempting to read the kickstart file. This was reported earlier for Fedora 8 in bug 452865, however, the code has changed quite drastically between RHEL5 and Fedora 8, so a RHEL 5 solution will not apply to Fedora and vice-versa. The problem is easy to duplicate -- just put the kickstart file on a USB device -- but it requires hardware that exhibits the problem. We've duplicated it on an IBM x3650, and it's also been reported on an IBM BladeCenter HS21 and a Sun Fire X4450. Jeff Bastian

3 6

[PATCH] Fix lv resize (#501000)
by David Lehman 31 May '09

31 May '09

These patches fix two bugs in resizing. The first patch applies to both partitions and lvs, fixing sorting so that we correctly sequence device and filesystem resize actions. The second patch is for lvresize, so it will complete without interaction. These are for rawhide/master, but I think that at least the first patch might be worth consideration for F11. Thoughts?

2 4

[PATCH] Enforce limits on the number of partitions on a disk.
by David Lehman 29 May '09

29 May '09

Ignore preexisting disks with too many partitions. Also make sure we don't try to allocate more than the maximum allowed number of partitions from a disk during partitioning. --- storage/devicetree.py | 37 +++++++++++++++++++++++++++++++++++++ storage/partitioning.py | 9 +++++++++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/storage/devicetree.py b/storage/devicetree.py index f026348..c2241c5 100644 --- a/storage/devicetree.py +++ b/storage/devicetree.py @@ -21,6 +21,7 @@ # import os +import sys import block import re @@ -33,6 +34,7 @@ import formats import devicelibs.mdraid from udev import * from iutil import log_method_call +from constants import productName import gettext _ = lambda x: gettext.ldgettext("anaconda", x) @@ -120,6 +122,31 @@ def getLUKSPassphrase(intf, device, globalPassphrase): return (passphrase, isglobal) +def handleDiskMaxPartitionsExceeded(intf, device): + """ Ask user how to handle disk with too many partitions. + + Choices are to ignore the disk or to exit the installer. + + A return value of True indicates the user wants to continue with + installation without using this device. + """ + maxPartitionCount = device.partedDisk.maxPrimaryPartitionCount + \ + device.partedDisk.getMaxLogicalPartitions() + str = _("The drive %s has more than %d partitions on it," + "which is the maximum number of partitions for disk of " + "this type. You will not be able to make changes to the " + "partitioning of this disk or use any partitions beyond " + "%s%d in %s") % (device.path, maxPartitionCount, device.name, + maxPartitionCount, productName) + + rc = intf.messageWindow(_("Warning"), str, type="custom", + custom_buttons = [_("_Reboot"), _("_Ignore")], + custom_icon="warning") + if rc == 0: + sys.exit(0) + + return True + # Don't really know where to put this. def questionInitializeDisk(intf=None, name=None): retVal = False # The less destructive default @@ -1114,6 +1141,16 @@ class DeviceTree(object): self.addIgnoredDisk(name) return + # make sure the disk does not have more partitions than are supported + if device.mediaPresent: + maxPartitionCount = device.partedDisk.maxPrimaryPartitionCount + \ + device.partedDisk.getMaxLogicalPartitions() + + if len(device.partedDisk.partitions) > maxPartitionCount and \ + handleDiskMaxPartitionsExceeded(self.intf, device): + self.addIgnoredDisk(name) + return + self._addDevice(device) # If this is a mac-formatted disk we just initialized, make sure the diff --git a/storage/partitioning.py b/storage/partitioning.py index 8e9ab3c..f2c036f 100644 --- a/storage/partitioning.py +++ b/storage/partitioning.py @@ -697,6 +697,15 @@ def allocatePartitions(disks, partitions): # loop through disks for _disk in req_disks: disk = partedDisks[_disk.path] + + # check if we can allocate new partitions from this disk + max_parts = disk.maxPrimaryPartitionCount + \ + disk.getMaxLogicalPartitions() + if len(disk.partitions) >= max_parts: + log.debug("disk %s already has its maximum allowable number" + " of partitions (%d)" % (_disk.name, max_parts)) + continue + #for p in disk.partitions: # log.debug("disk %s: part %s" % (disk.device.path, p.path)) sectorSize = disk.device.physicalSectorSize -- 1.6.0.6

4 4

Re: One (more) week slip of Fedora 11 Release
by Bill Nottingham 29 May '09

29 May '09

John Poelstra (poelstra(a)redhat.com) said: > Jesse Keating said the following on 05/28/2009 10:36 AM Pacific Time: >> A late discovered and just potentially fixed anaconda storage bug[1] has >> necessitated another week slip of our schedule. The change is important >> but invasive enough to require re-validating our storage tests. ... > > Forgive me for asking the obvious.... have we done a review of all the > open anaconda bugs for 'rawhide' to make sure there are no other bugs > already open for anaconda that could put us back into this same > situation? Not knowing if this had been formally done or not, I figured I'd look. I looked at all open rawhide anaconda bugs opened on March 1 or later. (126 bugs). The following list of 28 bugs are all crashers or things that render the system non-bootable. Some of these may be fixed already; some may not be fixable, some may have workarounds we can put on the common bug page. But if there are any other open bugs like 500808, they'd be in this list; if someone wants to do a sanity review to see if any of these are worth holding out for, go for it. https://bugzilla.redhat.com/show_bug.cgi?id=489991 Anaconda crashes when disks with no partitions contain a filesystem https://bugzilla.redhat.com/show_bug.cgi?id=491754 DeviceError: cannot commit to disk sda after 5 attempts https://bugzilla.redhat.com/show_bug.cgi?id=493058 Custom partitioning creation/edit causes traceback https://bugzilla.redhat.com/show_bug.cgi?id=493699 Traceback while installing with lvm/luks https://bugzilla.redhat.com/show_bug.cgi?id=494150 anaconda exception when formatting drives https://bugzilla.redhat.com/show_bug.cgi?id=495139 Anaconda traceback when installing with another LVM already existing https://bugzilla.redhat.com/show_bug.cgi?id=495356 Unhandled exception at the end of partitioning https://bugzilla.redhat.com/show_bug.cgi?id=495433 Anaconda crash: Error opening /dev/sdb: No medium found https://bugzilla.redhat.com/show_bug.cgi?id=496440 RAID1 volume create failed https://bugzilla.redhat.com/show_bug.cgi?id=497183 Installation fails with partition scheme https://bugzilla.redhat.com/show_bug.cgi?id=497293 allocatePartitions extended partition handling needs work https://bugzilla.redhat.com/show_bug.cgi?id=498240 Anaconda exception on upgrading from F10 https://bugzilla.redhat.com/show_bug.cgi?id=498350 Anaconda crashes in the partitioner screen https://bugzilla.redhat.com/show_bug.cgi?id=498408 Anaconda crash during install: MDRaidError: mddeactivate failed for /dev/md1 https://bugzilla.redhat.com/show_bug.cgi?id=498486 MDRaidError: mdactivate failed for /dev/md2 https://bugzilla.redhat.com/show_bug.cgi?id=498553 FSError: filesystem has not been created https://bugzilla.redhat.com/show_bug.cgi?id=498751 Failure at the start of Live install - device is already mapped https://bugzilla.redhat.com/show_bug.cgi?id=495156 FSError: mount failed: (2, None) https://bugzilla.redhat.com/show_bug.cgi?id=498820 ValueError: Cannot remove extended partition sda4. Logical partitions present. https://bugzilla.redhat.com/show_bug.cgi?id=499062 SystemError: (2, None) https://bugzilla.redhat.com/show_bug.cgi?id=499733 Anaconda does not see Individual SATA11 drives -- linux nodmraid is ineffective https://bugzilla.redhat.com/show_bug.cgi?id=500132 swap format error - SwapSpaceError: format has not been created https://bugzilla.redhat.com/show_bug.cgi?id=500995 TypeError: float() argument must be a string or a number https://bugzilla.redhat.com/show_bug.cgi?id=501297 AttributeError: 'DeviceFormat' object has no attribute 'mount' https://bugzilla.redhat.com/show_bug.cgi?id=501340 FormatSetupError: format has not been created https://bugzilla.redhat.com/show_bug.cgi?id=501584 Initial initramfs created during installation has no keymap support https://bugzilla.redhat.com/show_bug.cgi?id=502092 RuntimeError: Returning partitions to state prior to edit failed https://bugzilla.redhat.com/show_bug.cgi?id=502663 backtrace when setting up md raid.

2 2

[PATCH master] import os.path in firewall.py
by Joel Granados Moreno 29 May '09

29 May '09

Hello list. The import is missing for some reason. Regards. Joel Andres Granados Brno, Czech Republic, Red Hat.

2 2

[PATCH] rhel5 add support for IGB VF device
by Joel Granados Moreno 29 May '09

29 May '09

Hello list. Trivial patch for adding IGB VF device to the installer. For background look at: https://bugzilla.redhat.com/show_bug.cgi?id=502875 Does anyone know if this _is_ a eth? Regards. Joel Andres Granados Brno, Czech Republic, Red Hat.

2 2

[PATCH] rhel5 ipcalc thing
by Joel Granados Moreno 29 May '09

29 May '09

Hello list. this is what I think is causing the ipcalc to not get into the initrd.img. Regards. Joel Andres Granados Brno, Czech Republic, Red Hat.

3 3

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel May 2009