Anaconda-devel August 2009

anaconda-devel@lists.stg.fedoraproject.org

36 participants
124 discussions

2 patches for loader - method selection
by Radek Vykydal 08 Sep '09

08 Sep '09

Both patches are tested quite a lot. If you can come up with a case of what should be tested that I missed, I'll be happy to test it. (I tested with pxe: ui/ks/stage2/repo X correct/incorrect url, 1/2 devices, tcp/ip config Retry). I am not sure about media + askmethod +/- stage2 case - does it itself work as expected? Jeremy patched it for bug 516973, but it doesn't seem to work in 12.16.

2 6

[master] account for NetworkManager change
by David Cantrell 31 Aug '09

31 Aug '09

NetworkManager was kind enough to rename libnm_glib.pc to libnm-glib.pc. This is really stuff that should be reserved for the release candidate freeze. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 2

[PATCH] Save duplicates from /etc/fstab and don't traceback (#517498).
by Chris Lumens 31 Aug '09

31 Aug '09

--- storage/__init__.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/storage/__init__.py b/storage/__init__.py index d05a8a5..a339d00 100644 --- a/storage/__init__.py +++ b/storage/__init__.py @@ -1490,7 +1490,11 @@ class FSSet(object): continue if device not in self.devicetree.devices: - self.devicetree._addDevice(device) + try: + self.devicetree._addDevice(device) + except ValueError: + # just write duplicates back out post-install + self.preserveLines.append(line) def fsFreeSpace(self, chroot='/'): space = [] -- 1.6.4

2 1

[PATCH] Misc. Patches for rawhide/master
by David Lehman 31 Aug '09

31 Aug '09

Some low-hanging fruit. __init__.py | 6 ++++-- formats/fs.py | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-)

2 4

Issues with dracut and network device naming
by Hans de Goede 31 Aug '09

31 Aug '09

Hi all, When using iscsi for example, an interface name (usually eth#) is specified on the dracut cmdline, but if a machine has multiple nics the probe order done by dracut may very well differ as the one which was used during install when the dracut cmdline gets generated. For the fcoe support I've allowed specifying a mac address instead, however this has issues too. As now the udev run from rc.sysinit complains it cannot rename the interface to what the running system expects as the interface is busy (oops). So it looks like we need to somehow tell dracut to use the same mac <-> interface name mapping as during the running system. One way of doing this would be to have a configuration initrd with the persistent net rules. But I see multiple issues with this: 1) I'm not sure all bootloaders support loading multiple initrd's and I'm not sure dracut supports having files over multiple initrd's at the moment either 2) Merging the generic initrd and the config initrd, although it should be safe may turn out fragile 3) To me the biggest problem. Currently what dracut does is very transparent, if we know the cmdline and the hardware configuration / disk layouts, we should be able to predict what it is going to do Once we start hiding configration inside an image file, it becames less transparent 4) I don't know how well the persistent network device rules and our current generated during boot network device rules play together. The current generated rules do not seem to be ready for handling device name changes So I would like to propose another solution for this, allow specifying both an interface-name and a mac with ip=, and then have the dracut generated rules do the rename and init. This way problems 3) and 4) above are solved, and we can easily also write the mac address to grub.conf from anaconda when generating the ip= cmdline. Regards, Hans

5 10

[master] s390x image building patches
by David Cantrell 28 Aug '09

28 Aug '09

Assorted patches for scripts/* tools that build initrd.img and install.img. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

4 16

FutureFeature: anaconda stage1 shell?
by Paul Franklin 28 Aug '09

28 Aug '09

I am having trouble installing F11 and the problem is at an early stage, before the graphic installer starts. (In fact, it is complaining it can't find the (remote) install.img file.) So I am wondering if it would be possible to add a shell to the stage1 in anaconda, the same way one appears on the console window 2 once the GUI stage2 starts? Thanks.

2 5

[PATCH] On kickstart installs, you can't select a different parttype (#519137, #520058).
by Chris Lumens 28 Aug '09

28 Aug '09

This is a particular problem on text kickstart installs, where there is no partitioning UI to go back to. Everywhere else in the partitioning code, we just tell the user that it's going to reboot instead of offering some choice. So, do the same thing in this case. --- storage/partitioning.py | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/storage/partitioning.py b/storage/partitioning.py index e44d7f4..4094431 100644 --- a/storage/partitioning.py +++ b/storage/partitioning.py @@ -176,11 +176,19 @@ def doAutoPartition(anaconda): (disks, devs) = _createFreeSpacePartitions(anaconda) if disks == []: - anaconda.intf.messageWindow(_("Error Partitioning"), - _("Could not find enough free space " - "for automatic partitioning, please " - "use another partitioning method."), + if anaconda.isKickstart: + msg = _("Could not find enough free space for automatic " + "partitioning. Press 'OK' to exit the installer.") + else: + msg = _("Could not find enough free space for automatic " + "partitioning, please use another partitioning method.") + + anaconda.intf.messageWindow(_("Error Partitioning"), msg, custom_icon='error') + + if anaconda.isKickstart: + sys.exit(0) + anaconda.id.storage.reset() return DISPATCH_BACK -- 1.6.4

2 1

Multiple issues with commit_to_os (Linux)
by Hans de Goede 28 Aug '09

28 Aug '09

Hi All, Short intro: I'm an anaconda (The Fedora installer) developer, and anaconda uses parted for its partitioning. While testing partitionable mdraid I noticed that the kernels view of the partition table never changes even though I was successfully making commit_to_os() calls. This has let to me diving into libparted's commit_to_os() code for Linux and there are multiple issues hiding in there: 1) Parted reads /sys/block/foo/range to determine how many partitions the device type supports and then makes BLKPG ioctl's to update the kernels view of the partition table for partitions which fall into this range. However for example /sys/block/sda/range contains 16, there are 2 issue with libparted using this number: 1) scsi major's only support 15 partitions, 1 of the range of 16 is reserved for the whole device, yet libparted will try to notify the kernel about 16 partitions if present 2) If the major's partition minor's run out, the kernel will switch to the mdp major for the other partitions, iow range no longer limits the number of partitions. 2) libparted assumes the user knows what he is doing, and will ignore -ebusy errors for partitions, assuming that the user is smart enough to only change unused partitions. Parted does this without checking if the partitions which return ebusy actually are unchanged causing REAL errors to get unreported (BAD, really really BAD) 3) because of 1) libparted will only sync 1 partition on /dev/md# devices (would be 0 if not for the of by 1 bug as all md#p# partitions use the mdp major), and it fails to even do that without reporting an error. ### 1) we can fix by simply not checking /sys/block/foo/range, but instead just syncing max partitions. 2) is more troublesome, we could just make -EBUSY n error, but that may annoy / bug some users. OTOH in certain cases libparted already falls back to BLKRRPART which will return EBUSY so users should already be prepared to handle EBUSY 3) Could be fixed by making libparted recognize mdraid as a device type and except mdraid from using BLKPG, like it already is doing with DASD, but it might be better to just get rid of using BLKPG al together. See below. An even bigger problem IMHO is the use of the BLKPG ioctl instead of BLKRRPART at all. What this does is tell the kernel parted's view of the partition table and make it use that, instead of telling the kernel to reread the partition table. According to the parted sources this is done for the case where the kernel does not know the disklabel type. However as soon as the system is rebooted, the system will be using the kernel's view. So IMHO it would be much better to always use the kernels view and just always call BLKRRPART in commit_to_os(), this would solve all of the above issues, *and* make the way the system views the partition table consistent between just after running parted and after a reboot. I've attached a patch which removes the use of the BLKPG ioctl, notice that this also removes a lot of special case code and workarounds, which existence to me clearly indicates that using the BLKPG ioctl is a bad idea. Regards, Hans

2 1

Anaconda 12.17
by Clyde E. Kunkel 28 Aug '09

28 Aug '09

Nice job anaconda team. Best version yet since storage rewrite, smooth and seems faster and has proper focus'. Handles prexisiting lv over raid 10 (not bios configured tho) nicely. I also tried going back several times in the custom config screens without any problems.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel August 2009