Anaconda-devel September 2009

anaconda-devel@lists.stg.fedoraproject.org

29 participants
101 discussions

Start a nNew thread

repo editing patches
by Radek Vykydal 06 Oct '09

06 Oct '09

This is patch 5/6 from my first repo editing patches set split into smaller bits.

3 43

[PATCH] (master) UI rewrite
by Joel Granados Moreno 05 Oct '09

05 Oct '09

Hello list. Sorry for the very very very very long patch set. :) IMO each patch is pretty well commented and speaks for itself. I tried to separate the patches as much as I could. I would like to comment on the method I used to find out if there was space left in the system partitions. I basically wanted to know if there was some space in the partition after allocation but before growing. I'm not to proud of the way it is done but it gets the job done. With that said, I would be ok with NOT including the related patches and assuming we have free space in the partitions. In the case we would error out after the user tries to create a partition. Moreover, I think we should make the autopartitioning optional. Right now we are reorganizing everything every time the user does something. IMO, it would be much better to give the user a little bit more of responsibility and let him/her be more specific as to the size and location of the partitions. But thats a battle for another time, I guess. I have been testing this against master and there are still 2 issues that are left to be addressed. IMO, these are minor issues that will probably get ironed out soonish. 1. The direct "create LV" does not work yet. One has to go through the VG screen 2. After an action the bar view gets erased and is blank until one clicks as device. As suggested by clumens, I'll make some videos about the enhancements that were created and post them shortly. Regards. Joel Andres Granados Brno, Czech Republic, Red Hat.

7 106

master branch, UI rewrite.
by Joel Granados 01 Oct '09

01 Oct '09

Hello list. I have created a new patch set that includes all the comments that were discussed in the previous UI rewrite thread. I would like to avoid posting all the patches once more to the list. With this in mind I have put them in http://jgranado.fedorapeople.org/anaconda/ui/patchset-20090930/ Most of them are the same patches but with very small changes added to them (mostly changes that were suggested). I squashed some patches together (as suggested) and added some additional stuff that was missing from my previous set. In general, patches 0026-* to 0032* are new. I also added 3 new videos showing the relevant features: http://jgranado.fedorapeople.org/anaconda/ui/videos/lv_create_workflow http://jgranado.fedorapeople.org/anaconda/ui/videos/edit_delete_buttons http://jgranado.fedorapeople.org/anaconda/ui/videos/message_in_canvas Things to highlight. 1. I removed the patch that made the grow part in doPartitioning optional. I instead created a patch that adds a function that is not implemented yet, but is there so we don't forget. 2. I removed the "Hide" thingy. 3. Created the 'create lv' button. With this new button one can create an LV from the VG screen or from the 'create' screen. 4. Modified the 'edit' and 'delete' buttons to activate only when they are relevant. 5. There is now a message that reads 'Please Select A Device' when no devices are selected. Further review is greatly appreciated. Regards. -- Joel Andres Granados Brno, Czech Republic, Red Hat.

2 5

[PATCH] Don't retry commiting partition table to disk
by Hans de Goede 01 Oct '09

01 Oct '09

Since the parted ebusy errors due to unnecessary udev event generation on the partition nodes bug has been nailed, we no longer need the retry loop around committing to disk. --- storage/formats/disklabel.py | 23 ++++++----------------- 1 files changed, 6 insertions(+), 17 deletions(-) diff --git a/storage/formats/disklabel.py b/storage/formats/disklabel.py index a387c56..192f1da 100644 --- a/storage/formats/disklabel.py +++ b/storage/formats/disklabel.py @@ -197,23 +197,12 @@ class DiskLabel(DeviceFormat): def commit(self): """ Commit the current partition table to disk and notify the OS. """ - # give committing 5 tries, failing that, raise an exception - attempt = 1 - maxTries = 5 - keepTrying = True - - while keepTrying and (attempt <= maxTries): - try: - self.partedDisk.commit() - keepTrying = False - except parted.DiskException as msg: - log.warning(msg) - attempt += 1 - else: - udev_settle() - - if keepTrying: - raise DeviceFormatError("cannot commit to disk after %d attempts" % (maxTries,), ) + try: + self.partedDisk.commit() + except parted.DiskException as msg: + raise DeviceFormatError(msg) + else: + udev_settle() def commitToDisk(self): """ Commit the current partition table to disk. """ -- 1.6.4.2

3 3

[PATCH] Stop /lib/udev/rules.d/65-md-incremental.rules from messing with mdraid sets
by Hans de Goede 30 Sep '09

30 Sep '09

Touch /dev/.in_sysinit, as that stops /lib/udev/rules.d/65-md-incremental.rules from messing with mdraid sets. This patch adds the touching twice, once to our own init, for when running as standalone installer, and once in python for when running from a livecd, to stop the udev trigger "block" we do will cause /lib/udev/rules.d/65-md-incremental.rules to trigger in the livecd case. --- loader/init.c | 5 +++++ storage/__init__.py | 4 ++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/loader/init.c b/loader/init.c index 627428e..d941f86 100644 --- a/loader/init.c +++ b/loader/init.c @@ -386,6 +386,11 @@ static void createDevices(void) { fprintf(stderr, "Unable to create device %s: %m\n", devname); } + /* Hurray for hacks, this stops /lib/udev/rules.d/65-md-incremental.rules + from medling with mdraid sets. */ + i = creat("/dev/.in_sysinit", 0644); + close(i); + /* Restore umask for minimal side affects */ umask(previous_umask); } diff --git a/storage/__init__.py b/storage/__init__.py index 376eda2..62f0021 100644 --- a/storage/__init__.py +++ b/storage/__init__.py @@ -65,6 +65,10 @@ def storageInitialize(anaconda): if anaconda.dir == DISPATCH_BACK: return + # touch /dev/.in_sysinit so that /lib/udev/rules.d/65-md-incremental.rules + # does not mess with any mdraid sets + open("/dev/.in_sysinit", "w") + # XXX I don't understand why I have to do this udev_trigger(subsystem="block") -- 1.6.4.2

4 5

[PATCH] partition renumbering workarounds for rawhide
by David Lehman 30 Sep '09

30 Sep '09

This is a series of patches to address parted's renumbering of partitions. They should resolve several bugs, including those resulting in a "duplicate paths in device tree" exception. I have tested them with extended/logical partitions, lvm, md, lvm-on-md. There are surely some cases I missed but they have been tested beyond the basics.

2 7

[PATCH] Wait for mdraid arrays to become clean before reboot / halt
by Hans de Goede 30 Sep '09

30 Sep '09

With the new external metadata mdraid support we need to wait for raid sets to become clean (iow for mdmon to have finished updating the metadata) before rebooting. Otherwise we get a full array sync on the first boot after installation. --- loader/shutdown.c | 5 +++++ scripts/mk-images | 4 ++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/loader/shutdown.c b/loader/shutdown.c index 6ae4048..6a32e79 100644 --- a/loader/shutdown.c +++ b/loader/shutdown.c @@ -58,6 +58,8 @@ static void performTerminations(int doKill) { } static void performUnmounts(int doKill) { + int ignore; + if (testing || !doKill) return; @@ -66,6 +68,9 @@ static void performUnmounts(int doKill) { printf("unmounting filesystems...\n"); unmountFilesystems(); + + printf("waiting for mdraid sets to become clean...\n"); + ignore = system("/sbin/mdadm --wait-clean --scan"); } static void performReboot(reboot_action rebootAction) { diff --git a/scripts/mk-images b/scripts/mk-images index 00854d3..cfe62d3 100755 --- a/scripts/mk-images +++ b/scripts/mk-images @@ -759,6 +759,10 @@ makeinitrd() { cp -a org.freedesktop.nm_dispatcher.service $MBD_DIR/usr/share/dbus-1/system-services ) + # mdadm + instbin $IMGPATH /usr/sbin/mdadm $MBD_DIR /sbin/mdadm + instbin $IMGPATH /usr/sbin/mdmon $MBD_DIR /sbin/mdmon + # Misc instbin $IMGPATH /usr/sbin/dmidecode $MBD_DIR /sbin/dmidecode instbin $IMGPATH /usr/bin/egrep $MBD_DIR /sbin/egrep -- 1.6.4.2

3 5

[PATCH] Don't try to do format handling on drives without media (#523467)
by Hans de Goede 30 Sep '09

30 Sep '09

--- storage/devicetree.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/storage/devicetree.py b/storage/devicetree.py index 155b1c9..fe3ab0c 100644 --- a/storage/devicetree.py +++ b/storage/devicetree.py @@ -1272,6 +1272,10 @@ class DeviceTree(object): if device and device.name in self.protectedDevNames: device.protected = True + # Don't try to do format handling on drives without media + if device and not device.mediaPresent: + return + # Now, if the device is a disk, see if there is a usable disklabel. # If not, see if the user would like to create one. # XXX this is the bit that forces disklabels on disks. Lame. -- 1.6.4.2

2 1

[PATCH] UI tweaks for LVM/RAID
by David Lehman 30 Sep '09

30 Sep '09

A couple of little fixes for the UI that will be obsoleted when the UI rewrite lands. They'll improve F12, though.

3 5

[PATCH] Don't check if /boot is under the 4MB mark on i/p Series (#526200).
by Chris Lumens 30 Sep '09

30 Sep '09

--- platform.py | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/platform.py b/platform.py index 37b3796..38a7185 100644 --- a/platform.py +++ b/platform.py @@ -330,12 +330,13 @@ class IPSeriesPPC(PPC): if not bootPart: return errors - if bootPart.geometry.end * bootPart.geometry.device.sectorSize / (1024.0 * 1024) > 4096: - errors.append(_("The boot partition must be within the first 4MB of the disk.")) - # All of the above just checks the PPC PReP boot partitions. We still # need to make sure that whatever /boot is on also meets these criteria. if req == self.bootDevice(): + # However, this check only applies to prepboot. + if bootPart.geometry.end * bootPart.geometry.device.sectorSize / (1024.0 * 1024) > 4096: + errors.append(_("The boot partition must be within the first 4MB of the disk.")) + try: req = self.anaconda.id.storage.mountpoints["/boot"] except KeyError: -- 1.6.4.2

3 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel September 2009