Anaconda-devel February 2010

anaconda-devel@lists.stg.fedoraproject.org

23 participants
128 discussions

[PATCH] Check for the real device-mapper nodes in /proc/swaps. (#567840)
by David Lehman 11 May '10

11 May '10

--- storage/devicelibs/swap.py | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/storage/devicelibs/swap.py b/storage/devicelibs/swap.py index d037d80..02a07d4 100644 --- a/storage/devicelibs/swap.py +++ b/storage/devicelibs/swap.py @@ -26,6 +26,7 @@ import iutil import os from ..errors import * +from . import dm import gettext _ = lambda x: gettext.ldgettext("anaconda", x) @@ -100,13 +101,20 @@ def swapoff(device): raise SwapError("swapoff failed for '%s'" % device) def swapstatus(device): + alt_dev = device + if device.startswith("/dev/mapper/"): + # get the real device node for device-mapper devices since the ones + # with meaningful names are just symlinks + alt_dev = "/dev/%s" % dm.dm_node_from_name(device.split("/")[-1]) + lines = open("/proc/swaps").readlines() status = False for line in lines: if not line.strip(): continue - - if line.split()[0] == device: + + swap_dev = line.split()[0] + if swap_dev in [device, alt_dev]: status = True break -- 1.6.6

3 4

[PATCH] - change our default partitioning scheme
by Chris Lumens 30 Apr '10

30 Apr '10

Here's a patch series that ends up with creating a /home by default. The algorithm is basically: - VG < 50 GB: make /boot, swap, rest as / - VG >= 50 GB: make /boot, swap, / with a 50 GB max, rest as /home Let the arguing begin. - Chris

11 26

signalling problems during X/wm startup
by Ales Kozumplik 29 Mar '10

29 Mar '10

Hi, Rawhide (and possibly other versions too) anaconda has race conditions when starting X. We fire up X.org binary and go into signal.pause(), waiting for either SIGUSR1 from X when it is started or SIGCHLD if it terminated with an error. The problem is: before this branch of code even begins anaconda has forked() itself and me might see many more SIGCHLD signals coming from these non-X processes. If that happens, the code responsible for starting X assumes X has failed (though it has not) and switches for text install. There's many more similar scenarios depending on when exactly is SIGCHLD delivered. For instance if SIGUSR arrives and resumes the signal.pause and then immediately SIGCHLD arrives, it messes up startup of the window manager that was going on after startup of X. Typically it hits the os.read() bit when main anaconda is watching the pipe with mini-wm. This raises an WhateverSystemCallInterrupted exception and kills anaconda. But there are endlessly more possibilities, the beauty of concurrency lies in its lack of determinism. Nonetheless, I seem to be the only one person running into this, maybe it's because I test on a specific vmware server that gives me a unique timing to trigger these problems. I am attaching a fix which specifically forks the offending children into orphans. If similar bugs start showing up more often we will perhaps need to change the X startup mechanism (I am not sure how though). Ales

2 3

nm-c-e integration take II - now with metacity!
by Radek Vykydal 18 Mar '10

18 Mar '10

Patches are for master, 13.27 Patches [1/7] [2/7] [3/7] integrate nm-connection-editor into stage2 an UI. [4/7], [5/7], [6/7] are Ales's patches including metacity taken from devel-list and applied to master (I need to do testing composes there) and my patches. (Sorry for the wrong Author:ship that happen in my merge) [7/7] Solves most of gconf issues in Fedora, but our modification of metacity scheme via gconf has still to be worked out. Here are images to taste - http://rvykydal.fedorapeople.org/nm-c-e/ if you play with them you can see some issues: * nm-c-e window is added as blocking which in combination with metacity enabling moving of blocking windows (e.g. device discovery) reveals that we are running in single thread - background anaconda window is not repainted. I'd use some simpler non-movable widget for waiting windows, but for nm-c-e we'll probably need to run it non-blocking from anaconda * Also focus issues are apparent with nm-connection-editor when you click on anaconda window (similar to what Martin Gracik was solving for firstboot I think). Radek

3 11

[PATCH] clean up sparc boot loader so that it writes out and links into /etc correctly
by Dennis Gilmore 01 Mar '10

01 Mar '10

--- booty/sparc.py | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/booty/sparc.py b/booty/sparc.py index 22c4ab8..c6db493 100644 --- a/booty/sparc.py +++ b/booty/sparc.py @@ -1,7 +1,10 @@ +import string import os from booty import BootyNoKernelWarning +from util import getDiskPart from bootloaderInfo import * +import iutil class sparcBootloaderInfo(bootloaderInfo): def writeSilo(self, instRoot, bl, kernelList, @@ -35,7 +38,7 @@ class sparcBootloaderInfo(bootloaderInfo): f.write("message=%s\n" % (mf,)) f.write("timeout=%s\n" % (self.timeout or 50)) - (name, partNum) = getDiskPart(bootDev, self.storage) + (name, partNum) = getDiskPart(bootDev.name, self.storage) partno = partNum + 1 f.write("partition=%s\n" % (partno,)) @@ -86,9 +89,7 @@ class sparcBootloaderInfo(bootloaderInfo): backup = "%s/backup.b" % (cfPath,) sbinargs = ["/sbin/silo", "-f", "-C", cf, "-S", backup] - # TODO!!! FIXME!!! XXX!!! - # butil is not defined!!! - assume this is in rhpl now? - if butil.getSparcMachine() == "sun4u": + if (iutil.getSparcMachine() == "sun4u" or iutil.getSparcMachine() == "sun4v"): sbinargs += ["-u"] else: sbinargs += ["-U"] @@ -103,8 +104,8 @@ class sparcBootloaderInfo(bootloaderInfo): return rc if (not os.access(instRoot + "/etc/silo.conf", os.R_OK) and - os.access(instRoot + "/boot/etc/silo.conf", os.R_OK)): - os.symlink("../boot/etc/silo.conf", + os.access(instRoot + "/boot/silo.conf", os.R_OK)): + os.symlink("../boot/silo.conf", instRoot + "/etc/silo.conf") return 0 -- 1.7.0

2 2

[PATCH 1/8] we make a install.img file not a stage2.img make sure boot.iso is passed the right image to get an iso out
by Dennis Gilmore 01 Mar '10

01 Mar '10

--- scripts/mk-images.sparc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/mk-images.sparc b/scripts/mk-images.sparc index 9525f59..f8fb3b6 100644 --- a/scripts/mk-images.sparc +++ b/scripts/mk-images.sparc @@ -167,6 +167,7 @@ doPostImages() { -x repodata \ -sparc-label "$PRODUCT $VERSION Boot Disc" \ -o $TOPDESTPATH/images/$BOOTISO -graft-points \ - boot=$TOPDESTPATH/boot images/stage2.img=$TOPDESTPATH/images/stage2.img + boot=$TOPDESTPATH/boot images/install.img=$TOPDESTPATH/images/install.img + implantisomd5 $TOPDESTPATH/images/$BOOTISO fi } -- 1.7.0

2 2

[PATCH] On live installs, the syslog is /var/log/dmesg. (#568814).
by Chris Lumens 26 Feb '10

26 Feb '10

This is because we use the system syslog on live installs instead of starting our own with its own special file locations. --- exception.py | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/exception.py b/exception.py index 7e27945..1075717 100644 --- a/exception.py +++ b/exception.py @@ -90,6 +90,15 @@ class AnacondaExceptionHandler(ExceptionHandler): os.kill(os.getpid(), signal.SIGKILL) def initExceptionHandling(anaconda): + fileList = [ "/tmp/anaconda.log", "/tmp/lvmout", "/tmp/resize.out", + "/tmp/program.log", "/tmp/storage.log", "/tmp/yum.log", + anaconda.rootPath + "/root/install.log", + anaconda.rootPath + "/root/upgrade.log", "/proc/cmdline" ] + if flags.livecdInstall: + fileList.extend(["/var/log/dmesg"]) + else: + fileList.extend(["/tmp/syslog"]) + conf = Config(programName="anaconda", programVersion=isys.getAnacondaVersion(), attrSkipList=[ "backend.ayum", @@ -116,12 +125,7 @@ def initExceptionHandling(anaconda): "intf.icw.stockButtons", ], localSkipList=[ "passphrase", "password" ], - fileList=[ "/tmp/syslog", "/tmp/anaconda.log", "/tmp/lvmout", - "/tmp/resize.out", "/tmp/program.log", - "/tmp/storage.log", "/tmp/yum.log", - anaconda.rootPath + "/root/install.log", - anaconda.rootPath + "/root/upgrade.log", - "/proc/cmdline"]) + fileList=fileList) handler = AnacondaExceptionHandler(conf, anaconda.intf, ReverseExceptionDump) handler.install(anaconda) -- 1.6.5.1

3 2

[PATCH 8/8] use isSparc not isSPARC
by Dennis Gilmore 26 Feb '10

26 Feb '10

--- iutil.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/iutil.py b/iutil.py index e275130..e1cde5e 100644 --- a/iutil.py +++ b/iutil.py @@ -499,7 +499,7 @@ def copyDeviceNode(src, dest): ## Get the SPARC machine variety type. # @return The SPARC machine type, or 0 if not SPARC. def getSparcMachine(): - if not isSPARC(): + if not isSparc(): return 0 machine = None -- 1.7.0

1 0

[PATCH 7/8] include silo on sparc
by Dennis Gilmore 26 Feb '10

26 Feb '10

--- platform.py | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/platform.py b/platform.py index 1a9ee96..6076ac5 100644 --- a/platform.py +++ b/platform.py @@ -477,6 +477,7 @@ class S390(Platform): class Sparc(Platform): _diskLabelType = "sun" + _packages = ["silo"] @property def minimumSector(self, disk): -- 1.7.0

1 0

[PATCH 6/8] make sure sparc64 has lib64 paths set
by Dennis Gilmore 26 Feb '10

26 Feb '10

--- loader/init.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/loader/init.c b/loader/init.c index ec4ce73..5aec2a3 100644 --- a/loader/init.c +++ b/loader/init.c @@ -87,7 +87,7 @@ char * env[] = { /* we set a nicer ld library path specifically for bash -- a full one makes anaconda unhappy */ -#if defined(__x86_64__) || defined(__s390x__) || defined(__powerpc64__) +#if defined(__x86_64__) || defined(__s390x__) || defined(__powerpc64__) || (defined(__sparc__) && defined(__arch64__)) "LD_LIBRARY_PATH=/lib64:/usr/lib64:/lib:/usr/lib", #else "LD_LIBRARY_PATH=/lib:/usr/lib", -- 1.7.0

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel February 2010