Anaconda-devel March 2010

anaconda-devel@lists.stg.fedoraproject.org

29 participants
140 discussions

[PATCH] Fix recognition of partitions on mdraid arrays (#569462)
by Hans de Goede 03 Mar '10

03 Mar '10

Currently anaconda mis-identifies partitions on mdraid arrays as being mdraid arrays themselves, causing a backtrace. This patch fixes this. --- storage/udev.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/storage/udev.py b/storage/udev.py index 02a54e7..5faafa3 100644 --- a/storage/udev.py +++ b/storage/udev.py @@ -151,6 +151,9 @@ def udev_device_is_dm(info): def udev_device_is_md(info): """ Return True if the device is a mdraid array device. """ + # Don't identify partitions on mdraid arrays as raid arrays + if udev_device_is_partition(info): + return False # isw raid set *members* have MD_METADATA set, but are not arrays! return info.has_key("MD_METADATA") and \ info.get("ID_FS_TYPE") != "isw_raid_member" -- 1.7.0

2 1

nm-c-e integration take II - now with metacity!
by Radek Vykydal 03 Mar '10

03 Mar '10

Patches are for master, 13.27 Patches [1/7] [2/7] [3/7] integrate nm-connection-editor into stage2 an UI. [4/7], [5/7], [6/7] are Ales's patches including metacity taken from devel-list and applied to master (I need to do testing composes there) and my patches. (Sorry for the wrong Author:ship that happen in my merge) [7/7] Solves most of gconf issues in Fedora, but our modification of metacity scheme via gconf has still to be worked out. Here are images to taste - http://rvykydal.fedorapeople.org/nm-c-e/ if you play with them you can see some issues: * nm-c-e window is added as blocking which in combination with metacity enabling moving of blocking windows (e.g. device discovery) reveals that we are running in single thread - background anaconda window is not repainted. I'd use some simpler non-movable widget for waiting windows, but for nm-c-e we'll probably need to run it non-blocking from anaconda * Also focus issues are apparent with nm-connection-editor when you click on anaconda window (similar to what Martin Gracik was solving for firstboot I think). Radek

2 3

loader ks=bd:... and kickstart driverdisk/harddisk --biospart support
by Hans de Goede 03 Mar '10

03 Mar '10

Hi, As discussed some time ago, while replacing the isys.c edd parsing code with python code, I found out the C code had to stick around as loader needs it. Since the C code has a few limitations, I filed a bug to asking for these limitations to be documented: http://bugzilla.redhat.com/show_bug.cgi?id=558775 R. Landmann, our doc writer then asked for more information on these options as currently they are not documented at all. So I looked at them again, and ks=bd:.... seems to be supported in loader, and loader also knows about the following kickstart directives: harddisk --biospart driverdisk --biospart But pykickstart does not know about the harddisk directive at all, and also does not know about driverdisk's --biospart option. So does this mean that these options simply don't work (and can be removed or should be fixed) ? Or does this mean that pykickstart complains but does not error out on the unknown harddisk command / driverdisk option, or ... ? Regards, Hans

2 1

[PATCH] anaconda: Allow 'sshd' on the kernel command line.
by Adam Jackson 03 Mar '10

03 Mar '10

Previously, we would only start sshd if you'd passed --kickstart to anaconda. Note that, in the absence of a kickstart file specifying users, this will start sshd with no password for root. Treat this like you would treat 'vnc' with no 'vncpasswd'. Signed-off-by: Adam Jackson <ajax(a)redhat.com> --- anaconda | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/anaconda b/anaconda index 7bac8ce..cca1ee5 100755 --- a/anaconda +++ b/anaconda @@ -373,6 +373,9 @@ def setupGraphicalLinks(): pass def handleSshPw(anaconda): + if not anaconda.ksdata: + return + import users u = users.Users(anaconda) @@ -398,8 +401,6 @@ def createSshKey(algorithm, keyfile): iutil.execWithRedirect('ssh-keygen', argv, stdout=so, stderr=se) def startSsh(): - if not flags.sshd: - return if iutil.isS390(): return @@ -953,6 +954,7 @@ if __name__ == "__main__": anaconda.ksdata = kickstart.parseKickstart(anaconda, opts.ksfile) opts.rescue = anaconda.ksdata.rescue.rescue + if flags.sshd: # we need to have a libuser.conf that points to the installer root for # sshpw, but after that we start sshd, we need one that points to the # install target. -- 1.6.5.2

2 1

[PATCH] dcbd is being replaced with lldpad (#563790)
by Hans de Goede 02 Mar '10

02 Mar '10

--- scripts/upd-instroot | 8 ++++---- storage/fcoe.py | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/upd-instroot b/scripts/upd-instroot index 584240e..dae3b12 100755 --- a/scripts/upd-instroot +++ b/scripts/upd-instroot @@ -160,7 +160,7 @@ PACKAGES="GConf2 NetworkManager ORBit2 acl anaconda btrfs-progs bzip2 bzip2-libs ca-certificates cairo cjkuni-uming-fonts comps-extras coreutils cpio cracklib cracklib-dicts cracklib-python cryptsetup-luks cyrus-sasl-lib db4 dbus dbus-python dejavu-sans-fonts - dcbd dejavu-sans-mono-fonts device-mapper device-mapper-libs + dejavu-sans-mono-fonts device-mapper device-mapper-libs device-mapper-multipath device-mapper-multipath-libs dhclient dmraid dmraid-libs dogtail dosfstools e2fsprogs e2fsprogs-libs echo-icon-theme ethtool @@ -177,7 +177,7 @@ PACKAGES="GConf2 NetworkManager ORBit2 acl anaconda libglade2 libgnomecanvas libgcrypt libgpg-error libjpeg libnl libpng libselinux libselinux-python libsemanage libsemanage-python libsepol libssh2 libstdc++ libthai libtirpc libuser - libuser-python libvolume_id libxcb libxkbfile libxml2 lklug-fonts + libuser-python libvolume_id libxcb libxkbfile libxml2 lklug-fonts lldpad lohit-assamese-fonts lohit-bengali-fonts lohit-gujarati-fonts lohit-hindi-fonts lohit-kashmiri-fonts lohit-kannada-fonts lohit-maithili-fonts lohit-marathi-fonts lohit-oriya-fonts lohit-punjabi-fonts lohit-sindhi-fonts lohit-tamil-fonts @@ -356,7 +356,6 @@ etc/NetworkManager/nm-system-settings.conf etc/NetworkManager/dispatcher.d etc/dbus-1/* etc/dbus-1/system.d/* -etc/dcbd etc/fb.modes etc/fcoe etc/fonts @@ -588,7 +587,6 @@ usr/sbin/NetworkManager usr/sbin/addRamDisk usr/sbin/anaconda usr/sbin/chroot -usr/sbin/dcbd usr/sbin/dcbtool usr/sbin/ddcprobe usr/sbin/dmidecode @@ -597,6 +595,7 @@ usr/sbin/fcoemon usr/sbin/fbset usr/sbin/genhomedircon usr/sbin/gptsync +usr/sbin/lldpad usr/sbin/lvm usr/sbin/prelink usr/sbin/semodule @@ -678,6 +677,7 @@ usr/share/zenity usr/share/zoneinfo var/lib/polkit-1 var/lib/dbus +var/lib/lldpad var/run/dbus EOF diff --git a/storage/fcoe.py b/storage/fcoe.py index fb42be7..cffc9e2 100644 --- a/storage/fcoe.py +++ b/storage/fcoe.py @@ -53,7 +53,7 @@ class fcoe(object): def __init__(self): self.started = False - self.dcbdStarted = False + self.lldpadStarted = False self.fcoemonStarted = False self.nics = [] @@ -86,14 +86,14 @@ class fcoe(object): self.started = True - def _startDcbd(self): - if self.dcbdStarted: + def _startLldpad(self): + if self.lldpadStarted: return - iutil.execWithRedirect("dcbd", [ "-d" ], + iutil.execWithRedirect("lldpad", [ "-d" ], stdout = "/dev/tty5", stderr="/dev/tty5", searchPath = 1) - self.dcbdStarted = True + self.lldpadStarted = True def _startFcoemon(self): if self.fcoemonStarted: @@ -115,7 +115,7 @@ class fcoe(object): searchPath = 1) if dcb: - self._startDcbd() + self._startLldpad() iutil.execWithRedirect("dcbtool", [ "sc", nic, "dcb", "on" ], stdout = "/dev/tty5", stderr="/dev/tty5", searchPath = 1) -- 1.7.0

2 1

[PATCH] Use new package structure of firstaidkit (#510346)
by Martin Sivak 02 Mar '10

02 Mar '10

--- scripts/upd-instroot | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/upd-instroot b/scripts/upd-instroot index 217f997..8250ea1 100755 --- a/scripts/upd-instroot +++ b/scripts/upd-instroot @@ -244,8 +244,10 @@ PACKAGESRESCUE="bzip2 bzip2-libs dump modutils mtools mt-st mtr net-tools smartmontools openssh openssh-clients pciutils rsh traceroute tar rsync device-mapper device-mapper-libs dmraid ntfsprogs samba-client - firstaidkit firstaidkit-plugin-passwd firstaidkit-plugin-xserver - firstaidkit-gui firstaidkit-plugin-mdadm-conf firstaidkit-plugin-key-recovery volume_key" + firstaidkit firstaidkit-engine firstaidkit-plugin-passwd + firstaidkit-plugin-xserver firstaidkit-gui + firstaidkit-plugin-mdadm-conf firstaidkit-plugin-key-recovery + volume_key" if [[ $ARCH =~ "i[356]86" || $ARCH == "x86_64" ]]; then PACKAGESRESCUE="$PACKAGESRESCUE gpart grub firstaidkit-plugin-grub" -- 1.6.6

2 1

[rhel5-branch 1/2] PACKAGE_VERSION is an obsolete macro in later rpmbuilds.
by Ales Kozumplik 01 Mar '10

01 Mar '10

changed the spec to use %{Version} that works in rhel5 as well as in later fedoras. --- anaconda.spec | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/anaconda.spec b/anaconda.spec index 3c3d297..b8c7aee 100644 --- a/anaconda.spec +++ b/anaconda.spec @@ -4,7 +4,7 @@ Release: 4 License: GPL Summary: Graphical system installer Group: Applications/System -Source: anaconda-%{PACKAGE_VERSION}.tar.bz2 +Source: anaconda-%{Version}.tar.bz2 BuildPreReq: kudzu-devel >= 1.2.57.1.18, pciutils-devel BuildPreReq: bzip2-devel, e2fsprogs-devel, python-devel, gtk2-devel BuildPreReq: rpm-python >= 4.2-0.61, newt-devel, rpm-devel, gettext >= 0.11 -- 1.6.6

2 2

[PATCH] clean up sparc boot loader so that it writes out and links into /etc correctly
by Dennis Gilmore 01 Mar '10

01 Mar '10

--- booty/sparc.py | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/booty/sparc.py b/booty/sparc.py index 22c4ab8..c6db493 100644 --- a/booty/sparc.py +++ b/booty/sparc.py @@ -1,7 +1,10 @@ +import string import os from booty import BootyNoKernelWarning +from util import getDiskPart from bootloaderInfo import * +import iutil class sparcBootloaderInfo(bootloaderInfo): def writeSilo(self, instRoot, bl, kernelList, @@ -35,7 +38,7 @@ class sparcBootloaderInfo(bootloaderInfo): f.write("message=%s\n" % (mf,)) f.write("timeout=%s\n" % (self.timeout or 50)) - (name, partNum) = getDiskPart(bootDev, self.storage) + (name, partNum) = getDiskPart(bootDev.name, self.storage) partno = partNum + 1 f.write("partition=%s\n" % (partno,)) @@ -86,9 +89,7 @@ class sparcBootloaderInfo(bootloaderInfo): backup = "%s/backup.b" % (cfPath,) sbinargs = ["/sbin/silo", "-f", "-C", cf, "-S", backup] - # TODO!!! FIXME!!! XXX!!! - # butil is not defined!!! - assume this is in rhpl now? - if butil.getSparcMachine() == "sun4u": + if (iutil.getSparcMachine() == "sun4u" or iutil.getSparcMachine() == "sun4v"): sbinargs += ["-u"] else: sbinargs += ["-U"] @@ -103,8 +104,8 @@ class sparcBootloaderInfo(bootloaderInfo): return rc if (not os.access(instRoot + "/etc/silo.conf", os.R_OK) and - os.access(instRoot + "/boot/etc/silo.conf", os.R_OK)): - os.symlink("../boot/etc/silo.conf", + os.access(instRoot + "/boot/silo.conf", os.R_OK)): + os.symlink("../boot/silo.conf", instRoot + "/etc/silo.conf") return 0 -- 1.7.0

2 2

[PATCH 1/8] we make a install.img file not a stage2.img make sure boot.iso is passed the right image to get an iso out
by Dennis Gilmore 01 Mar '10

01 Mar '10

--- scripts/mk-images.sparc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/mk-images.sparc b/scripts/mk-images.sparc index 9525f59..f8fb3b6 100644 --- a/scripts/mk-images.sparc +++ b/scripts/mk-images.sparc @@ -167,6 +167,7 @@ doPostImages() { -x repodata \ -sparc-label "$PRODUCT $VERSION Boot Disc" \ -o $TOPDESTPATH/images/$BOOTISO -graft-points \ - boot=$TOPDESTPATH/boot images/stage2.img=$TOPDESTPATH/images/stage2.img + boot=$TOPDESTPATH/boot images/install.img=$TOPDESTPATH/images/install.img + implantisomd5 $TOPDESTPATH/images/$BOOTISO fi } -- 1.7.0

2 2

remote logging script
by Ales Kozumplik 01 Mar '10

01 Mar '10

Hi, As I am writing on the wiki page here https://fedoraproject.org/wiki/Anaconda/Logging#Remote_logging it is possible to get all of the stuff anaconda logs(except a couple corner cases like isys and external logfiles like Xorg log) over a network. The downside is that anyone who would like to sensibly use this needs to configure and start an rsyslog daemon. That includes copy-pasting and editing the not so short (and possibly changing in the future) config file from the wiki page. That's why I decided to provide a small script that generates the file automatically and fires up the daemon on a given TCP port. For now, I put it in scripts/analog in anaconda source and after installation of the anaconda rpm it will reside in /usr/bin/analog. It's possible to call it from either location, it has no extra modules. To start it, cd into an empty directory where you wish to have your log file structure and then do $ analog start -p 1234 log to start a syslog daemon on port 1234 and store the logs under log/ (assuming you do an installation with --syslog=your.ip:1234). It's possible to start several daemons too. Let me know if you dislike having such script as a part of anaconda, or having to install anaconda.rpm to get it or if you think this is something we shouldn't even provide. Ales

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel March 2010