Anaconda-devel September 2010

anaconda-devel@lists.stg.fedoraproject.org

20 participants
45 discussions

[master] Repository setup and UI patches.
by Radek Vykydal 16 Nov '10

16 Nov '10

data/ui/addrepo.glade | 1 + pyanaconda/__init__.py | 3 +- pyanaconda/backend.py | 9 +- pyanaconda/dispatch.py | 5 +- pyanaconda/gui.py | 2 +- pyanaconda/image.py | 45 -- pyanaconda/installclass.py | 5 +- pyanaconda/iutil.py | 13 + pyanaconda/iw/task_gui.py | 624 ++++++++--------------- pyanaconda/kickstart.py | 8 +- pyanaconda/text.py | 2 +- pyanaconda/textw/task_text.py | 1 - pyanaconda/upgrade.py | 1 + pyanaconda/yuminstall.py | 1112 +++++++++++++++++++++++------------------ 14 files changed, 885 insertions(+), 946 deletions(-) This patchset aims to reorganize our repository editing UI flow so that: - we don't need hacks to reset repos/sacks of YumBase object when going back, rather use new YumBase object see [1] - we can handle some errors during configuration more gracefuly see [2], [3] with screencasts - we can offer a NFSISO (this one is in the patches) and HD for base/installation repo in editing UI quite easily more generally speaking: - the code is more comprehensible, maintainable, and less prone to fallouts rooted in using yum internals in ways not expected by yum (yes, hacks) - base/install repository is handled the same way as other where possible The patchset does not: - change UI layout, I think it needs proper design - abstracts repository/packages source completely, but moves things in this direction The trick is to move tasksel step (repo editing + task selection) before reposetup step and introduce new repocollect step preceeding tasksel in which all repo specifications are collected (from method, ks, dd, /etc/anaconda.repos.d) into objects of new class RepoSpec stored in anaconda.repos list. RepoSpec objects can be used in UI (and elsewhere, e.g. in writeconfig) instead of AnacondaYumRepo (child of YumRepository) objects, using of whose made UI and logic interwined to the point of unmaintenablity. It also alows to remove stuff added into our AnacondaYumRepo (keeping only refernce to RepoSpec there). RepoSpec should go to its own module repos.py as it should be backend independent. For now, I keep it in yuminstall.py together with YumRepoSpec which is inherited from RepoSpec. There is one problem I don't address in this series of patches: The tasksel step/screen combines repo editing and task selection which is unfortunate because task selection requires all repositories to be set. The appropriate steps would be: edit repositories (UI) -> setup repositories (nonUI) -> select tasks (UI), but the first and the third are on the same screen in present UI and threfore I have to call non-UI step from the UI screen which I wasn't able to do without hack. Making task selection a separate step or adding it to group/package selection screen (where it belongs from the yum backend point of view, not sure if also from user point of view) would make things cleaner and allow to avoid the UI flow hacking (see (*) in steps 2) and 3) in "Patched flow" below) You can see in [4] how the repositories are setup after each modification in repo list. Another important change is that all the repository setup (network enablement, mounting, repo setup, sack setup, groups setup) is done in a loop over all enabled RepoSpecs which allows for better handling of errors in UI. Some overwhelming details: Present flow: 1) "reposetup" step - create ayum (YumBackend object) - add AnacondaYumRepo objects for required repos (mehtod, ks repo=, dd) and add them to ayum object - mounting of isos (for cdrom, nfsiso, hdiso) - network enablement if needed - repo setup, sack setup, group setup - editing of invalid repos in dialog - no way to disable repo at this point, in case of fail only Edit/Exit is offered 2) UI "tasksel" step - edit repos - working directly YumRepository objects (the ayum.repos is the only store of repos we have), so all setup from step 1) has to be done here too - select tasks (note that changes in repos can make task selection list obsolete in theory) 3) "basepkgsel" step - group/package selection based on installclass and ks - hacky resetting of groups/sack information needed for going back in UI (from 4, from dialog in 5) 4) UI "group-selection" step - you can go back to 2) 5) "postselection" - create transaction - in case of conflicts you can go back to 4) from a dialog 6) "writeconfig" - write anaconda-ks.cfg using ayum.repos (AnacondaYumRepository objects) Patched flow: 1) "repocollect" step - initialze RepoSpec objects storing specs of required repos (from method, ks, DD, /etc/anaconda.repos.d, addon repos for RHEL) 2) UI "repotasksel" step (formerly "tasksel", keeping its UI layout) - edit repos - works on RepoSpec objects - select tasks - after a repo is edited/enabled/disabled, step 3) has to be called so that task list can be updated 3) "reposetup" step - is skipped if we did it as a part of 2) in UI This could be removed if task selection was separated from repo editing (*) - create ayum (YumBackend object) - for each repo RepoSpec: - enable network if needed - mount repo (nfsiso, hd, cdrom) - add corresponding YumRepository object to ayum - set cache for repository - do repository setup - do sack setup - do group setup if any of the above fails, we know what repo was the cause of fail, store failure info in its RepoSpec object, go back to 2), mark failed repo in the list (see [4]) 4) "basepkgsel" step - group selection based on installclass and ks - no reset on the way back is needed as in UI step 2), we start with new ayum object 5) UI "group-selection" - you can go back to 2) 6) "postselection" - create transaction - in case of conflicts you can go back to 5) from a dialog 7) "writeconfig" - write anaconda-ks.cfg using anaconda.repos (RepoSpec objects) [1] https://bugzilla.redhat.com/show_bug.cgi?id=622376#c5 screencasts: - the bug: http://rvykydal.fedorapeople.org/repoUI/example3.ogg - fixed with patches: http://rvykydal.fedorapeople.org/repoUI/example3patched.ogg [2] if failing nfs repo= is used in kickstart - choosing Continue lead to fatal fail: http://rvykydal.fedorapeople.org/repoUI/example1.ogg - choosing Edit and Cancel lead to fatal fail: http://rvykydal.fedorapeople.org/repoUI/example1b.ogg ... also the true cause (nfs mount error) is hidden - with the patch [Edit] means going to repo UI screen where the failing repo can be disabled: http://rvykydal.fedorapeople.org/repoUI/example1patched.ogg [3] network requiring repository set by boot param repo=, no network needed till repository steps - failing to enable network for base repository is fatal: http://rvykydal.fedorapeople.org/repoUI/example3.ogg - with patch, you can fall back to media (non network) repo: http://rvykydal.fedorapeople.org/repoUI/example3patched.ogg [4] http://rvykydal.fedorapeople.org/repoUI/example.ogg

2 12

[master] reduce getPartitionsList()
by David Cantrell 20 Oct '10

20 Oct '10

Cleanup getPartitionsList() in loader/getparts.c -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

2 4

Anaconda upgrades and bootloader options
by James Laska 08 Oct '10

08 Oct '10

Greetings, During testing of Fedora 13, the Fedora QA team identified a gap in our test matrix related to text-mode upgrades. Specifically, http://bugzilla.redhat.com/590823 highlighted a failure when performing text-mode upgrades and attempting to create a new bootloader. While discussing [1] how best to cover the gap for future releases, the QA team and Chris Lumens came to the conclusion that it's not clear what the difference is between the different bootloader upgrade options offered during an anaconda upgrade (see http://docs.fedoraproject.org/en-US/Fedora/13/html-single/Installation_Guid…) 1. Create new boot loader configuration * I believe this is understand, it installs a new grub stage#1 into the MBR (or partition). * In the days of lilo and grub, perhaps this offered a choice of bootloaders? 2. Update boot loader configuration * does not run grub-install * When the kernel package is upgraded, it will call 'new-kernel-pkg' from it's %scripts and this eventually updates the existing bootloader configuration file (e.g. grub.conf, yaboot.conf, elilo.conf, zipl.conf). 3. Skip boot loader updating * does not run grub-install * When the kernel package is upgraded, it will call 'new-kernel-pkg' from it's %scripts and this eventually updates the existing bootloader configuration file (e.g. grub.conf, yaboot.conf, elilo.conf, zipl.conf). The open question from Fedora QA [1] is, is there value in presenting options#2 and options#3? From what we can tell, they result in the same upgraded system. Thanks, James [1] https://fedorahosted.org/fedora-qa/ticket/86

4 7

[PATCH] Run anaconda in fullscreen mode.
by Chris Lumens 08 Oct '10

08 Oct '10

This involved updating the main glade file, and I did so in glade-3 which makes the commit look much more involved than it needs to be. I also removed some container widgets that have basically been unused since we got rid of the release notes viewer and the help panel. --- data/ui/anaconda.glade | 421 ++++++++++++++++++------------------------------ pyanaconda/gui.py | 4 +- 2 files changed, 155 insertions(+), 270 deletions(-) diff --git a/data/ui/anaconda.glade b/data/ui/anaconda.glade index 08e9e64..ef000b0 100644 --- a/data/ui/anaconda.glade +++ b/data/ui/anaconda.glade @@ -1,270 +1,155 @@ -<?xml version="1.0" standalone="no"?>  -<!DOCTYPE glade-interface SYSTEM "http://glade.gnome.org/glade-2.0.dtd"> - +<?xml version="1.0" encoding="UTF-8"?> <glade-interface> - -<widget class="GtkWindow" id="mainWindow"> - <property name="width_request">610</property> - <property name="height_request">450</property> - <property name="title" translatable="yes"></property> - <property name="type">GTK_WINDOW_TOPLEVEL</property> - <property name="window_position">GTK_WIN_POS_CENTER</property> - <property name="modal">False</property> - <property name="default_width">800</property> - <property name="default_height">600</property> - <property name="resizable">False</property> - <property name="destroy_with_parent">False</property> - <property name="decorated">True</property> - <property name="skip_taskbar_hint">False</property> - <property name="skip_pager_hint">False</property> - <property name="type_hint">GDK_WINDOW_TYPE_HINT_NORMAL</property> - <property name="gravity">GDK_GRAVITY_CENTER</property> - <property name="focus_on_map">True</property> - <property name="urgency_hint">False</property> - <signal name="key_release_event" handler="on_mainWindow_key_release_event" last_modification_time="Wed, 12 Jan 2005 20:53:20 GMT"/> - <signal name="delete_event" handler="on_mainWindow_delete_event" last_modification_time="Wed, 12 Jan 2005 21:03:14 GMT"/> - - <child> - <widget class="GtkVBox" id="mainBox"> - <property name="visible">True</property> - <property name="homogeneous">False</property> - <property name="spacing">12</property> - - <child> - <widget class="GtkImage" id="headerImage"> - <property name="visible">True</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">True</property> - </packing> - </child> - - <child> - <widget class="GtkTable" id="mainTable"> - <property name="border_width">12</property> - <property name="visible">True</property> - <property name="n_rows">1</property> - <property name="n_columns">2</property> - <property name="homogeneous">False</property> - <property name="row_spacing">0</property> - <property name="column_spacing">0</property> - - <child> - <widget class="GtkFrame" id="installFrame"> - <property name="visible">True</property> - <property name="label_xalign">0</property> - <property name="label_yalign">0.5</property> - <property name="shadow_type">GTK_SHADOW_NONE</property> - - <child> - <widget class="GtkAlignment" id="alignment5"> - <property name="visible">True</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xscale">1</property> - <property name="yscale">1</property> - <property name="top_padding">0</property> - <property name="bottom_padding">0</property> - <property name="left_padding">12</property> - <property name="right_padding">0</property> - - <child> - <placeholder/> - </child> - </widget> - </child> - </widget> - <packing> - <property name="left_attach">1</property> - <property name="right_attach">2</property> - <property name="top_attach">0</property> - <property name="bottom_attach">1</property> - </packing> - </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> - </child> - - <child> - <widget class="GtkHBox" id="buttonBar"> - <property name="border_width">12</property> - <property name="visible">True</property> - <property name="homogeneous">False</property> - <property name="spacing">6</property> - - <child> - <placeholder/> - </child> - - <child> - <widget class="GtkButton" id="debugButton"> - <property name="can_focus">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <signal name="clicked" handler="on_debugButton_clicked" last_modification_time="Wed, 12 Jan 2005 20:02:25 GMT"/> - - <child> - <widget class="GtkLabel" id="label4"> - <property name="visible">True</property> - <property name="label" translatable="yes">_Debug</property> - <property name="use_underline">True</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> - <property name="width_chars">-1</property> - <property name="single_line_mode">False</property> - <property name="angle">0</property> - </widget> - </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">False</property> - </packing> - </child> - - <child> - <widget class="GtkHButtonBox" id="hbuttonbox2"> - <property name="visible">True</property> - <property name="layout_style">GTK_BUTTONBOX_END</property> - <property name="spacing">18</property> - - <child> - <widget class="GtkButton" id="backButton"> - <property name="visible">True</property> - <property name="can_default">True</property> - <property name="can_focus">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <signal name="clicked" handler="on_backButton_clicked" last_modification_time="Wed, 12 Jan 2005 20:02:34 GMT"/> - - <child> - <widget class="GtkLabel" id="label8"> - <property name="visible">True</property> - <property name="label" translatable="yes">_Back</property> - <property name="use_underline">True</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> - <property name="width_chars">-1</property> - <property name="single_line_mode">False</property> - <property name="angle">0</property> - </widget> - </child> - </widget> - </child> - - <child> - <widget class="GtkButton" id="nextButton"> - <property name="visible">True</property> - <property name="can_default">True</property> - <property name="can_focus">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <signal name="clicked" handler="on_nextButton_clicked" last_modification_time="Wed, 12 Jan 2005 20:01:46 GMT"/> - - <child> - <widget class="GtkLabel" id="label6"> - <property name="visible">True</property> - <property name="label" translatable="yes">_Next</property> - <property name="use_underline">True</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> - <property name="width_chars">-1</property> - <property name="single_line_mode">False</property> - <property name="angle">0</property> - </widget> - </child> - </widget> - </child> - - <child> - <widget class="GtkButton" id="rebootButton"> - <property name="can_default">True</property> - <property name="can_focus">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <signal name="clicked" handler="on_rebootButton_clicked" last_modification_time="Wed, 12 Jan 2005 21:46:55 GMT"/> - - <child> - <widget class="GtkLabel" id="label7"> - <property name="visible">True</property> - <property name="label" translatable="yes">Reboo_t</property> - <property name="use_underline">True</property> - <property name="use_markup">False</property> - <property name="justify">GTK_JUSTIFY_LEFT</property> - <property name="wrap">False</property> - <property name="selectable">False</property> - <property name="xalign">0.5</property> - <property name="yalign">0.5</property> - <property name="xpad">0</property> - <property name="ypad">0</property> - <property name="ellipsize">PANGO_ELLIPSIZE_NONE</property> - <property name="width_chars">-1</property> - <property name="single_line_mode">False</property> - <property name="angle">0</property> - </widget> - </child> - </widget> - </child> - - <child> - <widget class="GtkButton" id="closeButton"> - <property name="can_default">True</property> - <property name="can_focus">True</property> - <property name="label">gtk-close</property> - <property name="use_stock">True</property> - <property name="relief">GTK_RELIEF_NORMAL</property> - <property name="focus_on_click">True</property> - <signal name="clicked" handler="on_closeButton_clicked" last_modification_time="Wed, 04 Apr 2007 20:23:13 GMT"/> - </widget> - </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">True</property> - <property name="fill">True</property> - </packing> - </child> - </widget> - <packing> - <property name="padding">0</property> - <property name="expand">False</property> - <property name="fill">True</property> - </packing> - </child> - </widget> - </child> -</widget> - +  +  + <widget class="GtkWindow" id="mainWindow"> + <property name="resizable">False</property> + <property name="window_position">center</property> + <property name="gravity">center</property> + <signal name="key_release_event" handler="on_mainWindow_key_release_event" swapped="no"/> + <signal name="delete_event" handler="on_mainWindow_delete_event" swapped="no"/> + <child> + <widget class="GtkVBox" id="mainBox"> + <property name="visible">True</property> + <property name="border_width">6</property> + <property name="spacing">12</property> + <child> + <widget class="GtkImage" id="headerImage"> + <property name="visible">True</property> + </widget> + <packing> + <property name="expand">False</property> + <property name="position">0</property> + </packing> + </child> + <child> + <widget class="GtkFrame" id="installFrame"> + <property name="visible">True</property> + <property name="label_xalign">0</property> + <property name="shadow_type">none</property> + <child> + <widget class="GtkAlignment" id="alignment5"> + <property name="visible">True</property> + <property name="left_padding">12</property> + <child> + <placeholder/> + </child> + </widget> + </child> + </widget> + <packing> + <property name="position">1</property> + </packing> + </child> + <child> + <widget class="GtkHButtonBox" id="buttonBar"> + <property name="visible">True</property> + <property name="spacing">18</property> + <property name="layout_style">end</property> + <child> + <widget class="GtkButton" id="debugButton"> + <property name="can_focus">True</property> + <property name="receives_default">True</property> + <signal name="clicked" handler="on_debugButton_clicked" swapped="no"/> + <child> + <widget class="GtkLabel" id="label4"> + <property name="visible">True</property> + <property name="label" translatable="yes">_Debug</property> + <property name="use_underline">True</property> + </widget> + </child> + </widget> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">0</property> + </packing> + </child> + <child> + <widget class="GtkButton" id="backButton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="can_default">True</property> + <property name="receives_default">True</property> + <signal name="clicked" handler="on_backButton_clicked" swapped="no"/> + <child> + <widget class="GtkLabel" id="label8"> + <property name="visible">True</property> + <property name="label" translatable="yes">_Back</property> + <property name="use_underline">True</property> + </widget> + </child> + </widget> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">1</property> + </packing> + </child> + <child> + <widget class="GtkButton" id="nextButton"> + <property name="visible">True</property> + <property name="can_focus">True</property> + <property name="can_default">True</property> + <property name="receives_default">True</property> + <signal name="clicked" handler="on_nextButton_clicked" swapped="no"/> + <child> + <widget class="GtkLabel" id="label6"> + <property name="visible">True</property> + <property name="label" translatable="yes">_Next</property> + <property name="use_underline">True</property> + </widget> + </child> + </widget> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">2</property> + </packing> + </child> + <child> + <widget class="GtkButton" id="rebootButton"> + <property name="can_focus">True</property> + <property name="can_default">True</property> + <property name="receives_default">True</property> + <signal name="clicked" handler="on_rebootButton_clicked" swapped="no"/> + <child> + <widget class="GtkLabel" id="label7"> + <property name="visible">True</property> + <property name="label" translatable="yes">Reboo_t</property> + <property name="use_underline">True</property> + </widget> + </child> + </widget> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">3</property> + </packing> + </child> + <child> + <widget class="GtkButton" id="closeButton"> + <property name="label">gtk-close</property> + <property name="can_focus">True</property> + <property name="can_default">True</property> + <property name="receives_default">True</property> + <property name="use_stock">True</property> + <signal name="clicked" handler="on_closeButton_clicked" swapped="no"/> + </widget> + <packing> + <property name="expand">False</property> + <property name="fill">False</property> + <property name="position">4</property> + </packing> + </child> + </widget> + <packing> + <property name="expand">False</property> + <property name="padding">6</property> + <property name="position">2</property> + </packing> + </child> + </widget> + </child> + </widget> </glade-interface> diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py index 1853b2d..ebd0085 100755 --- a/pyanaconda/gui.py +++ b/pyanaconda/gui.py @@ -1342,9 +1342,7 @@ class InstallControlWindow: i.hide() self.window.set_resizable(True) self.window.set_size_request(-1, -1) - self.window.fullscreen() else: - self.window.set_size_request(800, 600) # if we're running in the live mode and the dpi is something weird, # give ourselves as much space as we can. this gets things to fit # with a dpi of up to 147 @@ -1356,6 +1354,8 @@ class InstallControlWindow: else: self.window.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_DESKTOP) + self.window.maximize() + if flags.debug: self.mainxml.get_widget("debugButton").show_now() self.installFrame = self.mainxml.get_widget("installFrame") -- 1.7.1.1

3 3

iSCSI GUI patches
by Ales Kozumplik 04 Oct '10

04 Oct '10

Hi, I started to learn about iSCSI by diving into the two GUI bugs I have at the moment and the large patch is the result. I redesigned the iSCSI dialog and separated it into four steps: 1) do the discovery: enter target's IP and choose how many credentials you supply and supply them: http://akozumpl.fedorapeople.org/iscsi1.png 2) select which of the discovered nodes you want to log into http://akozumpl.fedorapeople.org/iscsi2.png 3) do the login: choose how many login credentials you'll supply and write them or reuse the discovery credentials http://akozumpl.fedorapeople.org/iscsi3.png 4) result dialog is displayed telling you which nodes you manged to log into which nodes you failed to log into plus reason why. If there were failures there's also a button to go back to step 2. http://akozumpl.fedorapeople.org/iscsi4.png I had to create two new functions in iscsi.py that duplicate existing functionality there, so a another refactoring patch will follow. I'll also have to do something similar for the text UI I think. All in all this is rawhide-only material as well as all the other patches except "iscsi: rename variable in addIscsiDrive" which is a regular traceback and should go to F14. Comments welcome. Ales

3 19

[PATCH] Limit progress bar amount to 1.0
by Brian C. Lane 04 Oct '10

04 Oct '10

--- pyanaconda/gui.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py index ebd0085..0ef7ced 100755 --- a/pyanaconda/gui.py +++ b/pyanaconda/gui.py @@ -478,6 +478,9 @@ class ProgressWindow: delta -= 0.05 def set (self, amount): + if amount > self.total: + amount = self.total + # only update widget if we've changed by 5% or our timeout has # expired curval = self.progress.get_fraction() -- 1.7.2.2

3 5

[PATCH] Fix a missing storage import (#636621).
by Chris Lumens 30 Sep '10

30 Sep '10

--- anaconda | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/anaconda b/anaconda index 00c8322..66bcb00 100755 --- a/anaconda +++ b/anaconda @@ -266,6 +266,8 @@ def setupEnvironment(): os.environ["PIXMAPPATH"] = "/tmp/updates/pixmaps/:/tmp/updates/:/tmp/product/pixmaps/:/tmp/product/:pixmaps/:/usr/share/anaconda/pixmaps/:/usr/share/pixmaps/:/usr/share/anaconda/:/usr/share/python-meh/:/usr/share/icons/Fedora/48x48/apps/" def setupLoggingFromOpts(opts): + from pyanaconda import storage + if opts.loglevel and anaconda_log.logLevelMap.has_key(opts.loglevel): level = anaconda_log.logLevelMap[opts.loglevel] anaconda_log.logger.tty_loglevel = level -- 1.7.1.1

3 3

[PATCH] Fix a couple pylint-found errors.
by Chris Lumens 29 Sep '10

29 Sep '10

--- pyanaconda/iw/advanced_storage.py | 2 +- pyanaconda/storage/devicetree.py | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/pyanaconda/iw/advanced_storage.py b/pyanaconda/iw/advanced_storage.py index 24a5010..97b1d33 100644 --- a/pyanaconda/iw/advanced_storage.py +++ b/pyanaconda/iw/advanced_storage.py @@ -464,7 +464,7 @@ def addIscsiDrive(anaconda): elif step == STEP_LOGIN: rc = wizard.display_login_dialog() if rc == gtk.RESPONSE_CANCEL: - break; + break login_dict = wizard.get_login_dict() log.critical("logging with %s" % login_dict) login_dict["intf"] = anaconda.intf diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py index 44dfc71..088dc5a 100644 --- a/pyanaconda/storage/devicetree.py +++ b/pyanaconda/storage/devicetree.py @@ -39,6 +39,7 @@ from udev import * from .storage_log import log_method_call from pyanaconda import iutil import parted +import _ped import gettext _ = lambda x: gettext.ldgettext("anaconda", x) -- 1.7.1.1

2 1

Resizing LVs
by Clyde E. Kunkel 29 Sep '10

29 Sep '10

Does anaconda 14.17.4 support resizing pre-existing LVs when they are selected to be mounted but not formatted? TIA

2 3

[PATCH 1/3] Don't immediately retry on downloading a package.
by Chris Lumens 28 Sep '10

28 Sep '10

Resolves: rhbz#544323 --- yuminstall.py | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/yuminstall.py b/yuminstall.py index 31ef782..39e705d 100644 --- a/yuminstall.py +++ b/yuminstall.py @@ -17,6 +17,7 @@ import os.path import shutil import timer import warnings +import time import types import glob import re @@ -639,6 +640,14 @@ class AnacondaYum(YumSorter): def urlgrabberFailureCB (self, obj, *args, **kwargs): log.warning("Try %s/%s for %s failed" % (obj.tries, obj.retry, obj.url)) + delay = 0.25*(2**(obj.tries-1)) + if delay > 1: + w = self.anaconda.intf.waitWindow(_("Retrying"), _("Retrying package download...")) + time.sleep(delay) + w.pop() + else: + time.sleep(delay) + def getDownloadPkgs(self): downloadpkgs = [] totalSize = 0 -- 1.7.1.1

2 5

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel September 2010