Anaconda-devel April 2011

anaconda-devel@lists.stg.fedoraproject.org

18 participants
62 discussions

progress toward split-image support [lorax]
by Will Woods 04 May '11

04 May '11

...So, in the course of working on the split-image support I ended up refactoring the way that lorax is handling the arch-specific parts of image creation (basically, the stuff in images.py). The work is going on in the "treebuilder" branch (Warning: I'll probably rebase it repeatedly, so expect to have to git pull -f if you clone it), and the interesting bit is this: http://git.fedorahosted.org/git/?p=lorax.git;a=commit;h=1cbe33d2d1ea5d0b1f6… Basically, since we're using mako templates for making the runtime, why not use them for making the boot images and the tree as well? It's an incomplete, untested work-in-progress.. but it should have approximately the same featureset as current master. I think the templates are a lot easier to follow than the code in images.py. For example, sparc.tmpl: http://git.fedorahosted.org/git/?p=lorax.git;a=blob;hb=treebuilder;f=src/py… It's definitely a lot less code: 18 files changed, 709 insertions(+), 1680 deletions(-) I should have it producing images early next week, so please withhold judgement on the particulars of the code 'til I have it more complete. But I wanted to give you all some idea what I was working on, and give us a chance to talk about the overall design and such. Let me know what you think! -w

3 2

[f15-branch] iscsi: disable the 'Login' button with no nodes selected.
by Ales Kozumplik 27 Apr '11

27 Apr '11

Resolves: rhbz#700085 --- data/ui/iscsi-dialogs.glade | 2 +- pyanaconda/iw/advanced_storage.py | 11 +++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/data/ui/iscsi-dialogs.glade b/data/ui/iscsi-dialogs.glade index 342a0b5..591cbf1 100644 --- a/data/ui/iscsi-dialogs.glade +++ b/data/ui/iscsi-dialogs.glade @@ -311,7 +311,7 @@ </packing> </child> <child> - <widget class="GtkButton" id="button3"> + <widget class="GtkButton" id="button_login"> <property name="label" translatable="yes">_Login</property> <property name="response_id">1</property> <property name="visible">True</property> diff --git a/pyanaconda/iw/advanced_storage.py b/pyanaconda/iw/advanced_storage.py index 40a3585..ade1135 100644 --- a/pyanaconda/iw/advanced_storage.py +++ b/pyanaconda/iw/advanced_storage.py @@ -19,6 +19,7 @@ import gettext _ = lambda x: gettext.ldgettext("anaconda", x) # UI methods for supporting adding advanced storage devices. +import functools import gobject import gtk import gtk.glade @@ -222,6 +223,9 @@ class iSCSIGuiWizard(pih.iSCSIWizard): return self._run_dialog(self.login_dialog.dialog) def display_nodes_dialog(self, found_nodes): + def _login_button_disabler(device_selector, login_button, checked, item): + login_button.set_sensitive(len(device_selector.getSelected()) > 0) + (xml, dialog) = gui.getGladeWidget("iscsi-dialogs.glade", "nodes_dialog") store = gtk.TreeStore( gobject.TYPE_PYOBJECT, # teh object @@ -237,7 +241,7 @@ class iSCSIGuiWizard(pih.iSCSIWizard): False, # not immutable node.name)), # node's name found_nodes) - + # create and setup the device selector model = store.filter_new() view = gtk.TreeView(model) @@ -245,7 +249,10 @@ class iSCSIGuiWizard(pih.iSCSIWizard): store, model, view) - ds.createSelectionCol() + callback = functools.partial(_login_button_disabler, + ds, + xml.get_widget("button_login")) + ds.createSelectionCol(toggledCB=callback) ds.addColumn(_("Node Name"), self.NODE_NAME_COL) # attach the treeview to the dialog sw = xml.get_widget("nodes_scrolled_window") -- 1.7.3.3

2 2

[lorax] Use crc32 check when compressing with xz
by Martin Gracik 27 Apr '11

27 Apr '11

--- src/pylorax/installtree.py | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/pylorax/installtree.py b/src/pylorax/installtree.py index f7502eb..13ae6f1 100644 --- a/src/pylorax/installtree.py +++ b/src/pylorax/installtree.py @@ -521,7 +521,11 @@ class LoraxInstallTree(BaseLoraxClass): stdin=find.stdout, stdout=subprocess.PIPE, preexec_fn=chdir) - compressed = subprocess.Popen([type, "-%s" % speed], stdin=cpio.stdout, + cmd = [type, "-%s" % speed] + if type == "xz": + cmd.append("--check=crc32") + + compressed = subprocess.Popen(cmd, stdin=cpio.stdout, stdout=open(initrd.fpath, "wb")) logger.debug("compressing") -- 1.7.3.2

2 1

[master][f15-branch] Update memory requirements
by David Lehman 26 Apr '11

26 Apr '11

This patch updates minimum memory to 640MB and minimum combined swap and memory to 768MB. This will set expectations more accurately for virt users and those with old hardware.

2 4

[PATCH rhel6] Add accelerators to reinitialize dialog (#673048)
by Brian C. Lane 26 Apr '11

26 Apr '11

Resolves: rhbz#673048 --- ui/reinitialize-dialog.glade | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/reinitialize-dialog.glade b/ui/reinitialize-dialog.glade index 6b1ec5a..4eb4f5e 100644 --- a/ui/reinitialize-dialog.glade +++ b/ui/reinitialize-dialog.glade @@ -37,7 +37,7 @@ <property name="visible">True</property> <property name="can_default">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Yes, discard any data</property> + <property name="label" translatable="yes">_Yes, discard any data</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -51,7 +51,7 @@ <property name="can_default">True</property> <property name="can_focus">True</property> <property name="has_focus">True</property> - <property name="label" translatable="yes">No, keep any data</property> + <property name="label" translatable="yes">_No, keep any data</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> @@ -220,7 +220,7 @@ Are you sure this device does not contain valuable data?</property> <property name="visible">True</property> <property name="can_default">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Apply my choice to all devices with undetected partitions or filesystems</property> + <property name="label" translatable="yes">_Apply my choice to all devices with undetected partitions or filesystems</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> -- 1.7.4.4

2 1

[PATCH] Don't check /boot fs when no bootloader is installed (#698312)
by Brian C. Lane 25 Apr '11

25 Apr '11

--- pyanaconda/storage/__init__.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py index 6d0933d..8854245 100644 --- a/pyanaconda/storage/__init__.py +++ b/pyanaconda/storage/__init__.py @@ -1169,7 +1169,7 @@ class Storage(object): warnings.append(_("Installing on a FireWire device. This may " "or may not produce a working system.")) - if self.platform: + if self.platform and not self.anaconda.dispatch.stepInSkipList('instbootloader'): errors.extend(self.platform.checkBootRequest()) errors.extend(self.platform.checkBootLoaderRequest()) -- 1.7.4.4

2 1

[master] Allow DeviceFormat.cacheMajorminor to fail without an exception.
by Ales Kozumplik 25 Apr '11

25 Apr '11

Think of LVMVolumeGroups for instance that have no major:minor to be cached. Related: rhbz#695389 --- pyanaconda/storage/formats/__init__.py | 18 +++++++++++++++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/pyanaconda/storage/formats/__init__.py b/pyanaconda/storage/formats/__init__.py index 9336c89..c0b094f 100644 --- a/pyanaconda/storage/formats/__init__.py +++ b/pyanaconda/storage/formats/__init__.py @@ -259,7 +259,7 @@ class DeviceFormat(object): log.warning("failed to notify kernel of change: %s" % e) def cacheMajorminor(self): - """ Cache the value of self.majorminor. + """ Cache the value of self.majorminor. Once a device node of this format's device disappears (for instance after a teardown), it is no longer possible to figure out the value @@ -267,7 +267,15 @@ class DeviceFormat(object): that happens for caching this. """ self._majorminor = None - return self.majorminor # this does the caching + try: + self.majorminor # this does the caching + except StorageError: + # entirely possible there's no majorminor, for instance an + # LVMVolumeGroup has got no device node and no sysfs path. In this + # case obviously, calling majorminor of this object later raises an + # exception. + pass + return self._majorminor def create(self, *args, **kwargs): log_method_call(self, device=self.device, @@ -415,7 +423,11 @@ class DeviceFormat(object): except DMError: device = self.device - sysfs_path = get_sysfs_path_by_name(device) + try: + sysfs_path = get_sysfs_path_by_name(device) + except RuntimeError: + raise StorageError("DeviceFormat.majorminor: " + "can not get majorminor for '%s'" % device) dev = udev_get_device(sysfs_path[4:]) self._majorminor = "%03d%03d" %\ -- 1.7.3.3

3 4

[lorax 1/2] Use xz and gzip commands instead of libraries
by Martin Gracik 25 Apr '11

25 Apr '11

We're already using find and cpio subprocesses, so using one more subprocess is not a problem. With this approach we can pipe cpio to the xz/gzip command, which should help with the memory issues. --- lorax.spec | 3 ++- src/pylorax/constants.py | 2 ++ src/pylorax/installtree.py | 18 +++++++++++------- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/lorax.spec b/lorax.spec index 9113ccd..8a0094b 100644 --- a/lorax.spec +++ b/lorax.spec @@ -23,7 +23,8 @@ Requires: util-linux-ng Requires: dosfstools Requires: genisoimage Requires: parted -Requires: pyliblzma +Requires: gzip +Requires: xz %ifarch %{ix86} x86_64 Requires: syslinux diff --git a/src/pylorax/constants.py b/src/pylorax/constants.py index c37f0db..eb3da2f 100644 --- a/src/pylorax/constants.py +++ b/src/pylorax/constants.py @@ -41,6 +41,7 @@ class LoraxRequiredCommands(dict): self["DMSETUP"] = "dmsetup" self["FIND"] = "find" self["GCONFTOOL"] = "gconftool-2" + self["GZIP"] = "gzip" self["IMPLANTISOMD5"] = "implantisomd5" self["ISOHYBRID"] = "isohybrid" self["LDCONFIG"] = "ldconfig" @@ -53,6 +54,7 @@ class LoraxRequiredCommands(dict): self["PARTED"] = "parted" self["SSHKEYGEN"] = "ssh-keygen" self["UMOUNT"] = "umount" + self["XZ"] = "xz" def __getattr__(self, attr): return self[attr] diff --git a/src/pylorax/installtree.py b/src/pylorax/installtree.py index eda12c7..a24f450 100644 --- a/src/pylorax/installtree.py +++ b/src/pylorax/installtree.py @@ -26,7 +26,6 @@ import sys import os import shutil import gzip -import lzma import re import glob import time @@ -510,26 +509,31 @@ class LoraxInstallTree(BaseLoraxClass): start = time.time() # move corresponding modules to the tree + logger.debug("moving modules inside initrd") shutil.move(joinpaths(self.workdir, kernel.version), joinpaths(self.root, "modules")) find = subprocess.Popen([self.lcmds.FIND, "."], stdout=subprocess.PIPE, preexec_fn=chdir) - cpio = subprocess.Popen([self.lcmds.CPIO, "--quiet", "-H", "newc", "-o"], + cpio = subprocess.Popen([self.lcmds.CPIO, + "--quiet", "-H", "newc", "-o"], stdin=find.stdout, stdout=subprocess.PIPE, preexec_fn=chdir) if type == "gzip": - compressed = gzip.open(initrd.fpath, "wb") + cmd = [self.lcmds.GZIP, "-9"] elif type == "xz": - compressed = lzma.LZMAFile(initrd.fpath, "w", - options={"format":"xz", "level":9}) + cmd = [self.lcmds.XZ, "-9"] - compressed.write(cpio.stdout.read()) - compressed.close() + compressed = subprocess.Popen(cmd, stdin=cpio.stdout, + stdout=open(initrd.fpath, "wb")) + + logger.debug("compressing") + rc = compressed.wait() # move modules out of the tree again + logger.debug("moving modules outside initrd") shutil.move(joinpaths(self.root, "modules", kernel.version), self.workdir) -- 1.7.3.2

2 3

[mater] Some GUI methods that can be removed
by Ales Kozumplik 22 Apr '11

22 Apr '11

These are cherry picked from my multithreaded feature branch (to make it a bit easier to rebase in the future). The GUI install still passes.

2 4

[master] assorted s390x-related patches
by David Cantrell 22 Apr '11

22 Apr '11

What can I say. It's that platform again. It demands to be the center of attention.

4 9

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel April 2011