Anaconda-devel May 2011

anaconda-devel@lists.stg.fedoraproject.org

17 participants
52 discussions

Start a nNew thread

[kickstart] add WPA specification option
by Vratislav Podzimek 23 Jun '11

23 Jun '11

This patch adds option for WPA wifi connection specification.

2 3

[master] new version of WPA wireless networking (via NM D-Bus API)
by Vratislav Podzimek 31 May '11

31 May '11

This is a new fixed version of my previous patch.

2 4

[master] RAID gui: fix how the "Number of spares" spin button is manipulated.
by Ales Kozumplik 31 May '11

31 May '11

Some cleanup is involed that makes the change both safer and more comprehensible. Resolves: rhbz#700804 --- pyanaconda/iw/raid_dialog_gui.py | 85 ++++++++++++++----------------------- 1 files changed, 32 insertions(+), 53 deletions(-) diff --git a/pyanaconda/iw/raid_dialog_gui.py b/pyanaconda/iw/raid_dialog_gui.py index 429b05f..c71a57c 100644 --- a/pyanaconda/iw/raid_dialog_gui.py +++ b/pyanaconda/iw/raid_dialog_gui.py @@ -39,6 +39,21 @@ import gettext _ = lambda x: gettext.ldgettext("anaconda", x) class RaidEditor: + def _adjust_spares_button(self, raidlevel): + numparts = self.sparesb.get_data("numparts") + maxspares = 0 + if raidlevel is not None: + maxspares = mdraidlib.get_raid_max_spares(raidlevel, numparts) + + if maxspares > 0: + adj = self.sparesb.get_adjustment() + value = int(min(adj.value, maxspares)) + self.sparesb.set_sensitive(1) + adj.configure(value=value, lower=0, upper=maxspares, step_increment=1, + page_increment=0, page_size=0) + else: + self.sparesb.set_value(0) + self.sparesb.set_sensitive(0) def createAllowedRaidPartitionsList(self, allraidparts, reqraidpart, preexist): @@ -90,13 +105,7 @@ class RaidEditor: i = i + 1 levelcombo.set_active(defindex) - - if reqlevel is not None and reqlevel == mdraidlib.RAID0: - self.sparesb.set_sensitive(0) - - if self.sparesb: - levelcombo.connect("changed", self.raidlevelchangeCB, self.sparesb) - + levelcombo.connect("changed", self.raidlevelchangeCB) return levelcombo def createRaidMinorMenu(self, minors, reqminor): @@ -117,26 +126,9 @@ class RaidEditor: return minorcombo - def raidlevelchangeCB(self, widget, sparesb): + def raidlevelchangeCB(self, widget): raidlevel = widget.get_model()[widget.get_active()][0] - numparts = sparesb.get_data("numparts") - maxspares = mdraidlib.get_raid_max_spares(raidlevel, numparts) - - if maxspares > 0 and not mdraidlib.isRaid(mdraidlib.RAID0, raidlevel): - adj = sparesb.get_adjustment() - value = adj.value - if adj.value > maxspares: - value = maxspares - - sparesb.set_sensitive(1) - spareAdj = gtk.Adjustment(value = value, lower = 0, - upper = maxspares, step_incr = 1) - spareAdj.clamp_page(0, maxspares) - sparesb.set_adjustment(spareAdj) - sparesb.set_value(value) - else: - sparesb.set_value(0) - sparesb.set_sensitive(0) + self._adjust_spares_button(raidlevel) def run(self): if self.dialog is None: @@ -506,37 +498,24 @@ class RaidEditor: if not origrequest.exists: # Create here, pack below - numparts = len(availraidparts) - if origrequest.spares: - nspares = origrequest.spares - else: - nspares = 0 - - if origrequest.level: - maxspares = mdraidlib.get_raid_max_spares(origrequest.level, - numparts) - else: - maxspares = 0 - - spareAdj = gtk.Adjustment(value = nspares, lower = 0, - upper = maxspares, step_incr = 1) - self.sparesb = gtk.SpinButton(spareAdj, digits = 0) - self.sparesb.set_data("numparts", numparts) - - if maxspares > 0: - self.sparesb.set_sensitive(1) - else: - self.sparesb.set_value(0) - self.sparesb.set_sensitive(0) - else: - self.sparesb = gtk.Label(str(origrequest.spares)) - - - if not origrequest.exists: + # create the raid level combobox: self.levelcombo = self.createRaidLevelMenu(mdraidlib.raid_levels, origrequest.level) + # now the number-of-spares spin button: + spareAdj = gtk.Adjustment(value=0, upper=0, step_incr=1) + self.sparesb = gtk.SpinButton(spareAdj) + numparts = len(availraidparts) + self.sparesb.set_data("numparts", numparts) + # adjust the max number of spares depending on the default raid level + level_index = self.levelcombo.get_active() + selected_level = self.levelcombo.get_model()[level_index][0] + self._adjust_spares_button(selected_level) + # if there's a specific spares number request, set it + if origrequest.spares: + self.sparesb.set_value(origrequest.spares) lbl.set_mnemonic_widget(self.levelcombo) else: + self.sparesb = gtk.Label(str(origrequest.spares)) self.levelcombo = gtk.Label(origrequest.level) maintable.attach(self.levelcombo, 1, 2, row, row + 1) -- 1.7.3.3

2 2

[master] imount.c: first wait() for mount then close its stdin/stdout.
by Ales Kozumplik 26 May '11

26 May '11

Else mount can get signalled with a SIGPIPE. Resolves: rhbz#693732 --- pyanaconda/isys/imount.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyanaconda/isys/imount.c b/pyanaconda/isys/imount.c index 59e2a78..c1b7493 100644 --- a/pyanaconda/isys/imount.c +++ b/pyanaconda/isys/imount.c @@ -208,10 +208,10 @@ int mountCommandWrapper(int mode, char *dev, char *where, char *fs, else free(buffer); } - close(stdout_pipe[0]); - close(stderr_pipe[0]); waitpid(child, &status, 0); + close(stdout_pipe[0]); + close(stderr_pipe[0]); if (opts) { free(opts); -- 1.7.3.3

2 2

rawhide patches
by David Lehman 24 May '11

24 May '11

Patches 1 and 2 are sort of a set, as are patches 3 and 4.

2 5

Two patches
by David Lehman 24 May '11

24 May '11

Both patches are only for master. Patch 1 does what it says it does. Patch 2 prevents crashes when the cacheMajorMinor function is called on new formats whose device attr is not yet set (by setting it earlier).

3 5

[PATCH lorax] Add fpaste to the installation environment.
by Chris Lumens 24 May '11

24 May '11

This can be handy when debugging. --- share/ramdisk.ltmpl | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/share/ramdisk.ltmpl b/share/ramdisk.ltmpl index a8da015..3fc95db 100644 --- a/share/ramdisk.ltmpl +++ b/share/ramdisk.ltmpl @@ -72,6 +72,7 @@ install "fedora-gnome-theme" install "fedora-icon-theme" install "firstaidkit-engine" install "firstboot" +install "fpaste" install "ftp" install "gdb-gdbserver" install "gdk-pixbuf" -- 1.7.4.1

5 6

[PATCH 0/6] Add ability to run anaconda in a mock for image installs
by Brian C. Lane 24 May '11

24 May '11

This builds on dlehman's image install work and adds the ability to run anaconda from inside a mock when doing image installs using a kickstart to drive things. I started out with a stripped down anaconda script (ksimage) but it ended up not being needed. I include it only because it may be insteresting to some and won't commit it to the repo. This adds a new command line mode called 'script' that raises errors instead of falling into infinite loops when there is a problem with the kickstart. It also short-circuits the network, assuming that the host already has netowrking up and running. Additionally, it adds image cleanup to anaconda proper instead of in the anaconda-cleanup script -- it ended up that yum.log was being held open by logging and a simple logging.shutdown() freed that up so we can handle the unmounts inside anaconda. This is a big plus for error handling, it means you can fix your kickstart and rerun anaconda without and manual cleanup of mounted disk images. I am proposing adding patch 2,3,5,6 to master. The other 2 are for Informational Purposes Only :) Brian C. Lane (6): Add ksimage, execute kickstart image installs Add a script interface that raises errors Check for live when umounting Add cleanup of mounts to ksimage Add switch for script mode and fix graphics check in anaconda Add filesystem cleanup to anaconda anaconda | 29 ++++- ksimage | 264 ++++++++++++++++++++++++++++++++++++++++++++++ pyanaconda/__init__.py | 3 + pyanaconda/script.py | 195 ++++++++++++++++++++++++++++++++++ scripts/anaconda-cleanup | 7 +- 5 files changed, 491 insertions(+), 7 deletions(-) create mode 100755 ksimage create mode 100644 pyanaconda/script.py -- 1.7.4.4

3 11

[master] WPA wireless networking (via NM D-Bus API)
by Vratislav Podzimek 24 May '11

24 May '11

These are two patches that povides WPA wireless functionality both as command line options and in kickstart. They also change the way we communicate with the Network Manager when creating wireless connections (all WPA, WEP and unprotected) to use D-Bus.

4 8

[PATCH] Use our existing udev functions in anaconda-cleanup.
by Chris Lumens 23 May '11

23 May '11

--- scripts/anaconda-cleanup | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/anaconda-cleanup b/scripts/anaconda-cleanup index 4af96c5..a4771ec 100755 --- a/scripts/anaconda-cleanup +++ b/scripts/anaconda-cleanup @@ -40,6 +40,7 @@ pyanaconda.anaconda_log.init() from pyanaconda import iutil +from pyanaconda.baseudev import udev_settle, udev_trigger from pyanaconda.cmdline import InstallInterface from pyanaconda.storage import StorageDiscoveryConfig from pyanaconda.storage.devicetree import DeviceTree @@ -82,8 +83,8 @@ for mounted in reversed(open("/proc/mounts").readlines()): os.system("umount %s" % mountpoint) os.system("udevadm control --env=ANACONDA=1") -os.system("udevadm trigger --subsystem-match block") -os.system("udevadm settle") +udev_trigger(subsystem="block", action="change") +udev_settle() devicetree = DeviceTree(intf=intf, conf=storage_config) devicetree.populate(cleanupOnly=True) devicetree.teardownAll() -- 1.7.4.1

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel May 2011