Anaconda-devel January 2012

anaconda-devel@lists.stg.fedoraproject.org

22 participants
63 discussions

Re: Driver Disk v3 format
by Mike Young 31 Jan '12

31 Jan '12

Hi, First of all, I apologize re-opening such an old thread. But while I have found some clarifications on the file system layout for the ddv3 drivers, along with some patches, I have been unable to actually find any real documentation on how to create a ddv3 driver. For example, I see the structure is as follows: > DDv3 structure > -------------- > / > |rhdd3 - DD marker, contains the DD's description string > /rpms > | /i386 - contains RPMs for this arch and acts as Yum repo > | /i586 > | /x86_64 > | /ppc > | /... But what I don't see is what else it might be looking for. Do I still package these folders into a .iso package? If there's some documentation on this procedure, I'd really appreciate a link to it. The search terms I'm using must be too generic and the only thing that reports anything substantive is ddv3. Unfortunately, everything leads back to this thread. Thanks! Mike

3 5

[PATCH rhel6-branch 1/3] Add mnemonics to Configure Network button (#766902)
by Radek Vykydal 31 Jan '12

31 Jan '12

Resolves: rhbz#766902 --- ui/network.glade | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ui/network.glade b/ui/network.glade index caabf25..fc4c86b 100644 --- a/ui/network.glade +++ b/ui/network.glade @@ -235,7 +235,7 @@ <property name="visible">True</property> <property name="can_default">True</property> <property name="can_focus">True</property> - <property name="label" translatable="yes">Configure Network</property> + <property name="label" translatable="yes">_Configure Network</property> <property name="use_underline">True</property> <property name="relief">GTK_RELIEF_NORMAL</property> <property name="focus_on_click">True</property> -- 1.7.4

2 5

[PATCH] Search /lib/firmware/updates and /tmp/DD/lib/firmware/updates
by Martin Sivak 31 Jan '12

31 Jan '12

New version of this patch, we need to prepend the paths. Resolves: rhbz#784327 --- loader/driverdisk.c | 8 +++----- loader/driverdisk.h | 1 + loader/fwloader.c | 7 +++++++ loader/fwloader.h | 1 + loader/loader.c | 2 +- 5 files changed, 13 insertions(+), 6 deletions(-) diff --git a/loader/driverdisk.c b/loader/driverdisk.c index 707c253..092de64 100644 --- a/loader/driverdisk.c +++ b/loader/driverdisk.c @@ -300,7 +300,6 @@ static int loadDriverDisk(struct loaderData_s *loaderData, char *mntpt) { /* FIXME moduleInfoSet modInfo = loaderData->modInfo; */ char file[200], dest[200], src[200]; char *title; - char *fwdir = NULL; struct moduleBallLocation * location; struct stat sb; static int disknum = 0; @@ -374,13 +373,12 @@ static int loadDriverDisk(struct loaderData_s *loaderData, char *mntpt) { logMessage(ERROR, "Error running depmod -a for driverdisc no.%d", disknum); } - checked_asprintf(&fwdir, DD_FIRMWARE); - if (!access(fwdir, R_OK|X_OK)) { - add_fw_search_dir(loaderData, fwdir); + if (!access(DD_FIRMWARE, R_OK|X_OK)) { + insert_fw_search_dir(loaderData, DD_FIRMWARE); + insert_fw_search_dir(loaderData, DD_FIRMWARE_UPDATES); stop_fw_loader(loaderData); start_fw_loader(loaderData); } - free(fwdir); /* TODO generate and read module info * diff --git a/loader/driverdisk.h b/loader/driverdisk.h index 4dc8685..d70fe49 100644 --- a/loader/driverdisk.h +++ b/loader/driverdisk.h @@ -28,6 +28,7 @@ #define DD_EXTRACTED "/tmp/DD" #define DD_MODULES "/tmp/DD/lib/modules" #define DD_FIRMWARE "/tmp/DD/lib/firmware" +#define DD_FIRMWARE_UPDATES "/tmp/DD/lib/firmware/updates" extern char *ddFsTypes[]; diff --git a/loader/fwloader.c b/loader/fwloader.c index a91ff6b..902c63f 100644 --- a/loader/fwloader.c +++ b/loader/fwloader.c @@ -604,6 +604,13 @@ void add_fw_search_dir(struct loaderData_s *loaderData, char *dir) dir); } +void insert_fw_search_dir(struct loaderData_s *loaderData, char *dir) +{ + argz_insert(&loaderData->fw_search_pathz, &loaderData->fw_search_pathz_len, + loaderData->fw_search_pathz, dir); +} + + void do_fw_loader(struct loaderData_s *loaderData) { struct fw_loader fwl; diff --git a/loader/fwloader.h b/loader/fwloader.h index e0b0fe8..daa69ec 100644 --- a/loader/fwloader.h +++ b/loader/fwloader.h @@ -26,6 +26,7 @@ extern void set_fw_search_path(struct loaderData_s *loaderData, char *path); extern void add_fw_search_dir(struct loaderData_s *loaderData, char *dir); +extern void insert_fw_search_dir(struct loaderData_s *loaderData, char *dir); extern void start_fw_loader(struct loaderData_s *loaderData); extern void stop_fw_loader(struct loaderData_s *loaderData); diff --git a/loader/loader.c b/loader/loader.c index 177d8a3..5bbb7c1 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -2079,7 +2079,7 @@ int main(int argc, char ** argv) { } if (hasGraphicalOverride()) flags |= LOADER_FLAGS_EARLY_NETWORKING; - set_fw_search_path(&loaderData, "/firmware:/lib/firmware"); + set_fw_search_path(&loaderData, "/lib/firmware/updates:/firmware:/lib/firmware"); start_fw_loader(&loaderData); arg = "/lib/modules/module-info"; -- 1.7.4.4

2 1

[PATCH] Search /lib/firmware/updates and /tmp/DD/lib/firmware/updates
by Martin Sivak 30 Jan '12

30 Jan '12

Resolves: rhbz#784327 --- loader/driverdisk.c | 7 ++----- loader/driverdisk.h | 1 + loader/loader.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/loader/driverdisk.c b/loader/driverdisk.c index 707c253..26033d2 100644 --- a/loader/driverdisk.c +++ b/loader/driverdisk.c @@ -300,7 +300,6 @@ static int loadDriverDisk(struct loaderData_s *loaderData, char *mntpt) { /* FIXME moduleInfoSet modInfo = loaderData->modInfo; */ char file[200], dest[200], src[200]; char *title; - char *fwdir = NULL; struct moduleBallLocation * location; struct stat sb; static int disknum = 0; @@ -374,13 +373,11 @@ static int loadDriverDisk(struct loaderData_s *loaderData, char *mntpt) { logMessage(ERROR, "Error running depmod -a for driverdisc no.%d", disknum); } - checked_asprintf(&fwdir, DD_FIRMWARE); - if (!access(fwdir, R_OK|X_OK)) { - add_fw_search_dir(loaderData, fwdir); + if (!access(DD_FIRMWARE, R_OK|X_OK)) { + add_fw_search_dir(loaderData, DD_FIRMWARE_SEARCH); stop_fw_loader(loaderData); start_fw_loader(loaderData); } - free(fwdir); /* TODO generate and read module info * diff --git a/loader/driverdisk.h b/loader/driverdisk.h index 4dc8685..421f572 100644 --- a/loader/driverdisk.h +++ b/loader/driverdisk.h @@ -28,6 +28,7 @@ #define DD_EXTRACTED "/tmp/DD" #define DD_MODULES "/tmp/DD/lib/modules" #define DD_FIRMWARE "/tmp/DD/lib/firmware" +#define DD_FIRMWARE_SEARCH "/tmp/DD/lib/firmware/updates:/tmp/DD/lib/firmware" extern char *ddFsTypes[]; diff --git a/loader/loader.c b/loader/loader.c index 177d8a3..5bbb7c1 100644 --- a/loader/loader.c +++ b/loader/loader.c @@ -2079,7 +2079,7 @@ int main(int argc, char ** argv) { } if (hasGraphicalOverride()) flags |= LOADER_FLAGS_EARLY_NETWORKING; - set_fw_search_path(&loaderData, "/firmware:/lib/firmware"); + set_fw_search_path(&loaderData, "/lib/firmware/updates:/firmware:/lib/firmware"); start_fw_loader(&loaderData); arg = "/lib/modules/module-info"; -- 1.7.4.4

1 0

[rhel7-alpha] Patches for networking on s390
by Radek Vykydal 27 Jan '12

27 Jan '12

These patches are already on master, they didn't make it in F16, but Dan Horak tested them when doing his special builds of F16 on s390.

1 2

[PATCH 1/2] Fixup getDeviceBy* methods
by Brian C. Lane 26 Jan '12

26 Jan '12

From: "Brian C. Lane" <bcl(a)redhat.com> --- pyanaconda/storage/devicetree.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/pyanaconda/storage/devicetree.py b/pyanaconda/storage/devicetree.py index 5c789b0..93f4dd4 100644 --- a/pyanaconda/storage/devicetree.py +++ b/pyanaconda/storage/devicetree.py @@ -2035,6 +2035,7 @@ class DeviceTree(object): found = device break + log_method_return(self, found) return found def getDeviceByUuid(self, uuid): @@ -2050,6 +2051,7 @@ class DeviceTree(object): found = device break + log_method_return(self, found) return found def getDevicesBySerial(self, serial): @@ -2060,6 +2062,8 @@ class DeviceTree(object): continue if device.serial == serial: devices.append(device) + + log_method_return(self, devices) return devices def getDeviceByLabel(self, label): @@ -2076,6 +2080,7 @@ class DeviceTree(object): found = device break + log_method_return(self, found) return found def getDeviceByName(self, name): @@ -2103,6 +2108,7 @@ class DeviceTree(object): log_method_return(self, None) return None + found = None leaf = None other = None for device in self._devices: -- 1.7.6.5

2 2

[newui] KeyboardSpoke improvements
by Vratislav Podzimek 26 Jan '12

26 Jan '12

These patches include improvements of the KeyboardSpoke based on your comments and some other ideas. A video presenting these changes can be found at: http://vpodzime.fedorapeople.org/add_layouts.ogg and as well as the previous one it doesn't contain the mouse pointer and the dialog may seem a bit slow and unresponsive because it was recorded on a virtual machine and the list of layouts was loaded from a file. -- Vratislav Podzimek

4 20

Misc. patches
by David Lehman 26 Jan '12

26 Jan '12

Patches 1-4 are all small, simple fixes. Patch 5 is a temporary/partial fix. We don't want to set the system's hostname to match what the user entered since we're doing an image install. The reason we do this for normal installs is mdadm will use the hostname when labeling md component devices. We can probably use the --homehost option to mdadm instead, but that is non-trivial. md image installs are not high enough priority to work on this any more right now.

2 6

[newui] patches for default focus and tabbing through widgets
by David Lehman 26 Jan '12

26 Jan '12

Sets up which widgets get focus by default and enables tabbing through widgets in the dialogs.

2 3

[PATCH - newui] Don't allow going into the storage spoke until it's ready
by Chris Lumens 26 Jan '12

26 Jan '12

Attached are patches that make yet more use of threads to allow marking the storage spoke selector as insensitive until storageInitialize is done. Once it's done, the spoke selector is marked as sensitive via a callback passed through in a kind of messy fashion. I know at least Will is going to object to this approach, based on talks in #anaconda. He'd prefer that I set it up so you can immediately go into the storage spoke and devices are shown as they are detected. I think that's a good idea, but I have chosen to not do so for the following reasons: (1) It would require changes to storageInitialize and DeviceTree that I don't believe we have time or manpower for right now. (1a) We can always go back and add this kind of fancier, on-demand behavior later. I don't think i've done anything to prevent that. (2) Storage probing is done in multiple passes and builds up as a tree. I think we'd run into a problem where component devices of more complicated structures are shown as intermediates. I'm thinking the drives that are components of a multipath or RAID set here. (3) I had more reasons, but I cannot recall them. Anyway, I expect very few people to ever see this behavior no matter how fancy it is. Storage probing starts very early on, even before the UI is up, which provides a lot of time for probing the handful of local disks that makes up the vast majority of users. Much fancier setups will definitely take longer, and I believe they'll be fine with waiting a bit. I must admit I'm a little worried about this expanded use of threads, but I can't see anything beyond storage (and perhaps install source, which needs to know storage info) needing to do this. I would at least like to discourage use of the stuff in these patches. If everyone thinks I'm not completely crazy here, I'll work on making the notification shinier. - Chris

2 6

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel January 2012