Anaconda-devel May 2012

anaconda-devel@lists.stg.fedoraproject.org

26 participants
106 discussions

Ability to install to loopmounted filesystem - mentor wanted
by Tirtha Chatterjee 02 Dec '12

02 Dec '12

Hello. I am trying to implement something like Wubi on Fedora. For this, I first need to make it possible to install to loopmounted filesystems through anaconda. I don't think a lot of modification to the existing source code is required. I tried going through the source code, but it seemed quite big to manage without some guidance. I would be extremely happy if someone guided me on this. Hoping for an affirmative reply :-) -- Regards Tirtha Chatterjee KDE developer http://wyuka.co.cc/

2 3

[newui] Setting up multiple layouts in the installation and target
by Vratislav Podzimek 05 Jun '12

05 Jun '12

This is the second version of patches that enable two things: 1) Setting up multiple layouts defined in the kickstart ASAP, so that they are already active when the GUI appears. 2) Setting up multiple layouts in the installed system. -- Vratislav Podzimek

2 8

[lorax 1/2] Install rpcbind (#824835)
by Martin Gracik 01 Jun '12

01 Jun '12

Dracut nfs module needs it. --- share/runtime-install.tmpl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/share/runtime-install.tmpl b/share/runtime-install.tmpl index 4916b4e..d15aaf2 100644 --- a/share/runtime-install.tmpl +++ b/share/runtime-install.tmpl @@ -38,6 +38,9 @@ installpkg kernel ## extra dracut modules installpkg dracut-network anaconda-dracut +## rpcbind or portmap needed by dracut nfs module +installpkg rpcbind + ## required for dracut installpkg kbd kbd-misc ## required for anaconda-dracut (img-lib etc.) -- 1.7.9.5

2 4

[PATCH rhel6-branch] Handle offload qla4xxx iscsi devices properly (#823810)
by Radek Vykydal 01 Jun '12

01 Jun '12

These kind of devices, when qla4xxx.ql4xdisablesysfsboot=1, is discovered by anaconda/udev as iscsi device yet it can not be handled by iscsiadm so we need to treat it specially. Resolves: rhbz#823810 --- storage/devices.py | 33 +++++++++++++++++++++++++-------- storage/devicetree.py | 30 ++++++++++++++++++++---------- storage/udev.py | 28 +++++++++++++++++++++++++--- 3 files changed, 70 insertions(+), 21 deletions(-) diff --git a/storage/devices.py b/storage/devices.py index 96c6238..674ef5a 100644 --- a/storage/devices.py +++ b/storage/devices.py @@ -3634,19 +3634,36 @@ class iScsiDiskDevice(DiskDevice, NetworkStorageDevice): self.ibft = kwargs.pop("ibft") self.nic = kwargs.pop("nic") self.initiator = kwargs.pop("initiator") - DiskDevice.__init__(self, device, **kwargs) - NetworkStorageDevice.__init__(self, host_address=self.node.address, - nic=self.nic) - log.debug("created new iscsi disk %s %s:%d via %s:%s" % (self.node.name, - self.node.address, - self.node.port, - self.node.iface, - self.nic)) + + if self.node is None: + # qla4xxx partial offload + name = kwargs.pop("fw_name") + address = kwargs.pop("fw_address") + port = kwargs.pop("fw_port") + DiskDevice.__init__(self, device, **kwargs) + NetworkStorageDevice.__init__(self, + host_address=address, + nic=self.nic) + log.debug("created new iscsi disk %s %s:%s using fw initiator %s" + % (name, address, port, self.initiator)) + else: + DiskDevice.__init__(self, device, **kwargs) + NetworkStorageDevice.__init__(self, host_address=self.node.address, + nic=self.nic) + log.debug("created new iscsi disk %s %s:%d via %s:%s" % (self.node.name, + self.node.address, + self.node.port, + self.node.iface, + self.nic)) def dracutSetupArgs(self): if self.ibft: return set(["iscsi_firmware"]) + # qla4xxx partial offload + if self.node is None: + return set() + address = self.node.address # surround ipv6 addresses with [] if ":" in address: diff --git a/storage/devicetree.py b/storage/devicetree.py index e6ae639..30d0a2a 100644 --- a/storage/devicetree.py +++ b/storage/devicetree.py @@ -1180,16 +1180,26 @@ class DeviceTree(object): kwargs = { "serial": serial, "vendor": vendor, "bus": bus } if udev_device_is_iscsi(info): diskType = iScsiDiskDevice - node = self.iscsi.getNode( - udev_device_get_iscsi_name(info), - udev_device_get_iscsi_address(info), - udev_device_get_iscsi_port(info), - udev_device_get_iscsi_nic(info)) - kwargs["node"] = node - kwargs["nic"] = self.iscsi.ifaces.get(node.iface, node.iface) - kwargs["ibft"] = node in self.iscsi.ibftNodes - kwargs["initiator"] = self.iscsi.initiator - log.debug("%s is an iscsi disk" % name) + initiator = udev_device_get_iscsi_initiator(info) + target = udev_device_get_iscsi_name(info) + address = udev_device_get_iscsi_address(info) + port = udev_device_get_iscsi_port(info) + nic = udev_device_get_iscsi_nic(info) + kwargs["initiator"] = initiator + if initiator == self.iscsi.initiator: + node = self.iscsi.getNode(target, address, port, nic) + kwargs["node"] = node + kwargs["ibft"] = node in self.iscsi.ibftNodes + kwargs["nic"] = self.iscsi.ifaces.get(node.iface, node.iface) + log.debug("%s is an iscsi disk" % name) + else: + # qla4xxx partial offload + kwargs["node"] = None + kwargs["ibft"] = False + kwargs["nic"] = "offload:not_accessible_via_iscsiadm" + kwargs["fw_address"] = address + kwargs["fw_port"] = port + kwargs["fw_name"] = name elif udev_device_is_fcoe(info): diskType = FcoeDiskDevice kwargs["nic"] = udev_device_get_fcoe_nic(info) diff --git a/storage/udev.py b/storage/udev.py index f00e316..15ec238 100644 --- a/storage/udev.py +++ b/storage/udev.py @@ -553,19 +553,41 @@ def udev_device_get_iscsi_port(info): # IPV6 contains : within the address, the part after the last : is the port return path_components[address_field].split(":")[-1] -def udev_device_get_iscsi_nic(info): +def udev_device_get_iscsi_session(info): # '/devices/pci0000:00/0000:00:02.0/0000:09:00.0/0000:0a:01.0/0000:0e:00.2/host3/session1/target3:0:0/3:0:0:0/block/sda' # The position of sessionX part depends on device # (e.g. offload vs. sw; also varies for different offload devs) + session = None match = re.match('/.*/(session\d+)', info["sysfs_path"]) if match: session = match.groups()[0] + else: + log.error("udev_device_get_iscsi_session: session not found in %s" % info) + return session + + +def udev_device_get_iscsi_nic(info): + iface = None + session = udev_device_get_iscsi_session(info) + if session: iface = open("/sys/class/iscsi_session/%s/ifacename" % session).read().strip() - else: - iface = None return iface +def udev_device_get_iscsi_initiator(info): + initiator = None + if udev_device_is_partoff_iscsi(info): + host = re.match('.*/(host\d+)', info["sysfs_path"]).groups()[0] + initiator = open("/sys/class/iscsi_host/%s/initiatorname" % + host).read().strip() + else: + session = udev_device_get_iscsi_session(info) + if session: + initiator = open("/sys/class/iscsi_session/%s/initiatorname" % + session).read().strip() + return initiator + + # fcoe disks have ID_PATH in the form of: # For FCoE directly over the NIC (so no VLAN and thus no DCB): # pci-eth#-fc-${id} -- 1.7.4

2 3

[lorax 1/3] livemedia-creator: handle failed mount for ami
by Brian C. Lane 31 May '12

31 May '12

From: "Brian C. Lane" <bcl(a)redhat.com> --- src/sbin/livemedia-creator | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index 6b22315..3c37cb5 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -364,6 +364,9 @@ def make_ami( disk_img, ami_img="ami-root.img", ami_label="AMI" ): All other AMI setup is handled by the kickstart's %post """ with PartitionMount( disk_img ) as img_mount: + if not img_mount or not img_mount.mount_dir: + return None + work_dir = tempfile.mkdtemp() log.info("working dir is {0}".format(work_dir)) log.info("creating {0}".format(ami_img)) -- 1.7.7.6

1 2

[PATCH rhel7-alpha2-branch] Don't depend on plymouth for shell (#826984)
by Jesse Keating 31 May '12

31 May '12

--- data/systemd/anaconda-shell@.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/systemd/anaconda-shell@.service b/data/systemd/anaconda-shell@.service index 52bed74..34d5848 100644 --- a/data/systemd/anaconda-shell@.service +++ b/data/systemd/anaconda-shell@.service @@ -3,7 +3,7 @@ [Unit] Description=Shell on %I BindTo=dev-%i.device -After=dev-%i.device systemd-user-sessions.service plymouth-quit-wait.service +After=dev-%i.device systemd-user-sessions.service [Service] WorkingDirectory=/ -- 1.7.10.2

2 2

Re: Allow sharing of the VNC server (Jesse Keating)
by Mark Hamzy 31 May '12

31 May '12

jkeating(a)redhat.com wrote on 05/31/2012 12:17:39 -0700: > Also, are you really sure we only allow one install ssh session? 'cause > I've sshed in as root@ multiple times in my testing, no restriction. Of > course, can't do multiple install@ because the shell for that user is > /sbin/anaconda :) Yes, I've verified that as well. You can have multiple ssh root@ip open at once. > Are there any other opinions here? I agree that if we change the default to open a shared vnc session and allow the user to specify a vncpassword (which we already do), then that should address any security concerns. Mark

1 0

[newui] network spoke patches
by Radek Vykydal 31 May '12

31 May '12

Apply method and two UI refresh fixes.

2 7

[PATCH rhel7-alpha2-branch] dracut: fix parse-kickstart traceback with 'network' command (#824842)
by Will Woods 31 May '12

31 May '12

str.join() takes a single list argument. It won't take a list of arguments. Grr. Also, fix some goofiness with empty items (sometimes they're None and sometimes they're "") --- dracut/parse-kickstart | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/dracut/parse-kickstart b/dracut/parse-kickstart index 9baece0..12c9f8b 100755 --- a/dracut/parse-kickstart +++ b/dracut/parse-kickstart @@ -180,11 +180,17 @@ def ksnet_to_dracut(args, lineno, net, bootdev=False): if ":" in net.gateway: net.gateway = "[%s]" % net.gateway + if net.ipv6 and not net.ip: + ip = "[%s]" % net.ipv6 + else: + ip = net.ip - ip=":".join(net.ip or "[%s]" % net.ipv6, "", net.gateway, net.netmask, - net.hostname, net.device, net.autoconf, net.mtu) + iplist = [ip, "", net.gateway, net.netmask, + net.hostname, net.device, net.autoconf] + if net.mtu: + iplist.append(net.mtu) - line.append("ip=%s" % ip) + line.append("ip=" + ":".join(i or "" for i in iplist)) for ns in net.nameserver.split(","): if ns: -- 1.7.10.2

2 1

[PATCH] Set the python path within anaconda
by Jesse Keating 31 May '12

31 May '12

Instead of manipulating the path outside of anaconda, which can get tricky when starting anaconda from ssh, instead update the path inside anaconda itself. This means we can't get things like os, sys, etc.. from /tmp/updates/, but an updates image can replace these modules by using the full path to them (e.g. /usr/lib/python...) --- anaconda | 2 ++ data/systemd/anaconda@.service | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/anaconda b/anaconda index b76af4d..4959a87 100755 --- a/anaconda +++ b/anaconda @@ -277,6 +277,8 @@ def parseOptions(argv=None, cmdline=None): return (opts, args, op.deprecated_bootargs) def setupPythonPath(): + # First add our updates path + sys.path.insert(0, '/tmp/updates/') sys.path.append('/usr/share/system-config-date') def setupEnvironment(): diff --git a/data/systemd/anaconda@.service b/data/systemd/anaconda@.service index 903df7a..03ecabb 100644 --- a/data/systemd/anaconda@.service +++ b/data/systemd/anaconda@.service @@ -3,7 +3,7 @@ Description=Anaconda After=anaconda.target [Service] -Environment=HOME=/root MALLOC_CHECK_=2 MALLOC_PERTURB_=204 PATH=/usr/bin:/bin:/sbin:/usr/sbin:/mnt/sysimage/bin:/mnt/sysimage/usr/bin:/mnt/sysimage/usr/sbin:/mnt/sysimage/sbin PYTHONPATH=/tmp/updates +Environment=HOME=/root MALLOC_CHECK_=2 MALLOC_PERTURB_=204 PATH=/usr/bin:/bin:/sbin:/usr/sbin:/mnt/sysimage/bin:/mnt/sysimage/usr/bin:/mnt/sysimage/usr/sbin:/mnt/sysimage/sbin Type=oneshot WorkingDirectory=/root ExecStart=/usr/sbin/anaconda -- 1.7.10.2

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel May 2012