On Thu, Jun 23, 2016 at 05:36:38PM +0200, Jiří Konečný wrote:
Hello guys,
I'm doing this bug https://bugzilla.redhat.com/show_bug.cgi?id=1113207%C2%A0 and because of it I need to create new KS command for snapshot creation. Because kickstart is something with really stable API, I want to ask everyone before I'll implement something badly.
Possible solutions:
Adding --snapshot parameter to existing KS command
* It should be easier to implement. * Could be easier to find in documentation. * It's logically part of that storage type. * logvol command have big number of parameters now.
Adding standalone snapshot command
* Harder to implement but it's more general. * Easier to extend. * Easier to just add support for btrfs with additional required parameters and anything else in future and syntax will not change so much.
Personally I see the snapshot command as better choice but want to hear your idea.
I like the standalone snapshot command. The user doesn't need to know what's underneath it and could possibly do:
autopart --type=thinp snapshot --name=initial_install
And then switching to btrfs would be as simple as using a different autopart type.
If used with non-autopart it will also need to sanity check their storage setup to make sure they are using something that supports snapshots.
I also agree with your comment in the bug, minimize changes to Anaconda and keep using /.