Hi everyone, Glade test cases on master (more precisely tests/glade/icons/check_icons.py) show me the following errors. Can you shed a bit more light into this and how to move forward with it? Also do you need 1 bug opened for everything or separate bugs for each glade file/directory ?
Invalid icon name application-exit found at ../pyanaconda/ui/gui/main.glade:138 Invalid icon name dialog-error found at ../pyanaconda/ui/gui/spokes/advstorage/dasd.glade:210 Invalid icon name dialog-error found at ../pyanaconda/ui/gui/spokes/advstorage/fcoe.glade:175 Invalid icon name dialog-error found at ../pyanaconda/ui/gui/spokes/advstorage/zfcp.glade:253 Invalid icon name dialog-information found at ../pyanaconda/ui/gui/spokes/advstorage/iscsi.glade:229 Invalid icon name dialog-error found at ../pyanaconda/ui/gui/spokes/advstorage/iscsi.glade:522 Invalid icon name dialog-error found at ../pyanaconda/ui/gui/spokes/advstorage/iscsi.glade:1043 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:10 Invalid icon name system-run-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:32 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:48 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:53 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:58 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:282 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:287 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:292 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/keyboard.glade:83 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:192 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:207 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:222 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:237 Invalid icon name input-keyboard-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:253 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:183 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:199 Invalid icon name view-refresh-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:215 Invalid icon name system-help-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:231 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/lib/dasdfmt.glade:124 Invalid icon name emblem-ok-symbolic found at ../pyanaconda/ui/gui/spokes/lib/dasdfmt.glade:261 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/lib/refresh.glade:105 Invalid icon name emblem-ok-symbolic found at ../pyanaconda/ui/gui/spokes/lib/refresh.glade:281 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade:514 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade:909 Invalid icon name image-missing found at ../pyanaconda/ui/gui/spokes/lib/passphrase.glade:213 Invalid icon name dialog-warning found at ../pyanaconda/ui/gui/spokes/lib/passphrase.glade:258 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:275 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:289 Invalid icon name network-wired found at ../pyanaconda/ui/gui/spokes/network.glade:340 Invalid icon name network-wireless found at ../pyanaconda/ui/gui/spokes/network.glade:759 Invalid icon name network-cellular-connected-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:1206 Invalid icon name network-vpn found at ../pyanaconda/ui/gui/spokes/network.glade:1523 Invalid icon name preferences-system-network found at ../pyanaconda/ui/gui/spokes/network.glade:1789 Invalid icon name dialog-password-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:2415 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/source.glade:1023 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/source.glade:1042 Invalid icon name view-refresh found at ../pyanaconda/ui/gui/spokes/source.glade:1061 Invalid icon name drive-harddisk found at ../pyanaconda/ui/gui/spokes/storage.glade:685 Invalid icon name application-exit found at ../pyanaconda/ui/gui/spokes/welcome.glade:83 Invalid icon name application-exit found at ../pyanaconda/ui/gui/spokes/welcome.glade:503
-- Alex
On 03/10/2015 09:39 AM, Alexander Todorov wrote:
Hi everyone, Glade test cases on master (more precisely tests/glade/icons/check_icons.py) show me the following errors. Can you shed a bit more light into this and how to move forward with it?
Do you have gnome-icon-theme installed? Anaconda uses the gnome icon theme, and this test makes sure that the icon names didn't change on us (because one time a bunch of names moved to "legacy" and we weren't installing the legacy package).
Also do you need 1 bug opened for everything or separate bugs for each glade file/directory ?
If there actually is a bug here then 1 bug is enough bugs.
OK, found the issue, gnome-icon-theme was not installed (see PR #32).
What's left is:
Invalid icon name emblem-ok-symbolic found at ../pyanaconda/ui/gui/spokes/lib/dasdfmt.glade:261 Invalid icon name emblem-ok-symbolic found at ../pyanaconda/ui/gui/spokes/lib/refresh.glade:281 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:183 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:199 Invalid icon name view-refresh-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:215 Invalid icon name system-help-symbolic found at ../pyanaconda/ui/gui/spokes/custom.glade:231 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/source.glade:1023 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/source.glade:1042 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:192 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:207 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:222 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:237 Invalid icon name input-keyboard-symbolic found at ../pyanaconda/ui/gui/spokes/keyboard.glade:253 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:275 Invalid icon name list-remove-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:289 Invalid icon name network-cellular-connected-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:1206 Invalid icon name dialog-password-symbolic found at ../pyanaconda/ui/gui/spokes/network.glade:2415 Invalid icon name list-add-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:10 Invalid icon name system-run-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:32 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:48 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:53 Invalid icon name go-down-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:58 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:282 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:287 Invalid icon name go-up-symbolic found at ../pyanaconda/ui/gui/spokes/datetime_spoke.glade:292
These are all part of gnome-icon-theme-symbolic. Do we need this installed as well (so I can update the PR) or using icons from this package is considered a bug ?
Thanks, Alex
anaconda-devel@lists.stg.fedoraproject.org