Handle invalid timezones in ks the same way as in RHEL 5.4: in case that the timezone is invalid, the system time of install environment will be set correctly if it is in tzdata package, and even if it is not there the ks install will proceed. This will prevent possible breaking of installs with kickstarts working in older versions of RHEL.
The question may be if we can/want to broaden valid timezones to all those present in tzdata package officialy (document it). Complete tzdata package is part of stage2 in Fedora and will be in RHEL 5.4. --- kickstart.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kickstart.py b/kickstart.py index 474ecec..ae6ae3a 100644 --- a/kickstart.py +++ b/kickstart.py @@ -881,8 +881,7 @@ class Timezone(commands.timezone.FC6_Timezone): tab = zonetab.ZoneTab() if self.timezone not in (entry.tz.replace(' ','_') for entry in tab.getEntries()): - log.warning("Timezone %s set in kickstart is not valid, will ask" % (self.timezone,)) - return retval + log.warning("Timezone %s set in kickstart is not valid." % (self.timezone,))
self.handler.id.timezone.setTimezoneInfo(self.timezone, self.isUtc) self.handler.skipSteps.append("timezone")
OK, looks good to me.
----- "Radek Vykydal" rvykydal@redhat.com wrote:
Handle invalid timezones in ks the same way as in RHEL 5.4: in case that the timezone is invalid, the system time of install environment will be set correctly if it is in tzdata package, and even if it is not there the ks install will proceed. This will prevent possible breaking of installs with kickstarts working in older versions of RHEL.
The question may be if we can/want to broaden valid timezones to all those present in tzdata package officialy (document it). Complete tzdata package is part of stage2 in Fedora and will be in RHEL 5.4.
kickstart.py | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kickstart.py b/kickstart.py index 474ecec..ae6ae3a 100644 --- a/kickstart.py +++ b/kickstart.py @@ -881,8 +881,7 @@ class Timezone(commands.timezone.FC6_Timezone): tab = zonetab.ZoneTab() if self.timezone not in (entry.tz.replace(' ','_') for entry in tab.getEntries()):
log.warning("Timezone %s set in kickstart is not valid,will ask" % (self.timezone,))
return retval
log.warning("Timezone %s set in kickstart is not valid."% (self.timezone,))
self.handler.id.timezone.setTimezoneInfo(self.timezone,self.isUtc) self.handler.skipSteps.append("timezone") -- 1.5.4.3
Anaconda-devel-list mailing list Anaconda-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/anaconda-devel-list
anaconda-devel@lists.stg.fedoraproject.org
-
Martin Sivak -
Radek Vykydal