On Thu, 18 Dec 2014, Dennis Gilmore wrote:
- -----BEGIN PGP SIGNED MESSAGE-----
*>* Hash: SHA1 *>>* On Thu, 18 Dec 2014 10:20:50 -0600 *>* Connie Sieh <csieh at fnal.gov https://admin.fedoraproject.org/mailman/listinfo/buildsys> wrote: *>>>* The pungi in git is clearly for Fedora. It can however be used for *>>* RHEL 7 but a few "patches" are needed for it to work. *>>>>* How would the patches best be put in pungi? There can be individual *>>* command line options added that enable/disable features. A example *>>* of this is there is no hfs support in RHEL 7 so a "nomacboot" command *>>* line option could be added to disable this. Another option is a *>>* single "rhel7" option that could cover all the rhel 7 patches. Which *>>* way would be best? *>>>>>>* The best way would be to add flags for the individual features. *>>* Dennis *>* -----BEGIN PGP SIGNATURE----- *>* Version: GnuPG v2 *> I have attached a patch for pungi 3.12.1 that provides a option "nomacboot". This command line option tells pungi to not include macboot in the compose. This is needed for EL7 as it does not provide HFS. The default has not been changed.
On Mon, Dec 29, 2014 at 11:14 AM, Troy Dawson yortnoswad@gmail.com wrote:
On Thu, 18 Dec 2014, Dennis Gilmore wrote:
- -----BEGIN PGP SIGNED MESSAGE-----
*>* Hash: SHA1 *>>* On Thu, 18 Dec 2014 10:20:50 -0600 *>* Connie Sieh <csieh at fnal.gov https://admin.fedoraproject.org/mailman/listinfo/buildsys> wrote: *>>>* The pungi in git is clearly for Fedora. It can however be used for *>>* RHEL 7 but a few "patches" are needed for it to work. *>>>>* How would the patches best be put in pungi? There can be individual *>>* command line options added that enable/disable features. A example *>>* of this is there is no hfs support in RHEL 7 so a "nomacboot" command *>>* line option could be added to disable this. Another option is a *>>* single "rhel7" option that could cover all the rhel 7 patches. Which *>>* way would be best? *>>>>>>* The best way would be to add flags for the individual features. *>>* Dennis *>* -----BEGIN PGP SIGNATURE----- *>* Version: GnuPG v2 *> I have attached a patch for pungi 3.12.1 that provides a option "nomacboot". This command line option tells pungi to not include macboot in the compose. This is needed for EL7 as it does not provide HFS. The default has not been changed.
-- Connie J. Sieh
Hi Connie,
This brings up a problem with the spec file.
For RHEL7 based distro's, there is only x86_64. If the default if for macboot to be turn on for x86_64, then the spec file needs to be updated to "Require: hfsplus-tools".
But, as you pointed out, RHEL7 doesn't provide HFS, so that's just silly.
Here is a modified patch, that instead of adding "nomacboot", sets macboot to false by default, and adds the option "macboot" to turn on macboot.
Thoughts.
Troy Dawson
OK, I'm going to give thoughts to my own thoughts. I know lots of people that put Fedora on Mac's. So changing the default of pungi would affect them, and that wouldn't be very nice. But it's my opinion that you need to have a "Requires" for everything that is needed by default. So I am suggesting using Connie's patch, and then have the following in the spec file.
%ifarch x86_64 Requires: hfsplus-tools %endif
Troy
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mon, 29 Dec 2014 15:00:37 -0600 Troy Dawson yortnoswad@gmail.com wrote:
On Mon, Dec 29, 2014 at 11:14 AM, Troy Dawson yortnoswad@gmail.com wrote:
On Thu, 18 Dec 2014, Dennis Gilmore wrote:
- -----BEGIN PGP SIGNED MESSAGE-----
*>* Hash: SHA1 *>>* On Thu, 18 Dec 2014 10:20:50 -0600 *>* Connie Sieh <csieh at fnal.gov https://admin.fedoraproject.org/mailman/listinfo/buildsys> wrote: *>>>* The pungi in git is clearly for Fedora. It can however be used for *>>* RHEL 7 but a few "patches" are needed for it to work. *>>>>* How would the patches best be put in pungi? There can be individual *>>* command line options added that enable/disable features. A example *>>* of this is there is no hfs support in RHEL 7 so a "nomacboot" command *>>* line option could be added to disable this. Another option is a *>>* single "rhel7" option that could cover all the rhel 7 patches. Which *>>* way would be best? *>>>>>>* The best way would be to add flags for the individual features. *>>* Dennis *>* -----BEGIN PGP SIGNATURE----- *>* Version: GnuPG v2 *> I have attached a patch for pungi 3.12.1 that provides a option "nomacboot". This command line option tells pungi to not include macboot in the compose. This is needed for EL7 as it does not provide HFS. The default has not been changed.
-- Connie J. Sieh
Hi Connie,
This brings up a problem with the spec file.
For RHEL7 based distro's, there is only x86_64. If the default if for macboot to be turn on for x86_64, then the spec file needs to be updated to "Require: hfsplus-tools".
But, as you pointed out, RHEL7 doesn't provide HFS, so that's just silly.
Here is a modified patch, that instead of adding "nomacboot", sets macboot to false by default, and adds the option "macboot" to turn on macboot.
Thoughts.
Troy Dawson
OK, I'm going to give thoughts to my own thoughts. I know lots of people that put Fedora on Mac's. So changing the default of pungi would affect them, and that wouldn't be very nice. But it's my opinion that you need to have a "Requires" for everything that is needed by default. So I am suggesting using Connie's patch, and then have the following in the spec file.
%ifarch x86_64 Requires: hfsplus-tools %endif
pungi is noarch so that is not a viable option at all.
Dennis
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mon, 29 Dec 2014 11:14:11 -0600 Troy Dawson yortnoswad@gmail.com wrote:
On Thu, 18 Dec 2014, Dennis Gilmore wrote:
- -----BEGIN PGP SIGNED MESSAGE-----
*>* Hash: SHA1 *>>* On Thu, 18 Dec 2014 10:20:50 -0600 *>* Connie Sieh <csieh at fnal.gov https://admin.fedoraproject.org/mailman/listinfo/buildsys> wrote: *>>>* The pungi in git is clearly for Fedora. It can however be used for *>>* RHEL 7 but a few "patches" are needed for it to work. *>>>>* How would the patches best be put in pungi? There can be individual *>>* command line options added that enable/disable features. A example *>>* of this is there is no hfs support in RHEL 7 so a "nomacboot" command *>>* line option could be added to disable this. Another option is a *>>* single "rhel7" option that could cover all the rhel 7 patches. Which *>>* way would be best? *>>>>>>* The best way would be to add flags for the individual features. *>>* Dennis *>* -----BEGIN PGP SIGNATURE----- *>* Version: GnuPG v2 *> I have attached a patch for pungi 3.12.1 that provides a option "nomacboot". This command line option tells pungi to not include macboot in the compose. This is needed for EL7 as it does not provide HFS. The default has not been changed.
I have it marked for review when i am back at work on January 8th
Dennis
buildsys@lists.fedoraproject.org
-
Dennis Gilmore -
Troy Dawson