It looks like maybe you didn't import a srpm. I am not at a computer to check but that seems like what is going on.

P.S. Sorry about the top posting. Sent from my Storm2

-----Original Message----- From: Thomas Guthmann tguthmann@iseek.com.au Sender: buildsys-bounces@lists.fedoraproject.org Date: Wed, 22 Sep 2010 11:20:03 To: buildsys@lists.fedoraproject.org Reply-To: Discussion of Fedora build system buildsys@lists.fedoraproject.org Subject: Re: [MASH/KOJI] what about imported RPMs without a build ?

On 09/22/2010 11:09 AM, Nathan Blackham wrote:

Did you tag the build?

No, because when I do it, I have the following mash error :

# koji tag-pkg repoX package-17.00-00 # mash repoX 2010-09-22 11:14:40 mash: Getting package lists for repoX... 2010-09-22 11:14:40 mash: Sorting packages... Traceback (most recent call last): File "/usr/bin/mash", line 97, in ? main() File "/usr/bin/mash", line 77, in main rc = themash.doCompose() File "/usr/lib/python2.4/site-packages/mash/__init__.py", line 339, in doCompose srcpkg = src_hash[pkg['build_id']] KeyError: 389 mash failed in /var/tmp/mash/visp

PS: I'm using mash 0.5.17 and koji 1.4.0

Cheers Thomas -- buildsys mailing list buildsys@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/buildsys

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 09/21/2010 08:00 PM, Thomas Guthmann wrote:

I imported a RPM already packaged by something else into koji. See http://fedoraproject.org/wiki/Koji/KojiMisc#Importing_an_rpm_without_srpm

If you aren't importing srpms, then you need to tweak the mash config to not attempt to gather srpms (if that's even possible). It is always preferable to import the srpms along with the rpms.

- -- Jesse Keating Fedora -- Freedom² is a feature! identi.ca: http://identi.ca/jkeating

Hi Bill,

There's already a config option for not doing source rpms... it perhaps needs wired through some more. If you have issues with that option set, please file a bug in bugzilla.

sources=false doesn't help. It is not used in this portion of the code (see snippet below). I've created a bug entry : https://bugzilla.redhat.com/show_bug.cgi?id=636697

---- src_hash = dict([(x['build_id'],x) for x in source.packages()]) excludearch = dict([(x['build_id'],'') for x in source.packages()]) exclusivearch = excludearch.copy() # Get excludearch/exclusivearch lists for noarch packages for pkg in noarch.packages(): srcpkg = src_hash[pkg['build_id']] <<<<< it dies here >>>>> self.logger.debug("Checking %s for Exclude/ExclusiveArch" % (nevra(pkg),)) fn = _get_reference(srcpkg, builds_hash) # if build has no source rpm, check the binary if fn == None: fn = _get_reference(pkg, builds_hash) try: hdr = koji.get_rpm_header(fn) except: self.logger.error("Couldn't read header from %s (%s)" % (nevra(pkg), fn)) if fn: fn.close() continue excludearch[pkg['build_id']] = hdr['EXCLUDEARCH'] exclusivearch[pkg['build_id']] = hdr['EXCLUSIVEARCH'] fn.close()

-----

Cheers, Thomas