So the CVS stuff handles %dist properly, which is good. Unfortunately the build system doesn't, which is not-so-good. Rather than leave the job half-done, I've come up with a patch that should fix it, which I've attached. It can be removed when the disttag changes go into redhat-rpm- config, but until then there's this.
On Tue, 2005-05-10 at 15:12 -0400, Ignacio Vazquez-Abrams wrote:
So the CVS stuff handles %dist properly, which is good. Unfortunately the build system doesn't, which is not-so-good. Rather than leave the job half-done, I've come up with a patch that should fix it, which I've attached. It can be removed when the disttag changes go into redhat-rpm- config, but until then there's this.
Why not have a buildsys-macros package we put in the buildgroups repository that puts this file in place in /etc?
that would mean we could update it w/o updating the buildsystem itself.
-sv
On Tue, 2005-05-10 at 16:34 -0400, seth vidal wrote:
On Tue, 2005-05-10 at 15:12 -0400, Ignacio Vazquez-Abrams wrote:
So the CVS stuff handles %dist properly, which is good. Unfortunately the build system doesn't, which is not-so-good. Rather than leave the job half-done, I've come up with a patch that should fix it, which I've attached. It can be removed when the disttag changes go into redhat-rpm- config, but until then there's this.
Why not have a buildsys-macros package we put in the buildgroups repository that puts this file in place in /etc?
that would mean we could update it w/o updating the buildsystem itself.
Sounds like a plan. Gimme a mo...
On Tue, 2005-05-10 at 17:15 -0400, Ignacio Vazquez-Abrams wrote:
On Tue, 2005-05-10 at 16:34 -0400, seth vidal wrote:
On Tue, 2005-05-10 at 15:12 -0400, Ignacio Vazquez-Abrams wrote:
So the CVS stuff handles %dist properly, which is good. Unfortunately the build system doesn't, which is not-so-good. Rather than leave the job half-done, I've come up with a patch that should fix it, which I've attached. It can be removed when the disttag changes go into redhat-rpm- config, but until then there's this.
Why not have a buildsys-macros package we put in the buildgroups repository that puts this file in place in /etc?
that would mean we could update it w/o updating the buildsystem itself.
Sounds like a plan. Gimme a mo...
http://fedora.ivazquez.net/files/buildsys-macros-1.0-1.src.rpm
Sounds like a plan. Gimme a mo...
http://fedora.ivazquez.net/files/buildsys-macros-1.0-1.src.rpm
I ended up using the buildsys-macros that spot sent. However, they didn't seem to do anything. I defined the system version for the package, built the package and I've checked to make sure they're in the chroots when the rpms get built but it doesn't seem to having the desired affect. Something I should be looking for to debug this? thanks, -sv
On Wed, 2005-05-11 at 10:30 -0400, seth vidal wrote:
I ended up using the buildsys-macros that spot sent. However, they didn't seem to do anything. I defined the system version for the package, built the package and I've checked to make sure they're in the chroots when the rpms get built but it doesn't seem to having the desired affect. Something I should be looking for to debug this?
I just updated to the latest mach and did some testing, and it seems that the file in /etc/mach/dist.d is pointing to buildgroups/$arch when it should be pointing to buildgroups/$version/$arch.
On Wed, 2005-05-11 at 11:38 -0400, Ignacio Vazquez-Abrams wrote:
On Wed, 2005-05-11 at 10:30 -0400, seth vidal wrote:
I ended up using the buildsys-macros that spot sent. However, they didn't seem to do anything. I defined the system version for the package, built the package and I've checked to make sure they're in the chroots when the rpms get built but it doesn't seem to having the desired affect. Something I should be looking for to debug this?
I just updated to the latest mach and did some testing, and it seems that the file in /etc/mach/dist.d is pointing to buildgroups/$arch when it should be pointing to buildgroups/$version/$arch.
no, that's not the problem. I had already fixed that on the build system's mach configuration. The buildsys-macro package IS getting installed - it's just not having any affect.
-sv
On Wed, 2005-05-11 at 13:51 -0400, seth vidal wrote:
On Wed, 2005-05-11 at 11:38 -0400, Ignacio Vazquez-Abrams wrote:
On Wed, 2005-05-11 at 10:30 -0400, seth vidal wrote:
I ended up using the buildsys-macros that spot sent. However, they didn't seem to do anything. I defined the system version for the package, built the package and I've checked to make sure they're in the chroots when the rpms get built but it doesn't seem to having the desired affect. Something I should be looking for to debug this?
I just updated to the latest mach and did some testing, and it seems that the file in /etc/mach/dist.d is pointing to buildgroups/$arch when it should be pointing to buildgroups/$version/$arch.
no, that's not the problem. I had already fixed that on the build system's mach configuration. The buildsys-macro package IS getting installed - it's just not having any affect.
Found the problem. The macros should be defined as:
%fedora $VERSION %dist .fc$VERSION
buildsys@lists.fedoraproject.org
-
Ignacio Vazquez-Abrams -
seth vidal