-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
An empty list of base classes wasn't allowed before Python 2.5 so remove it since it seems to be the only Python 2.5 feature being used.
What version of python are you taking as your minimum? If it's python2.2 then you'd be better off inheriting from object. Inheriting from object makes this a new-style class which has some features and behaviors that can make it superior to old-style classes.
Revised patch:
Index: pungi/pypungi/__init__.py =================================================================== - --- pungi.orig/pypungi/__init__.py +++ pungi/pypungi/__init__.py @@ -16,7 +16,7 @@ import logging import os import subprocess
- -class PungiBase(): +class PungiBase(object): """The base Pungi class. Set up config items and logging here"""
def __init__(self, config):
On Fri, 2007-08-31 at 09:24 -0700, Toshio Kuratomi wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
An empty list of base classes wasn't allowed before Python 2.5 so remove it since it seems to be the only Python 2.5 feature being used.
What version of python are you taking as your minimum? If it's python2.2 then you'd be better off inheriting from object. Inheriting from object makes this a new-style class which has some features and behaviors that can make it superior to old-style classes.
Yep, good point.
Cheers, Mark.
buildsys@lists.fedoraproject.org