Hi Bruno,
for your use case (I see you have a single shell test script in your pull request [1]) I would recommend to use the basic role:
https://docs.fedoraproject.org/en-US/ci/standard-test-roles/#_basic
It would take care of correctly copying artifacts and also handle test script return code to report appropriate result. Also adding a list of required packages is easy there. You can also have a look at a few more examples here:
https://docs.fedoraproject.org/en-US/ci/examples/
Hope this helps.
psss...
[1] https://src.fedoraproject.org/rpms/squashfs-tools/pull-request/5
On Wed, 22 May 2019 at 12:05, Bruno Wolff III bruno@wolff.to wrote:
On Wed, May 22, 2019 at 03:25:07 -0500, Bruno Wolff III bruno@wolff.to wrote:
On Tue, May 21, 2019 at 15:57:21 -0500, Bruno Wolff III bruno@wolff.to wrote:
I am trying to get a wrapped test script to work for squashfs-tools and the artifacts don't appear to be properly saved. I think I might be misunderstanding the wrapper example. Is the idea really that the test should run ansible with the basic role referring to the wrapper? I have been trying to run the wrapper as the test and it runs the shell script, but the test results don't end up where the CI can find them and the test fails.
It looks like the wrapper documentation is wrong about something. Artifacts don't seem to get copied back to where they are expected to be. I'm going to test if remote_artifacts is defined for the wrapper playbook. I'm guessing that only works if you explicitly use the base role. Then I'm going to try .., but I'm expecting that to be blocked by security checks.
I'm getting closer, but am getting close to done for the night.
It looks like test.log and results.yml need to get copied to ../../logs/ instead of {{ artifacts }}. It would be nice if a good way to add extra packages to the wrapper config existed. I'm using dnf -y --nogpgcheck in the command instead. I was a bit surprised the redirected outout from the command included a lot of set up and not just the output from my test script. I'm testing to see if parens can help that. I think I can make the test for squashfs-tools work. The last part is probably going to be figuring out why some mounts don't work. I may need kernel-modules-extra and in the process of testing that. But I'm pretty sure that's just a matter of figuring out what the missing package is. _______________________________________________ CI mailing list -- ci@lists.fedoraproject.org To unsubscribe send an email to ci-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org