On Wed, May 22, 2019 at 16:25:16 +0200, Petr Šplíchal psplicha@redhat.com wrote:
On Wed, 22 May 2019 at 14:55, Bruno Wolff III bruno@wolff.to wrote:
You could do something like this:
- hosts: localhost
roles:
- role: standard-test-basic tags:
tests:
- classic
- compression: dir: . run: "./Squashfs-compression-test.sh 2>&1 | tee /tmp/test.log && !
grep -iq failed /tmp/test.log" required_packages:
- kernel-modules-extra
- rpmdevtools
That's pretty close to what I was thinking and I may switch to it after I figure out what appears to be a missing required package. I also think I'll need to negate the gtrep test, but there is a way to do that that I've used in the past, but don't remember off hand.
Which looks much more concise.
I agree that it will be easier to understand. So I'll probably switch.
What exactly in the docs should cause the confusion? Should any of these pages be updated?
The wrapper stuff has you copying the log and results to {{ artifacts }}, which isn't correct. The correct location is ../../logs/ . I don't know if that is in a variable someplace. I figured it out by looking at the pipeline logs. It was very confusing trying to figure out what was going on and I wasted a fair amount of time before deciding the documentation must be wrong.
Including the "[citest]" string in a pull request comment does rerun all enabled tests.
I found that and it is useful, but not all builds come through pull requests. I'm not sure how the gate is connecting builds and tests. If it is by latest build of a commit, then redoing a pull test will work. But I forgot there is also a waive process, so worst case I can waive a test if need be.