Thanks for clarifying, Bruno. I've updated docs accordingly: https://pagure.io/fedora-ci/docs/c/a5aebfe
psss...
On Thu, 23 May 2019 at 15:16, Bruno Goncalves bgoncalv@redhat.com wrote:
On Wed, 22 May 2019 at 16:44, Bruno Wolff III <bruno(a)wolff.to> wrote:
This is weird. The "artifacts" variable should be set by the pipeline and thus using it instead of hardcoding some path used in the current implementation should be more reliable.
Bruno (Goncalves), could you please confirm that "artifacts" are correctly set in the Fedora pipeline? Thanks.
by artifacts you mean the TEST_ARTIFACTS variable as defined on [1]? the PR that we are talking about is [2]? If so, the ansible {{ artifacts }} variable is not defined in the playbook at all. The pipeline doesn't set it before running the playbook.
I believe Petr suggestion to use standard-test-basic role is the best, as it will save you the work on handling all these variables. But in case you want you want use your PR, I think you just need to set artifacts based on TEST_ARTIFACTS value. Like on [3].
[1] https://docs.fedoraproject.org/en-US/ci/standard-test-interface/#_invocation [2] https://src.fedoraproject.org/rpms/squashfs-tools/pull-request/4 [3] https://pagure.io/standard-test-roles/blob/master/f/roles/str-common-init/de...
psss...
Including the "[citest]" string in a pull request comment does rerun all enabled tests.
I found that and it is useful, but not all builds come through pull requests. I'm not sure how the gate is connecting builds and tests. If it is by latest build of a commit, then redoing a pull test will work. But I forgot there is also a waive process, so worst case I can waive a test if need be. _______________________________________________ CI mailing list -- ci(a)lists.fedoraproject.org To unsubscribe send an email to ci-leave(a)lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives:
https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org
CI mailing list -- ci@lists.fedoraproject.org To unsubscribe send an email to ci-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ci@lists.fedoraproject.org