cluster-commits January 2017

cluster-commits@lists.stg.fedorahosted.org

2 participants
22 discussions

gfs2-utils: master - gfs2-utils docs: Update some URLs
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=e36ee220cc… Commit: e36ee220cca09b7530d136c8aef578c24ef4339c Parent: 257347eca68964e0049ccee8f5d8b1f07664bcc0 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Fri Jan 27 10:46:38 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Fri Jan 27 10:46:38 2017 +0000 gfs2-utils docs: Update some URLs Signed-off-by: Andrew Price <anprice(a)redhat.com> --- doc/README.contributing | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/README.contributing b/doc/README.contributing index d669271..26ec77d 100644 --- a/doc/README.contributing +++ b/doc/README.contributing @@ -6,9 +6,9 @@ Here are some brief guidelines to follow when contributing to gfs2-utils. Translations ------------ -We use the Transifex translation service: +We use the Zanata translation service: - https://transifex.com/projects/p/gfs2-utils/ + https://fedora.zanata.org/project/view/gfs2-utils See the documentation there for submitting translations. @@ -25,7 +25,7 @@ We use git for managing our source code and we assume here that you're familiar with git. Patches should apply cleanly to the latest master branch of gfs2-utils.git - http://git.fedorahosted.org/cgit/gfs2-utils.git + https://pagure.io/gfs2-utils For ease of review and maintenance each of your patches should address a single issue and if there are multiple issues please consider spreading your work over

1 0

gfs2-utils: master - gfs2-utils README: List libuuid as a dependency
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=257347eca6… Commit: 257347eca68964e0049ccee8f5d8b1f07664bcc0 Parent: ca2fd6091834d7e13c9e4c0650f157b21a420074 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Thu Jan 26 20:00:52 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Thu Jan 26 20:00:52 2017 +0000 gfs2-utils README: List libuuid as a dependency ...and tweak the wording of the optional 'check' dependency. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- README | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/README b/README index e8ab577..a04653f 100644 --- a/README +++ b/README @@ -20,7 +20,8 @@ The following development packages are required to build gfs2-utils: o flex o zlib o libblkid - o check (optional, enables the test suite) + o libuuid + o check (optional, enables unit tests) The kernel header include/linux/gfs2-ondisk.h and its dependencies are also required. @@ -50,6 +51,7 @@ gfs2-utils requires the following libraries: o zlib o ncurses o libblkid + o libuuid To install gfs2-utils, run:

1 0

gfs2-utils: master - gfs2-utils tests: Add tests for device topology handling in mkfs.gfs2
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=ca2fd60918… Commit: ca2fd6091834d7e13c9e4c0650f157b21a420074 Parent: 40efc958acc8a101394d1d0ec7975096fd0d9be4 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Thu Jan 26 16:33:51 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Thu Jan 26 16:33:51 2017 +0000 gfs2-utils tests: Add tests for device topology handling in mkfs.gfs2 Add some tests that exercise mkfs.gfs2 against various device i/o limits based on odd values seen in the wild. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- tests/mkfs.at | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tests/mkfs.at b/tests/mkfs.at index d3521c8..c026a76 100644 --- a/tests/mkfs.at +++ b/tests/mkfs.at @@ -101,3 +101,11 @@ AT_CHECK([$GFS_MKFS -p lock_dlm -t "quite_long_cluster_name_test_here:intec34p" AT_CHECK([$GFS_MKFS -p lock_dlm -t "financial_cluster:this_time_we_test_fs_naming_len" $GFS_TGT], 255, [ignore], [ignore]) GFS_FSCK_CHECK([$GFS_MKFS -p lock_dlm -t "a_really_long_named_cluster_here:concurrently_lets_check_fs_len" $GFS_TGT]) AT_CLEANUP + +AT_SETUP([Device i/o limits handling]) +AT_KEYWORDS(mkfs.gfs2 mkfs) +AT_CHECK([$GFS_MKFS -p lock_nolock -o test_topology=0:0:0:0:0 $GFS_TGT], 0, [ignore], [ignore]) +AT_CHECK([$GFS_MKFS -p lock_nolock -o test_topology=7168:512:0:33553920:512 $GFS_TGT], 0, [ignore], [ignore]) +AT_CHECK([$GFS_MKFS -p lock_nolock -o test_topology=7168:512:8192:33553920:512 $GFS_TGT], 0, [ignore], [Warning: device is not properly aligned. This may harm performance. +]) +AT_CLEANUP

1 0

gfs2-utils: master - mkfs.gfs2: Disregard device topology if zero-sized sectors reported
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=40efc958ac… Commit: 40efc958acc8a101394d1d0ec7975096fd0d9be4 Parent: 85821484421fde65b127eef81eea71a6e719b892 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Thu Jan 26 16:29:21 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Thu Jan 26 16:29:21 2017 +0000 mkfs.gfs2: Disregard device topology if zero-sized sectors reported Guard against physical_sector_size or logical_sector_size being zero. Normally this isn't a problem as the kernel will report these values as the device sector size but the checks are useful for when zero values are passed to mkfs. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- gfs2/mkfs/main_mkfs.c | 16 ++++++++++------ 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c index e2c4a22..0801a4b 100644 --- a/gfs2/mkfs/main_mkfs.c +++ b/gfs2/mkfs/main_mkfs.c @@ -136,6 +136,7 @@ struct mkfs_opts { unsigned got_lockproto:1; unsigned got_locktable:1; unsigned got_device:1; + unsigned got_topol:1; unsigned override:1; unsigned quiet:1; @@ -304,7 +305,8 @@ static void opt_parse_extended(char *str, struct mkfs_opts *opts) } else if (strcmp("test_topology", key) == 0) { if (parse_topology(opts, val) != 0) exit(-1); - opts->dev.got_topol = 1; + opts->got_topol = (opts->dev.logical_sector_size != 0 && + opts->dev.physical_sector_size != 0); } else if (strcmp("help", key) == 0) { print_ext_opts(); exit(0); @@ -487,20 +489,21 @@ static unsigned choose_blocksize(struct mkfs_opts *opts) unsigned int x; unsigned int bsize = opts->bsize; struct mkfs_dev *dev = &opts->dev; + int got_topol = (dev->got_topol || opts->got_topol); - if (dev->got_topol && opts->debug) { + if (got_topol && opts->debug) { printf("alignment_offset: %lu\n", dev->alignment_offset); printf("logical_sector_size: %lu\n", dev->logical_sector_size); printf("minimum_io_size: %lu\n", dev->minimum_io_size); printf("optimal_io_size: %lu\n", dev->optimal_io_size); printf("physical_sector_size: %lu\n", dev->physical_sector_size); } - if (dev->got_topol && dev->alignment_offset != 0) { + if (got_topol && dev->alignment_offset != 0) { fprintf(stderr, _("Warning: device is not properly aligned. This may harm performance.\n")); dev->physical_sector_size = dev->logical_sector_size; } - if (!opts->got_bsize && dev->got_topol) { + if (!opts->got_bsize && got_topol) { if (dev->optimal_io_size <= getpagesize() && dev->optimal_io_size >= dev->minimum_io_size) bsize = dev->optimal_io_size; @@ -887,7 +890,8 @@ static int probe_contents(struct mkfs_dev *dev) dev->minimum_io_size = blkid_topology_get_minimum_io_size(tp); dev->optimal_io_size = blkid_topology_get_optimal_io_size(tp); dev->physical_sector_size = blkid_topology_get_physical_sector_size(tp); - dev->got_topol = 1; + dev->got_topol = (dev->logical_sector_size != 0 && + dev->physical_sector_size != 0); } } @@ -944,7 +948,7 @@ int main(int argc, char *argv[]) opts_get(argc, argv, &opts); opts_check(&opts); - open_dev(&opts.dev, !opts.dev.got_topol); + open_dev(&opts.dev, !opts.got_topol); bsize = choose_blocksize(&opts); if (S_ISREG(opts.dev.stat.st_mode)) {

1 0

gfs2-utils: master - mkfs.gfs2: Disable rgrp alignment when dev topology is unsuitable
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=8582148442… Commit: 85821484421fde65b127eef81eea71a6e719b892 Parent: 7e55c059388c25cd6e3c22e1c6ac9af5519f1dc3 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Thu Jan 26 11:05:42 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Thu Jan 26 15:29:45 2017 +0000 mkfs.gfs2: Disable rgrp alignment when dev topology is unsuitable If optimal_io_size is not a multiple of minimum_io_size then the values are not reliable swidth and sunit values, so disable rgrp stripe alignment in that case. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- gfs2/mkfs/main_mkfs.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c index db83d1c..e2c4a22 100644 --- a/gfs2/mkfs/main_mkfs.c +++ b/gfs2/mkfs/main_mkfs.c @@ -629,8 +629,14 @@ static lgfs2_rgrps_t rgs_init(struct mkfs_opts *opts, struct gfs2_sbd *sdp) al_off = opts->sunit / sdp->bsize; } } else if (opts->align) { - if ((opts->dev.minimum_io_size > opts->dev.physical_sector_size) && - (opts->dev.optimal_io_size > opts->dev.physical_sector_size)) { + if (opts->dev.optimal_io_size <= opts->dev.physical_sector_size || + opts->dev.minimum_io_size <= opts->dev.physical_sector_size || + (opts->dev.optimal_io_size % opts->dev.minimum_io_size) != 0) { + /* If optimal_io_size is not a multiple of minimum_io_size then + the values are not reliable swidth and sunit values, so disable + rgrp alignment */ + opts->align = 0; + } else { al_base = opts->dev.optimal_io_size / sdp->bsize; al_off = opts->dev.minimum_io_size / sdp->bsize; }

1 0

gfs2-utils: master - mkfs.gfs2: Warn when device is misaligned
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=7e55c05938… Commit: 7e55c059388c25cd6e3c22e1c6ac9af5519f1dc3 Parent: d9c696542df0af5aa57d5a89cc3a487bf651fa14 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Wed Jan 25 14:02:48 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Wed Jan 25 14:02:48 2017 +0000 mkfs.gfs2: Warn when device is misaligned Normally one layer of the I/O stack will adjust for a non-zero alignment_offset value and expose it to upper layers as zero. If a misalignment is not accounted for, mkfs.gfs2 will see a non-zero alignment_offset and should report the misalignment to the user as it could harm performance. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- gfs2/mkfs/main_mkfs.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c index a2d2ba9..db83d1c 100644 --- a/gfs2/mkfs/main_mkfs.c +++ b/gfs2/mkfs/main_mkfs.c @@ -495,7 +495,11 @@ static unsigned choose_blocksize(struct mkfs_opts *opts) printf("optimal_io_size: %lu\n", dev->optimal_io_size); printf("physical_sector_size: %lu\n", dev->physical_sector_size); } - + if (dev->got_topol && dev->alignment_offset != 0) { + fprintf(stderr, + _("Warning: device is not properly aligned. This may harm performance.\n")); + dev->physical_sector_size = dev->logical_sector_size; + } if (!opts->got_bsize && dev->got_topol) { if (dev->optimal_io_size <= getpagesize() && dev->optimal_io_size >= dev->minimum_io_size)

1 0

gfs2-utils: master - mkfs.gfs2: Add an extended option for device topology testing
by Andrew Price 27 Jan '17

27 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=d9c696542d… Commit: d9c696542df0af5aa57d5a89cc3a487bf651fa14 Parent: 2e0c08d53e44a4a053a47482e0035e42144f74bb Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Wed Jan 25 08:44:44 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Wed Jan 25 08:44:44 2017 +0000 mkfs.gfs2: Add an extended option for device topology testing This adds an -o test_topology=v1:v2:v3:v4:v5 extended option which can be used to test how mkfs.gfs2 behaves with different device characteristics. The values it accepts correspond to: 1. alignment_offset 2. logical_sector_size 3. minimum_io_size 4. optimal_io_size 5. physical_sector_size Signed-off-by: Andrew Price <anprice(a)redhat.com> --- gfs2/mkfs/main_mkfs.c | 39 ++++++++++++++++++++++++++++++++++----- 1 files changed, 34 insertions(+), 5 deletions(-) diff --git a/gfs2/mkfs/main_mkfs.c b/gfs2/mkfs/main_mkfs.c index 363878c..a2d2ba9 100644 --- a/gfs2/mkfs/main_mkfs.c +++ b/gfs2/mkfs/main_mkfs.c @@ -256,6 +256,33 @@ static unsigned parse_bool(struct mkfs_opts *opts, const char *key, const char * exit(-1); } +static int parse_topology(struct mkfs_opts *opts, char *str) +{ + char *opt; + unsigned i = 0; + unsigned long *topol[5] = { + &opts->dev.alignment_offset, + &opts->dev.logical_sector_size, + &opts->dev.minimum_io_size, + &opts->dev.optimal_io_size, + &opts->dev.physical_sector_size + }; + + while ((opt = strsep(&str, ":")) != NULL) { + if (i > 4) { + fprintf(stderr, "Too many topology values.\n"); + return 1; + } + *topol[i] = parse_ulong(opts, "test_topology", opt); + i++; + } + if (i < 5) { + fprintf(stderr, "Too few topology values.\n"); + return 1; + } + return 0; +} + static void opt_parse_extended(char *str, struct mkfs_opts *opts) { char *opt; @@ -274,6 +301,10 @@ static void opt_parse_extended(char *str, struct mkfs_opts *opts) opts->got_swidth = 1; } else if (strcmp("align", key) == 0) { opts->align = parse_bool(opts, "align", val); + } else if (strcmp("test_topology", key) == 0) { + if (parse_topology(opts, val) != 0) + exit(-1); + opts->dev.got_topol = 1; } else if (strcmp("help", key) == 0) { print_ext_opts(); exit(0); @@ -854,7 +885,7 @@ static int probe_contents(struct mkfs_dev *dev) return 0; } -static void open_dev(struct mkfs_dev *dev) +static void open_dev(struct mkfs_dev *dev, int withprobe) { int error; @@ -882,9 +913,7 @@ static void open_dev(struct mkfs_dev *dev) fprintf(stderr, _("'%s' is not a block device or regular file\n"), dev->path); exit(1); } - - error = probe_contents(dev); - if (error) + if (withprobe && (probe_contents(dev) != 0)) exit(1); } @@ -905,7 +934,7 @@ int main(int argc, char *argv[]) opts_get(argc, argv, &opts); opts_check(&opts); - open_dev(&opts.dev); + open_dev(&opts.dev, !opts.dev.got_topol); bsize = choose_blocksize(&opts); if (S_ISREG(opts.dev.stat.st_mode)) {

1 0

gfs2-utils: master - gfs2-utils: README file improvements
by Andrew Price 20 Jan '17

20 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=2e0c08d53e… Commit: 2e0c08d53e44a4a053a47482e0035e42144f74bb Parent: e3dd91be030cfb6c473e4b1cce2dc32df9e7ab4f Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Fri Jan 20 11:39:59 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Fri Jan 20 11:39:59 2017 +0000 gfs2-utils: README file improvements Add some introductory text, split the info into sections, separate the build requirements from the installation requirements and generally tidy up. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- README | 72 ++++++++++++++++++++++++++++++++++++++++++++------------------- 1 files changed, 50 insertions(+), 22 deletions(-) diff --git a/README b/README index d0a21c3..e8ab577 100644 --- a/README +++ b/README @@ -1,41 +1,69 @@ +gfs2-utils +---------- -To build this source tree, you will need: +This package contains the tools needed to create, check, manipulate and analyze +gfs2 filesystems, along with important scripts required to support gfs2 +clusters. - - automake - - GNU make - - GCC tool chain +Build instructions +------------------ -Plus the following libraries: +The following development packages are required to build gfs2-utils: - ncurses (for gfs2_edit) - gettext - bison - flex - zlib - libblkid - check (optional, enables the test suite) + o autoconf + o automake + o libtool + o GNU make + o ncurses + o gettext + o bison + o flex + o zlib + o libblkid + o check (optional, enables the test suite) + +The kernel header include/linux/gfs2-ondisk.h and its dependencies are also +required. To build gfs2-utils, run the following commands: - ./autogen.sh - ./configure - make + $ ./autogen.sh + $ ./configure + $ make + +See ./configure --help for more build configuration options. + +Test Suite +---------- + +To run the test suite, use: -To run the test suite: + $ make check - make check +See doc/README.tests for more details regarding the test suite. + +Installation +------------ + +gfs2-utils requires the following libraries: + + o zlib + o ncurses + o libblkid To install gfs2-utils, run: - make install + # make install + +Support scripts +--------------- The following scripts (located in gfs2/scripts) are used to complete the userland portion of the gfs2 withdraw feature using uevents. They will be installed by 'make install' to these directories by default: - 82-gfs2-withdraw.rules in /usr/lib/udev/rules.d/ - gfs2_withdraw_helper in /usr/sbin/ + 82-gfs2-withdraw.rules in /usr/lib/udev/rules.d/ + gfs2_withdraw_helper in /usr/sbin/ -See also doc/README.contributing for details on submitting patches and -doc/README.tests for more details regarding the test suite. +See also doc/README.contributing for details on submitting patches.

1 0

gfs2-utils: master - gfs2-utils: Rename README.build to README
by Andrew Price 20 Jan '17

20 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=e3dd91be03… Commit: e3dd91be030cfb6c473e4b1cce2dc32df9e7ab4f Parent: 4fb1a4732e74d9d2de46ee31e1bbdf674908d261 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Fri Jan 20 11:14:03 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Fri Jan 20 11:14:03 2017 +0000 gfs2-utils: Rename README.build to README As there's only one README file in this directory it can just be called README and contain the small amount of various info that needs to be read. Removing the .build extension will also make Pagure render the file as preformatted text. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- Makefile.am | 2 +- README | 41 +++++++++++++++++++++++++++++++++++++++++ README.build | 41 ----------------------------------------- 3 files changed, 42 insertions(+), 42 deletions(-) diff --git a/Makefile.am b/Makefile.am index 1c4f8ae..adeb56d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -EXTRA_DIST = autogen.sh README.build +EXTRA_DIST = autogen.sh README AUTOMAKE_OPTIONS = foreign diff --git a/README b/README new file mode 100644 index 0000000..d0a21c3 --- /dev/null +++ b/README @@ -0,0 +1,41 @@ + +To build this source tree, you will need: + + - automake + - GNU make + - GCC tool chain + +Plus the following libraries: + + ncurses (for gfs2_edit) + gettext + bison + flex + zlib + libblkid + check (optional, enables the test suite) + +To build gfs2-utils, run the following commands: + + ./autogen.sh + ./configure + make + +To run the test suite: + + make check + +To install gfs2-utils, run: + + make install + +The following scripts (located in gfs2/scripts) are used to complete +the userland portion of the gfs2 withdraw feature using uevents. They +will be installed by 'make install' to these directories by default: + + 82-gfs2-withdraw.rules in /usr/lib/udev/rules.d/ + gfs2_withdraw_helper in /usr/sbin/ + +See also doc/README.contributing for details on submitting patches and +doc/README.tests for more details regarding the test suite. + diff --git a/README.build b/README.build deleted file mode 100644 index d0a21c3..0000000 --- a/README.build +++ /dev/null @@ -1,41 +0,0 @@ - -To build this source tree, you will need: - - - automake - - GNU make - - GCC tool chain - -Plus the following libraries: - - ncurses (for gfs2_edit) - gettext - bison - flex - zlib - libblkid - check (optional, enables the test suite) - -To build gfs2-utils, run the following commands: - - ./autogen.sh - ./configure - make - -To run the test suite: - - make check - -To install gfs2-utils, run: - - make install - -The following scripts (located in gfs2/scripts) are used to complete -the userland portion of the gfs2 withdraw feature using uevents. They -will be installed by 'make install' to these directories by default: - - 82-gfs2-withdraw.rules in /usr/lib/udev/rules.d/ - gfs2_withdraw_helper in /usr/sbin/ - -See also doc/README.contributing for details on submitting patches and -doc/README.tests for more details regarding the test suite. -

1 0

gfs2-utils: master - gfs2-utils tests: Re-enable a fsck.gfs2 test
by Andrew Price 18 Jan '17

18 Jan '17

Gitweb: http://git.fedorahosted.org/git/?p=gfs2-utils.git;a=commitdiff;h=4fb1a4732e… Commit: 4fb1a4732e74d9d2de46ee31e1bbdf674908d261 Parent: e6bb3d27cd08c50f04825f5873023d19534c5fe6 Author: Andrew Price <anprice(a)redhat.com> AuthorDate: Wed Jan 18 16:50:11 2017 +0000 Committer: Andrew Price <anprice(a)redhat.com> CommitterDate: Wed Jan 18 16:50:11 2017 +0000 gfs2-utils tests: Re-enable a fsck.gfs2 test This test now passes. Signed-off-by: Andrew Price <anprice(a)redhat.com> --- tests/fsck.at | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/fsck.at b/tests/fsck.at index 5e49985..b9953fb 100644 --- a/tests/fsck.at +++ b/tests/fsck.at @@ -20,10 +20,10 @@ AT_KEYWORDS(fsck.gfs2 fsck) GFS_NUKERG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [-r 0]) AT_CLEANUP -#AT_SETUP([Fix bad resource group #1]) -#AT_KEYWORDS(fsck.gfs2 fsck) -#GFS_NUKERG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [-r 1]) -#AT_CLEANUP +AT_SETUP([Fix bad resource group #1]) +AT_KEYWORDS(fsck.gfs2 fsck) +GFS_NUKERG_CHECK([mkfs.gfs2 -O -p lock_nolock $GFS_TGT], [-r 1]) +AT_CLEANUP #AT_SETUP([Fix bad rindex entry #0]) #AT_KEYWORDS(fsck.gfs2 fsck)

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

cluster-commits January 2017