disable networking in Copr by default

List overview All Threads
Download

newer

older

[PATCH] [backend] don't traceback...

Removal of F21 chroots

Pavel Raiskup

11 May 2015 11 May '15

8:21 a.m.

Just to be more pedantic and probably bit more secure, what about making networking in copr opt-in (at least for new projects)?

If build of my package used internet arbitrarily, I would be warned very early..

Also, in Koji we also do not have networking, so we can faster teach (future) Fedora packagers.

Thanks for considering, Pavel

Show replies by date

Greg Sheremeta

11 May 11 May

4:03 p.m.

New subject: disablenetworkinginCoprbydefault

+1.

----- Original Message -----

...

From: "Pavel Raiskup" praiskup@redhat.com To: "copr" copr-devel@lists.fedorahosted.org Sent: Monday, May 11, 2015 9:21:33 AM Subject: disable networking in Copr by default

Just to be more pedantic and probably bit more secure, what about making networking in copr opt-in (at least for new projects)?

If build of my package used internet arbitrarily, I would be warned very early..

Also, in Koji we also do not have networking, so we can faster teach (future) Fedora packagers.

Thanks for considering, Pavel

copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel

Pavel Raiskup

7 Jan 7 Jan

5:30 a.m.

New subject: [PATCH][frontend]disableinternetconnectionbydefault

Users are always able to turn the internet connection ON, but only when *necessary*. This should be good default safety belt for unintentional downloads during package-build which could compromise build results. This should affect only newly created projects. --- frontend/coprs_frontend/coprs/forms.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/coprs_frontend/coprs/forms.py b/frontend/coprs_frontend/coprs/forms.py index 11bcbc4..b42f030 100644 --- a/frontend/coprs_frontend/coprs/forms.py +++ b/frontend/coprs_frontend/coprs/forms.py @@ -210,7 +210,7 @@ class CoprFormFactory(object): filters=[StringListFilter()])

disable_createrepo = wtforms.BooleanField(default=False) - build_enable_net = wtforms.BooleanField(default=True) + build_enable_net = wtforms.BooleanField(default=False)

@property def selected_chroots(self):

-- 2.5.0

Miroslav Suchý

8:27 a.m.

New subject: [PATCH][frontend]disableinternetconnectionbydefault

Dne 7.1.2016 v 12:30 Pavel Raiskup napsal(a):

...

Users are always able to turn the internet connection ON, but only when *necessary*. This should be good default safety belt for unintentional downloads during package-build which could compromise build results. This should affect only newly created projects.

Pushed as * d0dcf9f (HEAD -> master, origin/master, origin/HEAD) disable internet connection by default

Thank you.

-- Miroslav Suchy, RHCA Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys

3688

Age (days ago)

3929

Last active (days ago)

copr-devel@lists.stg.fedorahosted.org

3 comments

3 participants

tags (0)

participants (3)

Greg Sheremeta
Miroslav Suchý
Pavel Raiskup