Re: [ABRT PATCH] dbus: Ensure we're linked to GObject
It turned out that this patch is not necessary because the problem was caused
by old glib2 installed.
As we don't want to add GLib version to Requires, a patch which will add some
runtime check would be much better. GLib provides glib_check_version() for
this purpose.
On Tuesday, March 26, 2013 04:25:48 PM Jakub Filak wrote:
- see https://bugzilla.gnome.org/show_bug.cgi?id=691077
- closes rhbz#927919
Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
---
src/dbus/abrt-dbus.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/dbus/abrt-dbus.c b/src/dbus/abrt-dbus.c
index 9d7f1ff..5389753 100644
--- a/src/dbus/abrt-dbus.c
+++ b/src/dbus/abrt-dbus.c
@@ -894,7 +894,15 @@ int main(int argc, char *argv[])
error_msg_and_die(_("This program must be run as root."));
#if (GLIB_MAJOR_VERSION == 2 && GLIB_MINOR_VERSION < 35)
+ /* Became deprecated in glib-2.35.1 (branch 2.36 commit
df02fa1e4cc61a2c7f3aafdf1a6534a831f1c0d6) */ g_type_init();
+#else
+ /* Be defensive and ensure we're linked to GObject
+ * https://bugzilla.gnome.org/show_bug.cgi?id=691077
+ *
+ * See glib README -> Notes about GLib 2.36, 1st paragraph
+ */
+ g_type_ensure(G_TYPE_OBJECT);
#endif
/* We are lazy here - we don't want to manually provide