On 08/02/2011 02:36 PM, Denys Vlasenko wrote:
On Fri, 2011-07-22 at 13:37 +0200, Miroslav Lichvar wrote:
> +#define parse_report_result libreport_parse_report_result
> +struct report_result *parse_report_result(const char *text);
I object to committing to git of interfaces without users.
- this is actually my fault, I asked Mirek to push it, as mine changes
in the gui will use it - but I got overwhelmed by other problems, so I
didn't get to it. The idea is to be able to parser report_to and show it
in gui in some usable (clickable) way.
I mean: if you need this function for something, then add
this function and immediately add the code which uses it.
These can be two separate commits (in fact, it is preferred
to have them as separate commits), but they should be
committed together, say, during same day.
Otherwise, we end up with the state when we have unused API
in the tree.
If the code which uses your new function is not ready,
postpone its inclusion into the tree. Maybe you will need
to change the API. Maybe you will find out that function
is not needed after all.
Today's git has unused parse_report_result(), and string_iso_date()
is used only by this unused function, thus it is also dead code.
Another example is cmp_problem_data() function added on July 27
by Nikola. Still as of today, no users in the tree.