On 01/15/2010 05:43 PM, Denys Vlasenko wrote:
An idea I want to discuss
With recent reorganization of "Enabled" directive, there is
one bug left: it is impossible to configure settings
for non-loaded plugin - [Configure plugin] button is grayed out
Here is why:
we determine whether a plugin has configure dialog by looking
at plugin_info["GTKBuilder"], if it is != "", then we load that file
and we have a GUI dialog.
Problem is, a non-loaded plugin always has plugin_info["GTKBuilder"] ==
(1) move lib/Plugins/*.GTKBuilder to src/GUI/
(2) do not check plugin_info["GTKBuilder"] (in fact, we can nuke it
(3) instead, just check whether<plugin_name>.GTKBuilder file exists
Step (3) works even for non-loaded plugins.
Any thoughts why it might be a bad idea?
I was thinking about something similar. But instead of making gui search
and load every .GtkBuilder file we can add some simple plugin support to
gui, so then every abrt plugin which have a config dialog will ship
GtkBuilder file + a python script (gui plugin) to handle it's own config
dialog. This would help with implementing sanity checks on client side
(e.g. now we're checking only if BZ pass and login isn't empty).