On Thu, May 23, 2013 at 12:20:25 +0200, Nikola Pajkovsky wrote:
Martin Milata <mmilata(a)redhat.com> writes:
> This behaviour prevented satyr from generating uReports for e.g. python
> Signed-off-by: Martin Milata <mmilata(a)redhat.com>
> lib/abrt.c | 22 ++++++++++------------
> 1 file changed, 10 insertions(+), 12 deletions(-)
you know that, you've made it more complicated to read.
What exactly? I'd be happy to send a better patch but I have no idea
what are you referring to. Not saying that you should rewrite it
yourself, but you can at least give a hint what a better solution
might look like.
> diff --git a/lib/abrt.c b/lib/abrt.c
> index ae01ab9..682eed7 100644
> --- a/lib/abrt.c
> +++ b/lib/abrt.c
> @@ -221,23 +221,21 @@ sr_abrt_rpm_packages_from_dir(const char *directory,
> char *dso_list_contents = file_contents(directory, "dso_list",
here you get one content of file. It's not plural. You don't get
multiple contents of one file. so file_contents() name doesn't make any
I don't think so -- according to [1,2], content as in "something that is
contained" is usually written in plural.