On 12/04/2009 06:16 PM, Denys Vlasenko wrote:
Basically, I am making "label" act as a multi-line
text field with all log lines, not the storage
for only the last line.
I would rather use some textview and make it into separate log window. I
think the label shouldn't be used that way.
I think I need to add a close button there,
and need to hide the progress bar when it's not needed.
Maybe even get rid of it, log lines provide more realistic
indication that we have some progress (or haven't!)
Progress bar was request from users so I wouldn't remove it.
Also, maybe need to create one window per report,
so that different reports do not mix log windows
Good idea, I think we can use the job id to identify the messages for
For now, I tried to just disable hide ops in the source.
Does not look too nice when I run it, but demonstrates
Perhaps we do need to hide it on success, but need to save
the log and add another button [Log] to the appearing
report window, to make it possible for user
to resurrect the log window and see the log text again.
Definitely hide on succes.
On error, we do not hide it, but let user see the log.
This is basically the motivation behind this patch -
if error happens, currently user sees only last line -
NOT useful in many cases.
I would just show some exclamation mark in the progress window with some
text saying: "there were some problems generating the backtrace, click
here to see the details".
Please try the patch, feel free to make it usable.