Cronie-devel November 2012

cronie-devel@lists.stg.fedorahosted.org

5 participants
6 discussions

[PATCH] Fix documentation issues
by Michael Laß 26 Nov '12

26 Nov '12

Fix some issues introduced in c58b1d9 Documentation improvements based on Michael Lass suggestions. * give -m an own line in manpage * don't explain -P twice * correct description of -P to what it actually does Signed-off-by: Michael Laß <bevan(a)bi-co.net> --- man/cron.8 | 6 ++---- src/cron.c | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/man/cron.8 b/man/cron.8 index 3e3520a..db9060b 100644 --- a/man/cron.8 +++ b/man/cron.8 @@ -141,6 +141,7 @@ Prints a help message and exits. .TP .B "\-i" Disables inotify support. +.TP .B "\-m" This option allows you to specify a shell command to use for sending .I Cron @@ -163,7 +164,7 @@ Allows to accept any user set crontables. .TP .B "\-P" -Change PATH. +Don't set PATH. PATH is instead inherited from the environment. .TP .B "\-c" This option enables clustering support, as described below. @@ -179,9 +180,6 @@ installed or if mail is disabled. .TP .B "\-x" This option allows you to set debug flags. -.TP -.B "\-P" -Don't set PATH. PATH is instead inherited from the environment. .SH SIGNALS When the .I SIGHUP diff --git a/src/cron.c b/src/cron.c index 08e164d..c57b33f 100644 --- a/src/cron.c +++ b/src/cron.c @@ -179,7 +179,7 @@ static void usage(void) { [-m <mail command>] off or specify prefered client for sending mails \n \ [-n] run in foreground \n \ [-p] permit any crontab \n \ - [-P] change PATH \n \ + [-P] don't set PATH \n \ [-c] enable clustering support \n \ [-s] log into syslog instead of sending mails \n \ [-x [", -- 1.8.0.1

1 0

[PATCH 00/17] pull: subsequent patches are also available from my git
by Sami Kerola 26 Nov '12

26 Nov '12

The following patches that follow this pull request are the same as in my remote repository. They are sent to mail list so that there is a public review of each patch. The patch 0001 is a fix to change I sent earlier, and that was found to be rubbish. Rest of the patches are mostly about build-sys, compliancy, etc non-feature patches. Closes to a feature is introduction of '--with-editor' configure option, that allows user to define default editor. The last four patches are the same manual changes I sent ealier, which you need to be aware if you merge the remote repository and had them already applied from email stream. Please have a look, and even if you are not a maintainer of this project let me know if something in these changes look wrong. The following changes since commit 0fb0c68fd71347b2115024c311175305f1517296: Minor release 1.4.9. (2012-11-22 15:07:59 +0100) are available in the git repository at: git://github.com/kerolasa/cronie.git 2012wk47 for you to fetch changes up to ef14824c6a7500d1809b242aaf2c5da457386e0a: docs: anacron fix out dated information about open file limits (2012-11-25 12:16:22 +0000) ---------------------------------------------------------------- Sami Kerola (17): messaging: remove start up error about sendmail when it is not in use build-sys: add autotools helper script build-sys: make clean needs to remove cron-paths.h compliancy: use memset() rather than bzero() assingments: remove initialization if value is never used clean up: reduce variable passing when they are not used compliancy: do not mix declarations and code build-sys: reduce selinux and pam compiling scope when possible variables: use const where ever possible includes: make inclusions clean declarations: fix shadow declarations debuging: make Debug macro look like function coding style: reindent all *.c files build-sys: make ./configure to seach vi path docs: fix various groff issues docs: fix reference to other manual docs: anacron fix out dated information about open file limits autogen.sh | 29 +++++ configure.ac | 9 ++ man/anacron.8 | 242 +++++++++++++++++++++++++----------------- man/anacrontab.5 | 84 ++++++++++----- man/cron.8 | 223 ++++++++++++++++++++------------------ man/crontab.1 | 133 +++++++++++++---------- man/crontab.5 | 317 ++++++++++++++++++++++++++++--------------------------- src/.indent.pro | 10 ++ src/Makefile.am | 3 +- src/cron.c | 219 ++++++++++++++++++++++---------------- src/cron.h | 51 --------- src/crontab.c | 130 ++++++++++++++--------- src/database.c | 155 ++++++++++++++------------- src/do_command.c | 174 +++++++++++++++++------------- src/entry.c | 104 ++++++++++-------- src/env.c | 28 +++-- src/externs.h | 44 +------- src/funcs.h | 17 ++- src/globals.h | 9 ++ src/job.c | 9 +- src/macros.h | 10 +- src/misc.c | 75 +++++++------ src/pathnames.h | 9 -- src/popen.c | 21 +++- src/pw_dup.c | 51 ++++----- src/security.c | 143 ++++++++++++++----------- src/structs.h | 9 ++ src/user.c | 89 +++++++++------- 28 files changed, 1345 insertions(+), 1052 deletions(-) create mode 100755 autogen.sh delete mode 100644 src/cron.h -- Sami Kerola http://www.iki.fi/kerolasa/

3 20

Re: [Cronie-devel] [patches] cronie: fix syslog message, and manuals
by Marcela Mašláňová 23 Nov '12

23 Nov '12

On 11/23/2012 12:23 AM, Sami Kerola wrote: > Hi Marcela, > > I installed systemd and noticed crond complaining at startup there is > no sendmail. Yes, correct, and I do not want to have it so the cron > should be silent when I instruct it to use syslog instead. That's the > first patch. Rest are about manual pages, which I found to have few > issues with groff, and couple errors in information. > > -- > Sami Kerola > http://www.iki.fi/kerolasa/ > Hello Sami, What I see if I uninstall sendmail (or any other MTA) is: Nov 23 10:33:17 localhost crond[3813]: (CRON) INFO (Syslog will be used instead of sendmail.) When I use -s as an option for crond, no messages are sent to syslog. Imho it is correct behaviour because I'd like to warn users who wish to use email, that they don't have any MTA installed. Do you see different messages? I'll review the rest of man pages fixes. Pity, I released new bugfix release yesterday, so it take some time to see your fixes in next release. Thanks, Marcela

2 1

Re: [Cronie-devel] Fwd: cronie does not close file descriptors before invocation of commands
by Tomas Mraz 13 Nov '12

13 Nov '12

On Tue, 2012-11-13 at 19:48 +0100, bevan(a)bi-co.net wrote: > Hi, > > it seems like the mailing list didn't like my message so I forward it to you. > > By now I can add to it: > I recompiled cronie on Arch using Fedoras patch and it solves the > problem with the leaking FDs, so I really think its the missing commit > b19007ca9fddd62ecef3af4a7d2d252f1d5e0419 in release 1.4.8. > > A new release would be great to solve this issue in distributions that > don't like downstream patches (like ArchLinux). Ah, you're right. The new release is long overdue. We will do it soon. -- Tomas Mraz No matter how far down the wrong road you've gone, turn back. Turkish proverb

1 0

cronie does not close file descriptors before invocation of commands
by Vojtěch Dziewięcki 12 Nov '12

12 Nov '12

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi guys, please see this bug: https://bugzilla.novell.com/show_bug.cgi?id=786096 And please find enclosed the patch. I thought you might be interested in it upstream. Regards, Wojtek Dziewięcki, SUSE -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBAgAGBQJQoP8lAAoJEHrcxBn8c1xjtH4IAKUiu9k58Wzat8Z970n/VPm9 nR1eMn60pouxiII8LRCF5rsbbyCZSIxY4qIYHXSYShd8WDfzKEtv1LUbBk8AYdzk rFwq5WWZzQ5AtQMyCQJvHllS/YXODOCSwq/9ariBS8dWsGyqjv0c95YU1IuYO/Tu Zorb1zdM5mT4juJowtHMPGYV9407SHKjbD3I4lD/10MyMoMrLjUeKdDIUlL8tNTL yPGgmMxDbmEB7zbVsLxtcxjFf9AiMLs3gmUddfhZLrtNUxbEhh4JduQk8Kxo2xdZ 5Tpa2ZormE12qQjrb82qNnEc1pbGnskn//fLqiTqc8wAI9Fsdnt6GXfgNThhJ80= =n30z -----END PGP SIGNATURE-----

2 1

cron shouting
by Marcela Mašláňová 02 Nov '12

02 Nov '12

I'm sorry your latest email was discarded by mailman. CRON is fine, the whole path can be seen if you run it as normal user (I guess). We don't see it as wrong. It was always printed out in upper case, so I don't see reason to change it. <cite> I've had the current copy running for a couple of days, I see one difference - instead of logging the full path of the executable (/USR/SBIN/CRON), it only writes "CRON". I'm not sure this makes much more sense. I mean, it still shouts. Brgds Per Jesse </cite> -- Marcela Mašláňová BaseOS team Brno

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Cronie-devel November 2012