On Thu, 2018-09-13 at 12:08 -0500, Justin Forbes wrote:
On Thu, Sep 13, 2018 at 12:00 PM, Matthias Clasen mclasen@redhat.com wrote:
On Thu, Sep 13, 2018 at 11:10 AM Hans de Goede hdegoede@redhat.com wrote:
Without an easy way for people to test this it will be broken for ever.
A feature like this needs to have an easy way to opt in, so that we can get people to test this and report issues (or success). So that we can improve the hw support over time until we feel comfortable to at least try to enable this by default.
It will be broken forever, since the kernel team can't support it, from what I hear. We should just remove hibernation support from the Fedora kernel. No point in haggling about an easy way to opt-in to a feature that is not supported.
The thing is, hibernate does work for some users. And eventually will be made to work with secure boot as well. But it is very difficult for us to "support" a feature when the fixes are often blacklist x driver or edit your DSDT table. There is a large variety of hardware and some of it just doesn't work.
If we are not going to support hibernation any time soon, then there is little reason to make the feature easily accessible to users.
So when considering that constraint, it does not seem like a great idea to allow users to configure hibernation (and suspend-then-hibernate) easily. It would be nice to have, but unfortunately it only makes sense if we are able commit the resources to fix issues that users run into.
Sounds to me that this means we should be turning off hibernation in systemd (I assume that is simple to do). In principle I am also fine with removing hibernation support from the kernel. But that seems like a much more invasive change and I suspect there may be a number of disappointed users.
Benjamin