----- Original Message -----
Hi,
On 13-09-18 16:16, Benjamin Berg wrote:
Hi,
On Thu, 2018-09-13 at 10:06 -0400, Bastien Nocera wrote:
This needs to be disabled in systemd, as I mentioned in the previous thread. This means it would still work in GNOME if somebody enables the feature in systemd, as would be expected.
Yeah, I agree that disabling it in systemd by default is likely the best way forward for F29. If we can get enough testing, then it may be possible to enable hibernation again for F30.
gsd-power has no configuration option to change the behaviour. It will simply use SuspendThenHibernate rather than Suspend when the method is available.
My reaction to Bastien and yours crossed, right gsd-power has no configuration option now. What I'm suggesting is, that since some people want this to be opt-in, we add such a configuration option.
This really is a policy decision and as such belongs in GNOME IMHO systemd simply provides a mechanism for this and the availability call it has is to indicate if the hardware can support this at all (with no guarantees about this working).
Either way we need to do something about this for F29.
It's broken. systemd will use it when GNOME isn't involved, therefore, it will be broken at another level. It doesn't have a configuration on purpose, because it should just work. We don't add configuration options in GNOME when things should just work.
Disabling the support at the systemd level is as easy as masking a target. Somebody interested in using the feature just needs to unask a target, without needing to make changes to GNOME on top of that.
This is what you want to do.
Adding a new configuration option doesn't explain to the end-user why this might be a bad option to enable in the current state. It doesn't explain why it's not enabled by default if it's a good feature to use.