On Wed, 2008-04-09 at 13:49 +0200, Marco Pesenti Gritti wrote:

2008/4/2 Owen Taylor otaylor@redhat.com:

...

• Sidebar Preferences should put a border around the preview images -

they look funny blending into the background.

Turns out to be a canvas bug. (this also fixes other UI issues, like the confusing bigboard menu layout and separation between milky bigboard and application windows).

Marco

Index: common/hippo/hippo-canvas-box.c

--- common/hippo/hippo-canvas-box.c (revision 7249) +++ common/hippo/hippo-canvas-box.c (working copy) @@ -1543,7 +1543,7 @@ guint32 border_color_rgba;

 if (box->border_color_set)

•    border_color_rgba = box->border_color_set;
  

•    border_color_rgba = box->border_color_rgba;
  

  else border_color_rgba = hippo_canvas_style_get_border_color(style, side);

While I can forgive myself making the typo, I really should have noticed the missing borders :-)

Thanks for the catch ... please commit.

- Owen