Hi All,
Its been a while since I last dealt with comps, so I'm a bit rusty on this :)
For the vbox guest integration feature: https://fedoraproject.org/wiki/Changes/VirtualBox_Guest_Integration
The new virtualbox-guest-additions pkg needs to be part of the default Workstation install / livecd composes.
So 2 questions:
1) Do I need to ask anyone specific permission for making this change? 2) How do I actually implement this change?
Regards,
Hans
Hi Hans,
On Wed, Feb 14, 2018 at 9:18 AM, Hans de Goede hdegoede@redhat.com wrote:
- Do I need to ask anyone specific permission for making this change?
- How do I actually implement this change?
I think that it's the matter of creating a PR against https://pagure.io/fedora-comps . Choose the .xml.in for the desired Fedora version and add the packages to the workstation-product group - https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Tom
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela tpopela@redhat.com wrote:
I think that it's the matter of creating a PR against https://pagure.io/fedora-comps . Choose the .xml.in for the desired Fedora version and add the packages to the workstation-product group
Almost! There is another comps group that's more appropriate here. virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
Anyway, all the other guest additions are in that group. The virtualization group is included in the Workstation kickstart so it will get pulled in by default, no need to add to workstation-product.
Thanks,
Michael
On Wed, Feb 14, 2018 at 5:32 PM, mcatanzaro@gnome.org wrote:
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela tpopela@redhat.com wrote:
I think that it's the matter of creating a PR against https://pagure.io/fedora-comps . Choose the .xml.in for the desired Fedora version and add the packages to the workstation-product group - https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Almost! There is another comps group that's more appropriate here. virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
You're probably looking for guest-desktop-agents, on line 3030
I wouldn't call pagure "terrible", but it is kinda bad at handling big files like comps.
On Wed, Feb 14, 2018 at 05:47:03PM +0200, Elad Alfassa wrote:
I think that it's the matter of creating a PR against https://pagure.io/fedora-comps . Choose the .xml.in for the desired Fedora version and add the packages to the workstation-product group - https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Almost! There is another comps group that's more appropriate here. virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
I wouldn't call pagure "terrible", but it is kinda bad at handling big files like comps.
There's an open ticket on the handling of large files: https://pagure.io/pagure/pull-request/2963
In this specific case, it looks like the time was due to it trying to add syntax highlighting to the whole big XML file — the infra team and pagure devs are putting in a workaround for that now.
In general, when you see specific problems, report 'em and that's how they get fixed....
Hi,
On 14-02-18 16:47, Elad Alfassa wrote:
On Wed, Feb 14, 2018 at 5:32 PM, <mcatanzaro@gnome.org mailto:mcatanzaro@gnome.org> wrote:
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela <tpopela@redhat.com <mailto:tpopela@redhat.com>> wrote: I think that it's the matter of creating a PR against https://pagure.io/fedora-comps . Choose the .xml.in <http://xml.in> for the desired Fedora version and add the packages to the workstation-product group - https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499 <https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499> Almost! There is another comps group that's more appropriate here. virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.You're probably looking for guest-desktop-agents, on line 3030
Great.
Thank you all for your answer. I' a bit swamped atm, but I will try to get this done soon.
Regards,
Hans
On Wed, Feb 14, 2018 at 5:32 PM, <mcatanzaro@gnome.org mailto:mcatanzaro@gnome.org> wrote:
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela <tpopela@redhat.commailto:tpopela@redhat.com> wrote:
I think that it's the matter of creating a PR againsthttps://pagure.io/fedora-comps . Choose the .xml.in http://xml.in for the desired Fedora version and add the packages to the workstation-product group
https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Almost! There is another comps group that's more appropriate here.virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
You're probably looking for guest-desktop-agents, on line 3030
Great.
Thank you all for your answer. I' a bit swamped atm, but I will try to get this done soon.
I did a commit to add this in as I was doing other comps changes for various other bits, it'll be in the F-27 and later comps (inc F-29) shortly.
Peter
Hi,
On 19-02-18 17:20, Peter Robinson wrote:
On Wed, Feb 14, 2018 at 5:32 PM, <mcatanzaro@gnome.org mailto:mcatanzaro@gnome.org> wrote:
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela <tpopela@redhat.commailto:tpopela@redhat.com> wrote:
I think that it's the matter of creating a PR againsthttps://pagure.io/fedora-comps . Choose the .xml.in http://xml.in for the desired Fedora version and add the packages to the workstation-product group
https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Almost! There is another comps group that's more appropriate here.virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
You're probably looking for guest-desktop-agents, on line 3030
Great.
Thank you all for your answer. I' a bit swamped atm, but I will try to get this done soon.
I did a commit to add this in as I was doing other comps changes for various other bits, it'll be in the F-27 and later comps (inc F-29) shortly.
Great, thank you.
I noticed that you've added it to the comps file for F27 too, but it is not build for F27 and there are no plans to build it there (because of conflicts with the rpmfusion version of the package).
I guess this does not matter much, but if someone now tries to re-compose F27, won't this make it fail?
Regards,
Hans
On Tue, Feb 20, 2018 at 8:09 AM, Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 19-02-18 17:20, Peter Robinson wrote:
On Wed, Feb 14, 2018 at 5:32 PM, <mcatanzaro@gnome.org mailto:mcatanzaro@gnome.org> wrote:
On Wed, Feb 14, 2018 at 3:26 AM, Tomas Popela <tpopela@redhat.commailto:tpopela@redhat.com> wrote:
I think that it's the matter of creating a PR againsthttps://pagure.io/fedora-comps . Choose the .xml.in http://xml.in for the desired Fedora version and add the packages to the workstation-product group
https://pagure.io/fedora-comps/blob/master/f/comps-f28.xml.in#_6499
Almost! There is another comps group that's more appropriate here.virtualization something. I would look it up, but I got impatient waiting 20+ seconds for pagure to load. pagure is really terrible.
You're probably looking for guest-desktop-agents, on line 3030
Great.
Thank you all for your answer. I' a bit swamped atm, but I will try to get this done soon.
I did a commit to add this in as I was doing other comps changes for various other bits, it'll be in the F-27 and later comps (inc F-29) shortly.
Great, thank you.
I noticed that you've added it to the comps file for F27 too, but it is not build for F27 and there are no plans to build it there (because of conflicts with the rpmfusion version of the package).
I guess this does not matter much, but if someone now tries to re-compose F27, won't this make it fail?
I thought I checked to see if it was there, maybe the host I checked with dnf was something newer than f27, but overall it won't matter.
P
desktop@lists.stg.fedoraproject.org
-
Elad Alfassa -
Hans de Goede -
Matthew Miller -
mcatanzaro＠gnome.org -
Peter Robinson -
Tomas Popela