Hi,
lately we've been looking into why some of the spokes are hidden for Workstation and some not for Silverblue. The reason for that was that there is a special configuration file that is created in the Workstation kickstart file[0], that hides some of the spokes, that are being handled by GNOME Initial Setup. We should create that file for Silverblue as well - probably in post script of the compose[1]. When I first proposed that in the #silverblue, then Dusty Mabe replied, that the Silverblue is already using the Workstation installation class, so the system should be reworked to take that into account. The Anaconda developer Vendula Poncová came with the proposed solution[2], where the /data/product.d/ configuration files are used to hide the spokes. Our particular problem is solved by the commit [3]. The nice thing about the new solution is that it allows us to drop the entry from the Workstation's kickstart file and have the configuration united on one place in the Anaconda repository.
Does anyone has anything to share about the proposed solution?
[0] - https://pagure.io/fedora-kickstarts/blob/master/f/fedora-live-workstation.ks... [1] - https://pagure.io/workstation-ostree-config/blob/master/f/post.sh [2] - https://github.com/rhinstaller/anaconda/pull/1981 [3] - https://github.com/rhinstaller/anaconda/pull/1981/commits/1549aac68010443d63...
Bye, Tom
LGTM. Let's be sure to remove remove https://pagure.io/fedora-kickstarts/blob/master/f/fedora-live-workstation.ks... when it lands.
Michael
On Tue, 2019-05-28 at 07:34 +0200, Tomas Popela wrote:
Hi,
lately we've been looking into why some of the spokes are hidden for Workstation and some not for Silverblue. The reason for that was that there is a special configuration file that is created in the Workstation kickstart file[0], that hides some of the spokes, that are being handled by GNOME Initial Setup. We should create that file for Silverblue as well - probably in post script of the compose[1]. When I first proposed that in the #silverblue, then Dusty Mabe replied, that the Silverblue is already using the Workstation installation class, so the system should be reworked to take that into account. The Anaconda developer Vendula Poncová came with the proposed solution[2], where the /data/product.d/ configuration files are used to hide the spokes. Our particular problem is solved by the commit [3]. The nice thing about the new solution is that it allows us to drop the entry from the Workstation's kickstart file and have the configuration united on one place in the Anaconda repository.
Does anyone has anything to share about the proposed solution?
Well...a couple of things.
1. Any maintenance on this will have to go through anaconda team. The name of the directory ('product.d') rather suggests this is a drop-in style thing; if so, is it possible for this config file to be shipped in a separate package maintained directly by Workstation folks, and just ensure that package is included in all scenarios where we want this tweak?
2. Have we thought through all cases where the variant now being 'Workstation Live' rather than 'Workstation' might cause problems?
Hi Adam,
On Tue, May 28, 2019 at 6:02 PM Adam Williamson adamwill@fedoraproject.org wrote:
- Any maintenance on this will have to go through anaconda team. The
name of the directory ('product.d') rather suggests this is a drop-in style thing; if so, is it possible for this config file to be shipped in a separate package maintained directly by Workstation folks, and just ensure that package is included in all scenarios where we want this tweak?
It looks like it could be done this way. Vendy, can you please clarify?
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
What do you mean by that? Can you clarify it a little bit?
Tom
On Fri, 2019-05-31 at 13:44 +0200, Tomas Popela wrote:
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
What do you mean by that? Can you clarify it a little bit?
Well, just look at the anaconda pull request: we change variant_name from "Workstation" to "Workstation Live" in fedora-silverblue.conf and the export of `ANACONDA_PRODUCTVARIANT` from "Workstation" to "Workstation Live" in liveinst.
I am not sure of the consequence of these changes, but experience teaches me to be nervous any time some kind of significant string just ups and changes like that :) I don't know if that string winds up embedded somewhere in installed systems, for instance (and thus other things might be parsing it), or if other bits of anaconda may care about the variant name and haven't yet been changed...
On Fri, May 31, 2019 at 9:20 AM Adam Williamson adamwill@fedoraproject.org wrote:
On Fri, 2019-05-31 at 13:44 +0200, Tomas Popela wrote:
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
What do you mean by that? Can you clarify it a little bit?
Well, just look at the anaconda pull request: we change variant_name from "Workstation" to "Workstation Live" in fedora-silverblue.conf and the export of `ANACONDA_PRODUCTVARIANT` from "Workstation" to "Workstation Live" in liveinst.
I am not sure of the consequence of these changes, but experience teaches me to be nervous any time some kind of significant string just ups and changes like that :) I don't know if that string winds up embedded somewhere in installed systems, for instance (and thus other things might be parsing it), or if other bits of anaconda may care about the variant name and haven't yet been changed...
Do dnf or gnome-software upgrades use it? Updates I expect not, but what determines what new things to include in an edition or product and what things to remove?
On Fri, 2019-05-31 at 11:43 -0600, Chris Murphy wrote:
On Fri, May 31, 2019 at 9:20 AM Adam Williamson adamwill@fedoraproject.org wrote:
On Fri, 2019-05-31 at 13:44 +0200, Tomas Popela wrote:
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
What do you mean by that? Can you clarify it a little bit?
Well, just look at the anaconda pull request: we change variant_name from "Workstation" to "Workstation Live" in fedora-silverblue.conf and the export of `ANACONDA_PRODUCTVARIANT` from "Workstation" to "Workstation Live" in liveinst.
I am not sure of the consequence of these changes, but experience teaches me to be nervous any time some kind of significant string just ups and changes like that :) I don't know if that string winds up embedded somewhere in installed systems, for instance (and thus other things might be parsing it), or if other bits of anaconda may care about the variant name and haven't yet been changed...
Do dnf or gnome-software upgrades use it? Updates I expect not, but what determines what new things to include in an edition or product and what things to remove?
Package groups. So that wouldn't be a problem.
On Tue, 2019-05-28 at 07:34 +0200, Tomas Popela wrote:
Well...a couple of things.
- Any maintenance on this will have to go through anaconda team. The
name of the directory ('product.d') rather suggests this is a drop-in style thing; if so, is it possible for this config file to be shipped in a separate package maintained directly by Workstation folks, and just ensure that package is included in all scenarios where we want this tweak?
It wouldn't work with the current pull request, because Silverblue uses a configuration file for Workstation Live. However, we already discuss other solutions for Silverblue, so it shouldn't be an issue.
Anyway, we would like to maintain all product configuration files until we are done with the Anaconda modularization. It might be necessary to do some changes across all these files and it is easier this way. That is the reason why install classes were moved to the Anaconda repository in the first place.
Another solution could be to just modify fedora-live-workstation.ks and write a new file to /etc/anaconda/conf.d that will override the hidden_spokes option. Then we don't need a special configuration file for Workstation Live. The content of the file would look like this:
[User Interface] hidden_spokes = NetworkSpoke PasswordSpoke UserSpoke
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
I have checked the code and the variant name is used only for loading the right product configuration files. It was introduced quite recently in in a commit at https://github.com/rhinstaller/anaconda/commit/6e4bfc4 for this specific purpose.
The spins don't seem to use the configuration file for Fedora Workstation, so it shouldn't affect them.
On Tue, 2019-06-04 at 10:05 +0000, Vendula Poncova wrote:
On Tue, 2019-05-28 at 07:34 +0200, Tomas Popela wrote:
Well...a couple of things.
- Any maintenance on this will have to go through anaconda team. The
name of the directory ('product.d') rather suggests this is a drop-in style thing; if so, is it possible for this config file to be shipped in a separate package maintained directly by Workstation folks, and just ensure that package is included in all scenarios where we want this tweak?
It wouldn't work with the current pull request, because Silverblue uses a configuration file for Workstation Live. However, we already discuss other solutions for Silverblue, so it shouldn't be an issue.
Anyway, we would like to maintain all product configuration files until we are done with the Anaconda modularization. It might be necessary to do some changes across all these files and it is easier this way. That is the reason why install classes were moved to the Anaconda repository in the first place.
Another solution could be to just modify fedora-live-workstation.ks and write a new file to /etc/anaconda/conf.d that will override the hidden_spokes option. Then we don't need a special configuration file for Workstation Live. The content of the file would look like this:
[User Interface] hidden_spokes = NetworkSpoke PasswordSpoke UserSpoke
- Have we thought through all cases where the variant now being
'Workstation Live' rather than 'Workstation' might cause problems?
I have checked the code and the variant name is used only for loading the right product configuration files. It was introduced quite recently in in a commit at https://github.com/rhinstaller/anaconda/commit/6e4bfc4 for this specific purpose.
The spins don't seem to use the configuration file for Fedora Workstation, so it shouldn't affect them.
Thanks for the explanations, that all seems reasonable to me.
desktop@lists.stg.fedoraproject.org
-
Adam Williamson -
Chris Murphy -
mcatanzaro＠gnome.org -
Tomas Popela -
Vendula Poncova