On Fri, Jan 08, 2016 at 12:05:14AM -0000, Andrew Toskin wrote:

Hello! I'm interested in learning about RPM packaging for Fedora, and I'd like to see the "Developer Edition" release channel for Firefox (formerly called Firefox Aurora) available in the Fedora repositories. So my partner Bob and I are working on packaging firefox-dev. Our spec file repository is forked from the Fedora package for the regular release of Firefox. It's not in a working state yet, but you can see our progress on GitHub -- https://github.com/Bob131/firefox-dev/

And we have a Copr here -- https://copr.fedoraproject.org/coprs/bob131/firefox-dev/

Firefox Developer Edition and regular Firefox are able to share the same user profile (the bookmarks, preferences, etc) or use separate profiles, we're aiming to allow both versions of Firefox to coexist on the same system.

Bob and I are both fairly new to the packaging process, so any help will be appreciated.

Hi,

some comments on the spec: - you can simplify by removing conditionals for obsolete Fedora versions. In fact you can probably ignore anything below F23 at this point.

- Source0 should be a full URL to a tarball [see https://fedoraproject.org/wiki/Packaging:SourceURL#Referencing_Source].

- you don't need to put the date in Release, unless you're packaging directly from git. But it seems that you're not. (Calling date is wrong!)

- you can remove the Group tags, they are not really used for anything and clutter up the spec file

- %defattr(-,root,root) is the default, please remove.

- Does crashreporter_pkg_name mozilla-crashreporter-%{name}-debuginfo really have files in /test_results? This goes against the FHS...

- There's no value gained by using %{__sed} instead of sed, and %{__rm} instead of rm, %{__cat}, %{__mkdir_p}, etc.

- xvfb-run should be run with '-a', so it doesn't fail if something is running in parallel and hogging the port.

- DESTDIR=$RPM_BUILD_ROOT make -C objdir install → %make_install -C objdir

- is it co-installable with normal firefox package? Should the main binary be called firefox or something like firefox-dev?

- please remove the old %changelog

The spec file looks reasonable. If you're still looking for a package sponsor, I'd be happy to do it. (No need to involve fedora-devel though).

Zbyszek