Hello!
Over the past 8 month, I've been working on getting Electron [1] built on Fedora. Yesterday I was finally able to do the first working build for Fedora Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora. My use for Electron is that I want to run signal-desktop [4] on Fedora. You can get electron and signal-packages packages for it at [5].
Is there interest to bring nodejs-electron into Fedora and if yes, would someone be interested to maintain it? I don't have the time to maintain it but I'm happy to help as a co-maintainer.
Best regards
Andreas
[1] https://www.electronjs.org/ [2] https://build.opensuse.org/package/show/network:im:signal/nodejs-electron [3] https://src.fedoraproject.org/rpms/ffmpeg/ [4] https://build.opensuse.org/package/show/network:im:signal/signal-desktop [5] https://download.opensuse.org/repositories/network:/im:/signal/ Fedora_Rawhide/x86_64/
On Fri, Feb 25, 2022 at 4:54 AM Andreas Schneider asn@redhat.com wrote:
Hello!
Over the past 8 month, I've been working on getting Electron [1] built on Fedora. Yesterday I was finally able to do the first working build for Fedora Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora. My use for Electron is that I want to run signal-desktop [4] on Fedora. You can get electron and signal-packages packages for it at [5].
Is there interest to bring nodejs-electron into Fedora and if yes, would someone be interested to maintain it? I don't have the time to maintain it but I'm happy to help as a co-maintainer.
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
-- 真実はいつも一つ！/ Always, there's only one truth!
On Friday, 25 February 2022 14:02:11 CET Neal Gompa wrote:
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
That would be fine by me. The most obvious application would be Element (Matrix). https://element.io/
On 2/26/22 02:21, Andreas Schneider wrote:
On Friday, 25 February 2022 14:02:11 CET Neal Gompa wrote:
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
That would be fine by me. The most obvious application would be Element (Matrix). https://element.io/
How do you plan to rebuild all of the NPM dependencies? “Just use what is in node_modules” runs into the problem that what is in node_modules often isn’t actually source code. Yes, I know that most other packagers are likely using this approach, but it doesn’t meet Fedora’s “everything must be built from source” requirement.
On Sunday, 27 February 2022 01:37:08 CET Demi Marie Obenour wrote:
On 2/26/22 02:21, Andreas Schneider wrote:
On Friday, 25 February 2022 14:02:11 CET Neal Gompa wrote:
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
That would be fine by me. The most obvious application would be Element (Matrix). https://element.io/
How do you plan to rebuild all of the NPM dependencies? “Just use what is in node_modules” runs into the problem that what is in node_modules often isn’t actually source code. Yes, I know that most other packagers are likely using this approach, but it doesn’t meet Fedora’s “everything must be built from source” requirement.
With signal I replaced the binary node modules with source ones. I also make sure that there are no shared libraries or prebuild .node file around.
Most of the time a `node-gyp rebuild` is what you need to rebuild the binaries.
nodejs-signal-ringrtc was not that easy as it requires webrtc. This also uses ffmpeg and I need a system ffmpeg for that. Also webrtc only offers a static library. So you need to use that to then build ringrtc (rust) and node glue code.
It took me a long long time to figure several things out as there is no documentation how to cleanly build for distributions. I'm making it better in small steps whenever I learn something.
Andreas
On 2/27/22 02:32, Andreas Schneider wrote:
On Sunday, 27 February 2022 01:37:08 CET Demi Marie Obenour wrote:
On 2/26/22 02:21, Andreas Schneider wrote:
On Friday, 25 February 2022 14:02:11 CET Neal Gompa wrote:
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
That would be fine by me. The most obvious application would be Element (Matrix). https://element.io/
How do you plan to rebuild all of the NPM dependencies? “Just use what is in node_modules” runs into the problem that what is in node_modules often isn’t actually source code. Yes, I know that most other packagers are likely using this approach, but it doesn’t meet Fedora’s “everything must be built from source” requirement.
With signal I replaced the binary node modules with source ones. I also make sure that there are no shared libraries or prebuild .node file around.
Most of the time a `node-gyp rebuild` is what you need to rebuild the binaries.
Sadly, that isn’t sufficient. node_modules/ will often contain minified JavaScript, CSS, HTML, or some combination, and minified files aren’t source code. All of the minified files will need to be regenerated from non-minified versions.
On Fri, 2022-02-25 at 08:02 -0500, Neal Gompa wrote:
On Fri, Feb 25, 2022 at 4:54 AM Andreas Schneider asn@redhat.com wrote:
Hello!
Over the past 8 month, I've been working on getting Electron [1] built on Fedora. Yesterday I was finally able to do the first working build for Fedora Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora. My use for Electron is that I want to run signal-desktop [4] on Fedora. You can get electron and signal-packages packages for it at [5].
Is there interest to bring nodejs-electron into Fedora and if yes, would someone be interested to maintain it? I don't have the time to maintain it but I'm happy to help as a co-maintainer.
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
I built and use element-desktop ( https://github.com/vector-im/element-desktop#readme ) on my desktop , I spent 2 or 3 days on hacking the build , at the end I build an rpm with electon-builder ... conclusion we may need also pack electon-builder.
I think we can join these talks on Node.js SIG (Node.js on Fedora nodejs@lists.fedoraproject.org ).
I'd like pack at least nativefier, element-desktop, jitsi-meet- electron, but I'm skeptical that it works with ffpmeg-free ...
Learn and use nodejs-packaging-bundler, maybe is one solution which was talked on Node.js SIG https://lists.fedoraproject.org/archives/list/nodejs@lists.fedoraproject.org... BTW UnitedRPMs also have a electron package https://github.com/UnitedRPMs/electron , it may help, I don't know, and jitsi-meet-electron https://github.com/UnitedRPMs/jitsi-meet-electron which need network enabled to download sources while is building the package ...
Best regards,
On Saturday, 26 February 2022 14:19:40 CET Sérgio Basto wrote:
On Fri, 2022-02-25 at 08:02 -0500, Neal Gompa wrote:
On Fri, Feb 25, 2022 at 4:54 AM Andreas Schneider asn@redhat.com wrote:
Hello!
Over the past 8 month, I've been working on getting Electron [1] built on Fedora. Yesterday I was finally able to do the first working build for Fedora Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora. My use for Electron is that I want to run signal-desktop [4] on Fedora. You can get electron and signal-packages packages for it at [5].
Is there interest to bring nodejs-electron into Fedora and if yes, would someone be interested to maintain it? I don't have the time to maintain it but I'm happy to help as a co-maintainer.
I think this is probably one of those things that would be worth forming a SIG on. An Electron SIG could help with Electron and all Electron-based applications that come into Fedora.
I built and use element-desktop ( https://github.com/vector-im/element-desktop#readme ) on my desktop , I spent 2 or 3 days on hacking the build , at the end I build an rpm with electon-builder ... conclusion we may need also pack electon-builder.
You don't have to. You can point electron builder to your system electron and it will use that. Then you just do not package the electron files. All you need is the resources directory.
What you need to do is to identify if element uses binary npm modules and you need to replace them with the sources.
Andreas
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and it will use that. Then you just do not package the electron files. All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load
OK, we may not need electron-builder :D, I also mention electron- builder more to explain how my element-desktop rpm was generated .
so lets pack element-desktop , I found this
https://build.opensuse.org/package/view_file/openSUSE:Factory/element-deskto...
have we nodejs-electron available on copr ? if not, may I put it there or have we legal constraints ?
Thanks.
:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
On Saturday, March 19, 2022 7:01:46 AM CET Sérgio Basto wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load
OK, we may not need electron-builder :D, I also mention electron- builder more to explain how my element-desktop rpm was generated .
so lets pack element-desktop , I found this
https://build.opensuse.org/package/view_file/openSUSE:Factory/element-deskto p/element-desktop.spec
have we nodejs-electron available on copr ? if not, may I put it there or have we legal constraints ?
Thanks.
I'm building nodejs-electron for rawhide here:
https://build.opensuse.org/package/show/network:im:signal/nodejs-electron
On Mon, 2022-03-21 at 15:56 +0100, Andreas Schneider wrote:
On Saturday, March 19, 2022 7:01:46 AM CET Sérgio Basto wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load
OK, we may not need electron-builder :D, I also mention electron- builder more to explain how my element-desktop rpm was generated .
so lets pack element-desktop , I found this
https://build.opensuse.org/package/view_file/openSUSE:Factory/element-deskto p/element-desktop.spec
have we nodejs-electron available on copr ? if not, may I put it there or have we legal constraints ?
Thanks.
I'm building nodejs-electron for rawhide here:
https://build.opensuse.org/package/show/network:im:signal/nodejs-electron
may I put nodejs-electron on copr or have we any legal constraints ?
On Tuesday, March 22, 2022 2:11:08 AM CET Sérgio Basto wrote:
On Mon, 2022-03-21 at 15:56 +0100, Andreas Schneider wrote:
On Saturday, March 19, 2022 7:01:46 AM CET Sérgio Basto wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel
wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load
OK, we may not need electron-builder :D, I also mention electron- builder more to explain how my element-desktop rpm was generated .
so lets pack element-desktop , I found this
https://build.opensuse.org/package/view_file/openSUSE:Factory/element-de skto p/element-desktop.spec
have we nodejs-electron available on copr ? if not, may I put it there or have we legal constraints ?
Thanks.
I'm building nodejs-electron for rawhide here:
https://build.opensuse.org/package/show/network:im:signal/nodejs-electron
may I put nodejs-electron on copr or have we any legal constraints ?
I asked for help to bring it to Fedora! I said I would co-maintain it. So if you want to help feel free too. Currently you can only build for f36+ ...
If you do changes, please contribute back!
Thanks
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
I started build electron on copr [1]
I built ffmpeg , nodejs-electron, element-web and element-desktop for Fedora 34 and 35 successfully element-web fails on F36+
I rebuilt ffmpeg-free from Fedora to F35 and F34 after I used https://build.opensuse.org/package/show/network:im:signal/nodejs-electron https://build.opensuse.org/package/show/devel:languages:javascript/element-w... https://build.opensuse.org/package/show/home:sergiomb/element-desktop
build on electron took 11 hours on x64 and 15 hours in aarch , is almost a build o chromium , which make me wonder if we can't use a chromium as a library https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-li...
[1] https://copr.fedorainfracloud.org/coprs/sergiomb/electrons/monitor/
On Sun, Mar 27, 2022 at 2:42 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
I started build electron on copr [1]
I built ffmpeg , nodejs-electron, element-web and element-desktop for Fedora 34 and 35 successfully element-web fails on F36+
I rebuilt ffmpeg-free from Fedora to F35 and F34 after I used https://build.opensuse.org/package/show/network:im:signal/nodejs-electron https://build.opensuse.org/package/show/devel:languages:javascript/element-w... https://build.opensuse.org/package/show/home:sergiomb/element-desktop
build on electron took 11 hours on x64 and 15 hours in aarch , is almost a build o chromium , which make me wonder if we can't use a chromium as a library https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-li...
libchromiumcontent hasn't been a thing in a *very* long time. It was merged into Electron in Electron 4.0 (which was years ago!) and it's all built as one runtime environment binary.
But, one thing that could be done to simplify things would be to ship a chromium-src-devel package in the chromium package that electron could pull in. That would tightly couple the chromium and electron packages, but it would mean that improvements we make to the chromium package would be easily consumed by electron...
I'm not sure we *want* to do that, but I have seen that done before for Electron packaging...
On Sun, 2022-03-27 at 14:52 -0400, Neal Gompa wrote:
On Sun, Mar 27, 2022 at 2:42 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
I started build electron on copr [1]
I built ffmpeg , nodejs-electron, element-web and element-desktop for Fedora 34 and 35 successfully element-web fails on F36+
I rebuilt ffmpeg-free from Fedora to F35 and F34 after I used https://build.opensuse.org/package/show/network:im:signal/nodejs-electron https://build.opensuse.org/package/show/devel:languages:javascript/element-w... https://build.opensuse.org/package/show/home:sergiomb/element-desktop
build on electron took 11 hours on x64 and 15 hours in aarch , is almost a build o chromium , which make me wonder if we can't use a chromium as a library https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-li...
libchromiumcontent hasn't been a thing in a *very* long time. It was merged into Electron in Electron 4.0 (which was years ago!) and it's all built as one runtime environment binary.
But, one thing that could be done to simplify things would be to ship a chromium-src-devel package in the chromium package that electron could pull in. That would tightly couple the chromium and electron packages, but it would mean that improvements we make to the chromium package would be easily consumed by electron...
yes, I think that should be the path and and I'd love see that done , also for other projects like nwjs (node-webkit) https://github.com/nwjs/nw.js , doesn't make sense to me build chromium all the times , mainly because chromium takes hours and hours to build and consumes a lot and a lot of resources.
I'm not sure we *want* to do that, but I have seen that done before for Electron packaging...
-- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Resuming this thread as the podman and podman-desktop teams are looking to get podman-desktop packaged in Fedora But it's unlikely either team would be able to own the nodejs-electron dep.
Would the nodejs sig and/or fedora desktop team and/or chromium maintainers be willing to package and own nodejs-electron?
There's an open github issue pointing to this thread but that may not get enough Fedora eyes so I'm checking back here. (See: https://github.com/containers/podman-desktop/issues/112)
On Sun, Mar 27, 2022 at 3:38 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-03-27 at 14:52 -0400, Neal Gompa wrote:
On Sun, Mar 27, 2022 at 2:42 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
You don't have to. You can point electron builder to your system electron and
it will use that. Then you just do not package the electron files.
All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
I started build electron on copr [1]
I built ffmpeg , nodejs-electron, element-web and element-desktop for Fedora 34 and 35 successfully element-web fails on F36+
I rebuilt ffmpeg-free from Fedora to F35 and F34 after I used https://build.opensuse.org/package/show/network:im:signal/nodejs-electron https://build.opensuse.org/package/show/devel:languages:javascript/element-w... https://build.opensuse.org/package/show/home:sergiomb/element-desktop
build on electron took 11 hours on x64 and 15 hours in aarch , is almost a build o chromium , which make me wonder if we can't use a chromium as a library https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-li...
libchromiumcontent hasn't been a thing in a *very* long time. It was merged into Electron in Electron 4.0 (which was years ago!) and it's all built as one runtime environment binary.
But, one thing that could be done to simplify things would be to ship a chromium-src-devel package in the chromium package that electron could pull in. That would tightly couple the chromium and electron packages, but it would mean that improvements we make to the chromium package would be easily consumed by electron...
yes, I think that should be the path and and I'd love see that done , also for other projects like nwjs (node-webkit) https://github.com/nwjs/nw.js , doesn't make sense to me build chromium all the times , mainly because chromium takes hours and hours to build and consumes a lot and a lot of resources.
I'm not sure we *want* to do that, but I have seen that done before for Electron packaging...
-- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
-- Sérgio M. B. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
if we can have chromium-src-devel ...
But, one thing that could be done to simplify things would be to ship a chromium-src-devel package in the chromium package that electron could pull in. That would tightly couple the chromium and electron packages, but it would mean that improvements we make to the chromium
On Thu, 2022-09-15 at 15:14 -0400, Lokesh Mandvekar wrote:
Resuming this thread as the podman and podman-desktop teams are looking to get podman-desktop packaged in Fedora But it's unlikely either team would be able to own the nodejs- electron dep.
Would the nodejs sig and/or fedora desktop team and/or chromium maintainers be willing to package and own nodejs-electron?
There's an open github issue pointing to this thread but that may not get enough Fedora eyes so I'm checking back here. (See: https://github.com/containers/podman-desktop/issues/112)
On Sun, Mar 27, 2022 at 3:38 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-03-27 at 14:52 -0400, Neal Gompa wrote:
On Sun, Mar 27, 2022 at 2:42 PM Sérgio Basto sergio@serjux.com wrote:
On Sun, 2022-02-27 at 17:15 +0100, Andreas Schneider wrote:
On Sunday, 27 February 2022 10:06:17 CET Vitaly Zaitsev via devel wrote:
On 27/02/2022 08:23, Andreas Schneider wrote:
> You don't have to. You can point electron builder to your > system > electron > and
it will use that. Then you just do not package the electron files.
> All you need is the resources directory.
You must run electron-builder on Fedora Koji. Pre-built packages are not allowed.
You should not package electron at all with your package! You should use the nodejs-electron in the distribution and just point it to the sources to load:
cat <<EOF >%{buildroot}%{_bindir}/signal-desktop #!/bin/sh export NODE_ENV=production
exec %{_bindir}/electron %{_libdir}/%{name}/resources/app.asar "$@" EOF chmod +x %{buildroot}%{_bindir}/signal-desktop
I started build electron on copr [1]
I built ffmpeg , nodejs-electron, element-web and element- desktop for Fedora 34 and 35 successfully element-web fails on F36+
I rebuilt ffmpeg-free from Fedora to F35 and F34 after I used https://build.opensuse.org/package/show/network:im:signal/nodejs-electron https://build.opensuse.org/package/show/devel:languages:javascript/element-w... https://build.opensuse.org/package/show/home:sergiomb/element-desktop
build on electron took 11 hours on x64 and 15 hours in aarch , is almost a build o chromium , which make me wonder if we can't use a chromium as a library https://www.electronjs.org/blog/electron-internals-building-chromium-as-a-li...
libchromiumcontent hasn't been a thing in a *very* long time. It was merged into Electron in Electron 4.0 (which was years ago!) and it's all built as one runtime environment binary.
But, one thing that could be done to simplify things would be to ship a chromium-src-devel package in the chromium package that electron could pull in. That would tightly couple the chromium and electron packages, but it would mean that improvements we make to the chromium package would be easily consumed by electron...
yes, I think that should be the path and and I'd love see that done , also for other projects like nwjs (node-webkit) https://github.com/nwjs/nw.js%C2%A0, doesn't make sense to me build chromium all the times , mainly because chromium takes hours and hours to build and consumes a lot and a lot of resources.
I'm not sure we *want* to do that, but I have seen that done before for Electron packaging...
-- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
-- Sérgio M. B. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
-- Lokesh Libera, GitLab, GitHub, Fedora: lsm5 Matrix: @lsm5:lsm5.ems.host GPG: 0xC7C3A0DD https://keybase.io/lsm5 _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Il 25/02/22 10:53, Andreas Schneider ha scritto:
This was possible because we finally have ffmpeg [3] in Fedora.
Wow, going off-topic here, but that's great news that should have been highlighted and announced. There are several packages that have some functionalities disabled because ffmpeg was never been available in Fedora and this is a game changer.
Mattia
Andreas Schneider left as an exercise for the reader:
Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora.
oh hey great! i'm currently using OpenImageIO in Notcurses on Fedora because ffmpeg wasn't available, but i'd rather be using ffmpeg. i see it just got in a few weeks ago -- is it a reduced configuration, or did a patent expire, or were the rules keeping it out amended, or what?
On Sat, Mar 5, 2022 at 5:21 PM nick black dankamongmen@gmail.com wrote:
Andreas Schneider left as an exercise for the reader:
Rawhide [2]. This was possible because we finally have ffmpeg [3] in Fedora.
oh hey great! i'm currently using OpenImageIO in Notcurses on Fedora because ffmpeg wasn't available, but i'd rather be using ffmpeg. i see it just got in a few weeks ago -- is it a reduced configuration, or did a patent expire, or were the rules keeping it out amended, or what?
Reduced configuration to offer what we can ship. But it does have H.264 support through OpenH264 and AAC support through fdk-aac-free.
Neal Gompa left as an exercise for the reader:
Reduced configuration to offer what we can ship. But it does have H.264 support through OpenH264 and AAC support through fdk-aac-free.
outstanding; it ought support at least everything OIIO supports, then. thanks much to everyone who made this happen!
On Sun, Mar 6, 2022 at 9:22 AM nick black dankamongmen@gmail.com wrote:
Neal Gompa left as an exercise for the reader:
Reduced configuration to offer what we can ship. But it does have H.264 support through OpenH264 and AAC support through fdk-aac-free.
outstanding; it ought support at least everything OIIO supports, then. thanks much to everyone who made this happen!
Note that this is F36+ only, and will eventually be in EPEL 9 once its dependency chain is in EPEL[1].
[1]: https://bugzilla.redhat.com/show_bug.cgi?id=2053866
Neal Gompa left as an exercise for the reader:
Note that this is F36+ only, and will eventually be in EPEL 9 once its dependency chain is in EPEL[1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=2053866
yep, i've already rebuilt my package for f37 and f36!
devel@lists.stg.fedoraproject.org
-
Andreas Schneider -
Demi Marie Obenour -
Lokesh Mandvekar -
Mattia Verga -
Neal Gompa -
nick black -
Sérgio Basto -
Vitaly Zaitsev