https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Bug ID: 1427189 Summary: Unresolved OSGi requirement breaks Eclipse help system Product: Fedora Version: rawhide Component: jetty Assignee: mizdebsk@redhat.com Reporter: mat.booth@redhat.com QA Contact: extras-qa@fedoraproject.org CC: eclipse-sig@lists.fedoraproject.org, java-sig-commits@lists.fedoraproject.org, krzysztof.daniel@gmail.com, mizdebsk@redhat.com, msimacek@redhat.com
Description of problem:
When using the integrated Eclipse help system, I see this error in the log:
!ENTRY org.eclipse.ui 4 0 2017-02-27 14:19:57.069 !MESSAGE Unhandled event loop exception !STACK 0 java.lang.NoClassDefFoundError: org/eclipse/equinox/http/jetty/JettyConfigurator at org.eclipse.help.internal.server.JettyHelpServer$StartServerThread.run(JettyHelpServer.java:79) Caused by: java.lang.ClassNotFoundException: org.eclipse.equinox.http.jetty.JettyConfigurator cannot be found by org.eclipse.help.base_4.1.2.v20170227-1124 at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:461) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:372) at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:364) at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:161) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 1 more
Looking at the OSGi console, I see the following unresolved bundles:
g! ss -s INSTALLED id State Bundle 97 INSTALLED org.eclipse.equinox.http.jetty_3.3.0.v20170227-1124 143 INSTALLED org.eclipse.jetty.http_9.4.2.v20170220 145 INSTALLED org.eclipse.jetty.security_9.4.2.v20170220 146 INSTALLED org.eclipse.jetty.server_9.4.2.v20170220 147 INSTALLED org.eclipse.jetty.servlet_9.4.2.v20170220
And it seems to be caused by a missing capability:
g! diag 143 org.eclipse.jetty.http [143] Unresolved requirement: Require-Capability: osgi.extender; filter:="(osgi.extender=osgi.serviceloader.processor)"
This requirement seems to be new in:
jetty-http-9.4.2-1.v20170220.fc26.noarch
It doesn't look like there is a provider of this capability in Fedora. Any idea if this requirement can be made optional?
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- External Bug ID| |Eclipse Project 512807
--- Comment #1 from Mat Booth mat.booth@redhat.com --- Adding link upstream bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|mizdebsk@redhat.com |msimacek@redhat.com
--- Comment #3 from Michael Simacek msimacek@redhat.com --- The reference implementation for the capability is Apache Aries SPI Fly [1], which is not packaged in Fedora. I can package it if needed. But from the discussion at [2] it seems that eclipse's dependencies are too coarse grained. Can you check whether you can use the suggested solution?
[1] http://aries.apache.org/modules/spi-fly.html [2] https://github.com/eclipse/jetty.project/issues/1290
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
--- Comment #4 from Mat Booth mat.booth@redhat.com --- (In reply to Michael Simacek from comment #3)
The reference implementation for the capability is Apache Aries SPI Fly [1], which is not packaged in Fedora. I can package it if needed. But from the discussion at [2] it seems that eclipse's dependencies are too coarse grained. Can you check whether you can use the suggested solution?
[1] http://aries.apache.org/modules/spi-fly.html [2] https://github.com/eclipse/jetty.project/issues/1290
The discussion at [2] is a bit misleading because Eclipse does not make use of jetty-http2, it only makes use of the regular jetty-http bundle as it always has done.
From my tests (as suggested by Tom Watson in the eclipse bug), this dependency can be made optional in the jetty-http bundle.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it Depends On| |1427941
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1427941 [Bug 1427941] Review Request: aries-spifly - Reference Implementation of the OSGi ServiceLoader Mediator specification
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #5 from Michael Simacek msimacek@redhat.com --- Applying Matt's patch for now.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.2-2.v20170220.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-94ac9ce627
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.2-2.v20170220.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-94ac9ce627
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Michael Simacek msimacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1427941 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1427941 [Bug 1427941] Review Request: aries-spifly - Reference Implementation of the OSGi ServiceLoader Mediator specification
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |jetty-9.4.2-2.v20170220.fc2 | |6 Resolution|--- |ERRATA Last Closed| |2017-04-01 12:50:47
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.2-2.v20170220.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Mat Booth mat.booth@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #9 from Mat Booth mat.booth@redhat.com --- It turns out this is not as fixed as I though it was as there is a second dependency on Apache Aries SPI Fly that should be optional :-(
I submitted another patch upstream here: https://github.com/eclipse/jetty.project/pull/1451/commits/1b9ec463a3b8b83d6...
I'd like to see this applied to F26 and F27, if possible.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Fixed In Version|jetty-9.4.2-2.v20170220.fc2 |9.4.3-2.v20170317 |6 | Assignee|msimacek@redhat.com |mizdebsk@redhat.com
--- Comment #10 from Mikolaj Izdebski mizdebsk@redhat.com --- Fixed in jetty-9.4.3-2.v20170317
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.3-2.v20170317.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4a95e07013
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
--- Comment #12 from Mikolaj Izdebski mizdebsk@redhat.com --- Buildroot override activated, https://bodhi.fedoraproject.org/overrides/jetty-9.4.3-2.v20170317.fc26
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.3-2.v20170317.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4a95e07013
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- jetty-9.4.3-2.v20170317.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|9.4.3-2.v20170317 |9.4.3-3.v20170317
https://bugzilla.redhat.com/show_bug.cgi?id=1427189
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2017-04-01 12:50:47 |2017-04-18 17:50:37
--- Comment #15 from Mikolaj Izdebski mizdebsk@redhat.com --- I believe that this bug is fixed in jetty-9.4.3-3.v20170317, which is available in Fedora 26, so I am closing this bug now.
The build containing the fix can be found at Koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=880501
eclipse-sig@lists.stg.fedoraproject.org