URL: https://github.com/freeipa/freeipa/pull/3509
Author: frasertweedale
Title: #3509: [Backport][ipa-4-7] Profile-based system cert renewal
Action: opened
PR body:
"""
Manual backport of #3316 to ipa-4-7. We
may need to backport this change all the way to ipa-4-6 to allow us to change
the IPA RA certificate profile on older releases.
See also https://github.com/freeipa/freeipa/pull/3508 which is the ipa-4-7 backport PR.
There were some trivial conflicts. There were substantive conflicts for two patches,
but these were due to the switch from mod_nss to mod_ssl, and from NSSDB-based
IPA RA cert to PEM files. Those patches were not relevant, and were dropped.
https://pagure.io/freeipa/issue/7991
Do not rely on CI only; I will have to test this change myself so I'll add WIP
label, and remove it when I'm satisfied.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3509/head:pr3509
git checkout pr3509
URL: https://github.com/freeipa/freeipa/pull/3508
Author: frasertweedale
Title: #3508: [Backport][ipa-4-7] Profile-based system cert renewal
Action: opened
PR body:
"""
Manual backport of https://github.com/freeipa/freeipa/pull/3316 to ipa-4-7. We
may need to backport this change all the way to ipa-4-6 to allow us to change
the IPA RA certificate profile on older releases. Currently this change is on
master and ipa-4-8, so ipa-4-7 is the next step.
There were some trivial conflicts. The only substantive conflicts were in
`dogtaginstance.py`. These were resolved by cherry-picking
8686cd3b4b69f725aee05c9cdd3034d7436055d3 ahead of the original patchset.
https://pagure.io/freeipa/issue/7991
Do not rely on CI only; I will have to test this change myself so I'll add WIP
label, and remove it when I'm satisfied.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3508/head:pr3508
git checkout pr3508
URL: https://github.com/freeipa/freeipa/pull/3849
Author: t-woerner
Title: #3849: ipaserver/plugins/hbacrule: Add HBAC to memberservice_hbacsvc* labels
Action: opened
PR body:
"""
The labels for memberservice_hbacsvc and memberservice_hbacsvcgroup are
only "Services" and "Service Groups" but they should be "HBAC Services"
and "HBAC Service Groups".
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3849/head:pr3849
git checkout pr3849
URL: https://github.com/freeipa/freeipa/pull/3783
Author: stanislavlevin
Title: #3783: Migrate xunit-style setups to fixtures
Action: opened
PR body:
"""
This converts `setup*`/`teardown*` functions/methods to the
powerfull pytest fixtures:
```
The purpose of test fixtures is to provide a fixed baseline upon
which tests can reliably and repeatedly execute. pytest fixtures
offer dramatic improvements over the classic xUnit style of
setup/teardown functions:
- fixtures have explicit names and are activated by declaring their
use from test functions, modules, classes or whole projects.
- fixtures are implemented in a modular manner, as each fixture name
triggers a fixture function which can itself use other fixtures.
- fixture management scales from simple unit to complex functional
testing, allowing to parametrize fixtures and tests according to
configuration and component options, or to re-use fixtures across
function, class, module or whole test session scopes.
```
One of the transition patterns is as follows:
```diff
class TestFooBar(XMLRPC_test):
- @classmethod
- def setup_class(cls):
- super(TestFooBar, cls).setup_class()
+ @pytest.fixture(autouse=True, scope="class")
+ def foo_bar_setup(self, request, xmlrpc_setup):
+ cls = request.cls
cls.beforemethod()
- @classmethod
- def teardown_class(cls):
- cls.aftermethod()
- super(TestFooBar, cls).teardown_class()
+ def fin():
+ cls.aftermethod()
+ request.addfinalizer(fin)
```
To achieve predictable results for initialization and destroy of
Pytest fixtures, ones have to employ the fixtures' interdependencies.
This is the first part of the work to remove the mixing of test idioms in the
IPA test suite.
Related: https://pagure.io/freeipa/issue/7989
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3783/head:pr3783
git checkout pr3783
URL: https://github.com/freeipa/freeipa/pull/3931
Author: jayesh-garg
Title: #3931: Test if ipactl starts services stopped by systemctl
Action: opened
PR body:
"""
This will first check if all services are running then it will stop
few service. After that it will restart all services and then check
the status and pid of services.It will also compare pid after ipactl
start and restart in case of start it will remain unchanged on the
other hand in case of restart it will change.
Signed-off-by: Jayesh <jgarg(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3931/head:pr3931
git checkout pr3931
URL: https://github.com/freeipa/freeipa/pull/3349
Author: amore17
Title: #3349: ipatests: filter_users should be applied correctly if SSSD starts offline
Action: opened
PR body:
"""
Added tests which validates that filter_users is applied correctly
when SSSD starts in offline mode, which checks that no look up
should be in data provider and NCE/USER/ipa_domain/user should be
added to negative cache.
Related Tickets:
https://pagure.io/SSSD/sssd/issue/3983https://pagure.io/SSSD/sssd/issue/3978
Signed-off-by: Anuja More <amore(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3349/head:pr3349
git checkout pr3349