[PATCH] bodhi update run: Attempt to get better Atomic images media name during updates run
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media name. Taken inspiration from releng issue [3] and ansible commit [4]. I am not sure how to test it locally, any pointers will be useful.
[1] https://kojipkgs.fedoraproject.org/compose/updates/Fedora-28-updates-2018062... [2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-Atomic-28-20180620... [3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=40c32c9...
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media name. Taken inspiration from releng issue [3] and ansible commit [4]. I am not sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
[1] https://kojipkgs.fedoraproject.org/compose/updates/Fedora-28-updates-2018062... [2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-Atomic-28-20180620... [3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=40c32c9...
On Thu, Jun 21, 2018 at 11:51 PM, Dusty Mabe dusty@dustymabe.com wrote:
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media
name.
Taken inspiration from releng issue [3] and ansible commit [4]. I am not sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
Yeah , we don't now but added it because we may need in future when F29 is released. I have updated patch (available in attachment) with removing if condition.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
Randy is on PTO currently, will check with lsedlar if he can test this patch on stage.
updates/Fedora-28-updates-20180620.0/compose/AtomicHost/x86_64/images/
[2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-Atomic-28-
20180620.0/compose/AtomicHost/x86_64/images/
[3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/
ansible.git/commit/?id=40c32c97f2dcaab549dba7cbb5fbd1897bd57ed8
Sorry for late response.
Last patch didn't work when we tested in koji for an image build. We had to make some changes in pungi [1] to fix it and now fix is available in pungi-4.1.26-2.
New patch (available in attachment) should work once bodhi-backend-01 is updated with latest pungi. [2]
[1] https://pagure.io/pungi/c/1759c1ba80156a8ec466e4ad31802930ade4ba8e?branch=ma... [2] https://pagure.io/fedora-infrastructure/issue/7154
On Fri, Jun 22, 2018 at 10:11 AM, Sinny Kumari ksinny@gmail.com wrote:
On Thu, Jun 21, 2018 at 11:51 PM, Dusty Mabe dusty@dustymabe.com wrote:
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media
name.
Taken inspiration from releng issue [3] and ansible commit [4]. I am not sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
Yeah , we don't now but added it because we may need in future when F29 is released. I have updated patch (available in attachment) with removing if condition.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
Randy is on PTO currently, will check with lsedlar if he can test this patch on stage.
[1] https://kojipkgs.fedoraproject.org/compose/updates/Fedora-
28-updates-20180620.0/compose/AtomicHost/x86_64/images/
[2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-
Atomic-28-20180620.0/compose/AtomicHost/x86_64/images/
[3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/ansible.git/
commit/?id=40c32c97f2dcaab549dba7cbb5fbd1897bd57ed8
On Thu, Aug 9, 2018 at 8:01 PM, Sinny Kumari ksinny@gmail.com wrote:
Sorry for late response.
Last patch didn't work when we tested in koji for an image build. We had to make some changes in pungi [1] to fix it and now fix is available in pungi-4.1.26-2.
pungi-4.1.26-2 should be available now on bodhi-backend-01.
New patch (available in attachment) should work once bodhi-backend-01
is updated with latest pungi. [2]
[1] https://pagure.io/pungi/c/1759c1ba80156a8ec466e4ad318029 30ade4ba8e?branch=master [2] https://pagure.io/fedora-infrastructure/issue/7154
On Fri, Jun 22, 2018 at 10:11 AM, Sinny Kumari ksinny@gmail.com wrote:
On Thu, Jun 21, 2018 at 11:51 PM, Dusty Mabe dusty@dustymabe.com wrote:
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media
name.
Taken inspiration from releng issue [3] and ansible commit [4]. I am
not
sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
Yeah , we don't now but added it because we may need in future when F29 is released. I have updated patch (available in attachment) with removing if condition.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
Randy is on PTO currently, will check with lsedlar if he can test this patch on stage.
[1] https://kojipkgs.fedoraproject.org/compose/updates/Fedora-28
-updates-20180620.0/compose/AtomicHost/x86_64/images/
[2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-At
omic-28-20180620.0/compose/AtomicHost/x86_64/images/
[3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/ansible.git/co
mmit/?id=40c32c97f2dcaab549dba7cbb5fbd1897bd57ed8
Sorry, previous patch had a minor issue. Please use the patch from here (available in attachment).
On Fri, Aug 10, 2018 at 1:00 PM, Sinny Kumari ksinny@gmail.com wrote:
On Thu, Aug 9, 2018 at 8:01 PM, Sinny Kumari ksinny@gmail.com wrote:
Sorry for late response.
Last patch didn't work when we tested in koji for an image build. We had to make some changes in pungi [1] to fix it and now fix is available in pungi-4.1.26-2.
pungi-4.1.26-2 should be available now on bodhi-backend-01.
New patch (available in attachment) should work once bodhi-backend-01
is updated with latest pungi. [2]
[1] https://pagure.io/pungi/c/1759c1ba80156a8ec466e4ad31802930ad e4ba8e?branch=master [2] https://pagure.io/fedora-infrastructure/issue/7154
On Fri, Jun 22, 2018 at 10:11 AM, Sinny Kumari ksinny@gmail.com wrote:
On Thu, Jun 21, 2018 at 11:51 PM, Dusty Mabe dusty@dustymabe.com wrote:
On 06/21/2018 10:49 AM, Sinny Kumari wrote:
From past few weeks, we have started producing Atomic composes media during Fedora 28 bodhi updates and updates-testing run. Media name of AH ISO are perfectly fine. But for cloud images media name[1] looks something like Fedora-AtomicHost-28_Update-20180620.1235.x86_64.qcow2 for qcow2. It will be nice to have media name like Fedora-AtomicHost-28-20180620.0.x86_64.qcow2 which is what we get during regular atomic twoweek compose run [2].
This patch (available in email attachment) attempts to fix the media
name.
Taken inspiration from releng issue [3] and ansible commit [4]. I am
not
sure how to test it locally, any pointers will be useful.
Thanks Sinny!
Since we are already only building images for >= 28 then I don't think we need the if/endif statements in your patch.
Yeah , we don't now but added it because we may need in future when F29 is released. I have updated patch (available in attachment) with removing if condition.
I would say to try to work with randy/lsedlar to test this in stage but since nothing is yet depending on these images I'm not opposed to just merging this and seeing if it works in prod.
Randy is on PTO currently, will check with lsedlar if he can test this patch on stage.
[1] https://kojipkgs.fedoraproject.org/compose/updates/Fedora-28
-updates-20180620.0/compose/AtomicHost/x86_64/images/
[2] https://kojipkgs.fedoraproject.org/compose/twoweek/Fedora-At
omic-28-20180620.0/compose/AtomicHost/x86_64/images/
[3] https://pagure.io/releng/issue/7113 [4] https://infrastructure.fedoraproject.org/cgit/ansible.git/co
mmit/?id=40c32c97f2dcaab549dba7cbb5fbd1897bd57ed8
On 08/10/2018 10:35 AM, Sinny Kumari wrote:
Sorry, previous patch had a minor issue. Please use the patch from here (available in attachment).
LGTM. Thanks Sinny. I'll let someone from releng/infra +1 before I push.
Dusty
Looks ok to me. +1
kevin
On Mon, Aug 13, 2018 at 2:58 AM, Dusty Mabe dusty@dustymabe.com wrote:
On 08/12/2018 05:59 AM, Kevin Fenzi wrote:
Looks ok to me. +1
kevin
Applied and playbook ran!
Thanks!
Dusty
infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists. fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/ infrastructure@lists.fedoraproject.org/message/ Z2HDJHCKI7IWHR3KCLDYOMZF2SY4XFOT/
infrastructure@lists.fedoraproject.org
-
Dusty Mabe -
Kevin Fenzi -
Sinny Kumari