When building ppc builders which reside on qa.fedoraproject.org we get the wrong /etc/hosts file because the generic ansible_domain executes before the more specific due to task host_group option.
In general I believe if we have something explicitly in a host_group we'd want to prioritise that over a generic sub domain.
Peter
diff --git a/roles/hosts/tasks/main.yml b/roles/hosts/tasks/main.yml index faeccb9..c74827e 100644 --- a/roles/hosts/tasks/main.yml +++ b/roles/hosts/tasks/main.yml @@ -16,9 +16,9 @@ - "{{ inventory_hostname }}-hosts" - "{{ ansible_fqdn }}-hosts" - "{{ ansible_hostname }}-hosts" + - "{{ host_group }}-hosts" - "{{ ansible_domain }}-hosts" - "{{ datacenter }}-hosts" - - "{{ host_group }}-hosts" skip: true tags: - config
On Wed, Jul 29, 2015 at 05:24:46PM +0100, Peter Robinson wrote:
When building ppc builders which reside on qa.fedoraproject.org we get the wrong /etc/hosts file because the generic ansible_domain executes before the more specific due to task host_group option.
In general I believe if we have something explicitly in a host_group we'd want to prioritise that over a generic sub domain.
Peter
diff --git a/roles/hosts/tasks/main.yml b/roles/hosts/tasks/main.yml index faeccb9..c74827e 100644 --- a/roles/hosts/tasks/main.yml +++ b/roles/hosts/tasks/main.yml @@ -16,9 +16,9 @@ - "{{ inventory_hostname }}-hosts" - "{{ ansible_fqdn }}-hosts" - "{{ ansible_hostname }}-hosts"
- "{{ host_group }}-hosts"
- "{{ ansible_domain }}-hosts"
- "{{ datacenter }}-hosts"
skip: true tags:
- "{{ host_group }}-hosts"
- config
Sounds ok to me, do we have a way to check which hosts are impacted by this change?
Pierre
On Wed, Jul 29, 2015 at 5:29 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Wed, Jul 29, 2015 at 05:24:46PM +0100, Peter Robinson wrote:
When building ppc builders which reside on qa.fedoraproject.org we get the wrong /etc/hosts file because the generic ansible_domain executes before the more specific due to task host_group option.
In general I believe if we have something explicitly in a host_group we'd want to prioritise that over a generic sub domain.
Peter
diff --git a/roles/hosts/tasks/main.yml b/roles/hosts/tasks/main.yml index faeccb9..c74827e 100644 --- a/roles/hosts/tasks/main.yml +++ b/roles/hosts/tasks/main.yml @@ -16,9 +16,9 @@ - "{{ inventory_hostname }}-hosts" - "{{ ansible_fqdn }}-hosts" - "{{ ansible_hostname }}-hosts"
- "{{ host_group }}-hosts"
- "{{ ansible_domain }}-hosts"
- "{{ datacenter }}-hosts"
skip: true tags:
- "{{ host_group }}-hosts"
- config
Sounds ok to me, do we have a way to check which hosts are impacted by this change?
Kevin says he has a report that "check/diff report what machines would change based on it"
On Wed, 29 Jul 2015 17:58:52 +0100 Peter Robinson pbrobinson@gmail.com wrote:
Sounds ok to me, do we have a way to check which hosts are impacted by this change?
Kevin says he has a report that "check/diff report what machines would change based on it"
Yeah, if we push this change now, I can tell you tomorrow any hosts that would have changed. ;)
I'm +1 to the change and we can clean up anything that shouldn't change. Ideally only the aarch64 builders are affected.
kevin
Sounds ok to me, do we have a way to check which hosts are impacted by this change?
Kevin says he has a report that "check/diff report what machines would change based on it"
Yeah, if we push this change now, I can tell you tomorrow any hosts that would have changed. ;)
Pushed
I'm +1 to the change and we can clean up anything that shouldn't change. Ideally only the aarch64 builders are affected.
s/aarch64/ppc64*/
aarch64 uses .arm.fedora.... where as for some reason PPC uses .qa.fedora...
Peter
On Wed, 29 Jul 2015 20:50:37 +0100 Peter Robinson pbrobinson@gmail.com wrote:
Sounds ok to me, do we have a way to check which hosts are impacted by this change?
Kevin says he has a report that "check/diff report what machines would change based on it"
Yeah, if we push this change now, I can tell you tomorrow any hosts that would have changed. ;)
Pushed
I'm +1 to the change and we can clean up anything that shouldn't change. Ideally only the aarch64 builders are affected.
s/aarch64/ppc64*/
aarch64 uses .arm.fedora.... where as for some reason PPC uses .qa.fedora...
Peter _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/infrastructure
ok. This change seems to hit the arm*-builder* machines and arm01-releng* machines with the following diff.
Perhaps we could just add those 2 other entries into kojibuilder-hosts?
kevin -- TASK: [hosts | setup /etc/hosts for some clients] ***************************** --- before: /etc/hosts +++ after: /srv/web/infra/ansible/roles/hosts/files/kojibuilder-hosts @@ -1,13 +1,14 @@ 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 +10.5.126.23 infrastructure.fedoraproject.org +10.5.126.51 mirrors.fedoraproject.org admin.fedoraproject.org +# primary koji infra 10.5.125.63 koji.fedoraproject.org 10.5.125.36 kojipkgs.fedoraproject.org -10.5.126.23 infrastructure.fedoraproject.org -10.5.124.138 arm.koji.fedoraproject.org -10.5.124.138 armpkgs.fedoraproject.org 10.5.125.44 pkgs.fedoraproject.org pkgs -# -# This is proxy01.phx2.fedoraproject.org -# -10.5.126.51 mirrors.fedoraproject.org -10.5.126.51 admin.fedoraproject.org +# arm koji infra +10.5.124.138 arm.koji.fedoraproject.org armpkgs.fedoraproject.org +# ppc koji infra +10.5.124.182 ppc.koji.fedoraproject.org ppcpkgs.fedoraproject.org +# s390 koji infra +10.5.124.191 s390.koji.fedoraproject.org s390pkgs.fedoraproject.org
infrastructure@lists.fedoraproject.org
-
Kevin Fenzi -
Peter Robinson -
Pierre-Yves Chibon