Hi, we have in various PB:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README - import_tasks: "{{ tasks_path }}/yumrepos.yml"
In commits: * 5999880b9 add tag, without a tag this load is skipped when using -t config * ae2e32a3c include all/vars only once
I moved the line: - include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README into yumrepos.yml
Therefore it should not be needed. But I cannot test it. Therefore I will leave it to somebody braver. Nevertheless having the line there makes no harm. It should be just clean up.
On Mon, Dec 16, 2019 at 12:45:01PM +0100, Miroslav Suchý wrote:
Hi, we have in various PB:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
- import_tasks: "{{ tasks_path }}/yumrepos.yml"
In commits:
- 5999880b9 add tag, without a tag this load is skipped when using -t config
- ae2e32a3c include all/vars only once
I moved the line:
- include_vars: dir=/srv/web/infra/ansible/vars/all/ ignore_files=README
into yumrepos.yml
Therefore it should not be needed. But I cannot test it. Therefore I will leave it to somebody braver. Nevertheless having the line there makes no harm. It should be just clean up.
I think there may have been some places we didn't add yumrepos for various reasons, but that might also no longer be the case. ;)
We can investigate cleaning out all the ones that do call yumrepos anyhow.
Thanks for the commits!
kevin
infrastructure@lists.fedoraproject.org