Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958727
Bug ID: 958727 Summary: plexus-utils: XMLWriterUtil should guard against problematic comments Product: Fedora Version: rawhide Component: plexus-utils Severity: unspecified Priority: unspecified Assignee: fnasser@redhat.com Reporter: fweimer@redhat.com QA Contact: extras-qa@fedoraproject.org CC: fnasser@redhat.com, java-sig-commits@lists.fedoraproject.org, mizdebsk@redhat.com Blocks: 958220 Category: ---
org.codehaus.plexus.util.xml#writeComment(XMLWriter, String, int, int, int) does not check if the comment includes a "-->" sequence. This means that text contained in the command string could be interpreted as XML, possibly leading to XML injection issues, depending on how this method is being called.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=958727
Florian Weimer fweimer@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|plexus-utils: XMLWriterUtil |plexus-utils: XML |should guard against |generators should guard |problematic comments |against problematic text | |strings
--- Comment #1 from Florian Weimer fweimer@redhat.com --- Similarly, org.codehaus.plexus.util.xml.pull.MXSerializer should avoid XML injection throw comments, processing instructions, CDATA sections, etc.
https://bugzilla.redhat.com/show_bug.cgi?id=958727
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1009413
https://bugzilla.redhat.com/show_bug.cgi?id=958727
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|fnasser@redhat.com |mizdebsk@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=958727
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |UPSTREAM Last Closed| |2015-05-14 06:29:11
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- This is feature request and as such it has been forwarded upstream: http://jira.codehaus.org/browse/PLXUTILS-177
https://bugzilla.redhat.com/show_bug.cgi?id=958727
--- Comment #4 from Florian Weimer fweimer@redhat.com --- Re-reported here:
https://github.com/codehaus-plexus/plexus-utils/issues/3 https://github.com/sonatype/plexus-utils/issues/19
https://bugzilla.redhat.com/show_bug.cgi?id=958727
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|UPSTREAM |RAWHIDE
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- Fixed in upstream version 3.0.24
java-sig-commits@lists.stg.fedoraproject.org