Re: Bluetooth regression breaking BT connection for all 2.0 and older devices in 5.0.15+, 5.1.x and master
Hi,
On 10-06-19 15:31, Hans de Goede wrote:
Hi All,
First of all this is a known issue and it seems a fix is in the works, but what I do not understand is why the commit causing this has not simply been reverted until the fix is done, esp. for the 5.0.x stable series where this was introduced in 5.0.15.
The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... basically completely breaking all somewhat older (and some current cheap no-name) bluetooth devices:
A revert of this was first proposed on May 22nd: https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v... We are 18 days further now and this problem still exists, including in the 5.0.15+ and 5.1.x stable kernels.
A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtma... and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix, but as of today I do not see a fix nor a revert in Torvald's tree yet and neither does there seem to be any fix in the 5.0.x and 5.1.x stable series.
In the mean time we are getting a lot of bug reports about this: https://bugzilla.kernel.org/show_bug.cgi?id=203643 https://bugzilla.redhat.com/show_bug.cgi?id=1711468 https://bugzilla.redhat.com/show_bug.cgi?id=1713871 https://bugzilla.redhat.com/show_bug.cgi?id=1713980
And some reporters: https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4 Are indicating that the Fedora kernels with the workaround included still do not work...
Given that things are still broken for some users, I suggest that for Fedora we replace the workaround with a straight forward revert of d5bb334a8e17 for now. Also the rawhide kernels are missing the workaround, so those are currently broken regardless.
Regards,
Hans
On Mon, Jun 10, 2019 at 03:36:50PM +0200, Hans de Goede wrote:
Hi,
On 10-06-19 15:31, Hans de Goede wrote:
Hi All,
First of all this is a known issue and it seems a fix is in the works, but what I do not understand is why the commit causing this has not simply been reverted until the fix is done, esp. for the 5.0.x stable series where this was introduced in 5.0.15.
The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... basically completely breaking all somewhat older (and some current cheap no-name) bluetooth devices:
A revert of this was first proposed on May 22nd: https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v... We are 18 days further now and this problem still exists, including in the 5.0.15+ and 5.1.x stable kernels.
A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtma... and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix, but as of today I do not see a fix nor a revert in Torvald's tree yet and neither does there seem to be any fix in the 5.0.x and 5.1.x stable series.
In the mean time we are getting a lot of bug reports about this: https://bugzilla.kernel.org/show_bug.cgi?id=203643 https://bugzilla.redhat.com/show_bug.cgi?id=1711468 https://bugzilla.redhat.com/show_bug.cgi?id=1713871 https://bugzilla.redhat.com/show_bug.cgi?id=1713980
And some reporters: https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4 Are indicating that the Fedora kernels with the workaround included still do not work...
Given that things are still broken for some users, I suggest that for Fedora we replace the workaround with a straight forward revert of d5bb334a8e17 for now. Also the rawhide kernels are missing the workaround, so those are currently broken regardless.
The v5.1.8 kernels are already done building so this would happen for v5.1.9. Hopefully upstream will decide on a course of action before that, but if they haven't I'm not against carrying a revert instead of the RFC patch.
I do I happen to know someone with a Playstation 3 controller so I've asked them to see if they can reproduce #1713980, as well.
- Jeremy
Hi,
On 10-06-19 15:36, Hans de Goede wrote:
Hi,
On 10-06-19 15:31, Hans de Goede wrote:
Hi All,
First of all this is a known issue and it seems a fix is in the works, but what I do not understand is why the commit causing this has not simply been reverted until the fix is done, esp. for the 5.0.x stable series where this was introduced in 5.0.15.
The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... basically completely breaking all somewhat older (and some current cheap no-name) bluetooth devices:
A revert of this was first proposed on May 22nd: https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v... We are 18 days further now and this problem still exists, including in the 5.0.15+ and 5.1.x stable kernels.
A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtma... and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix, but as of today I do not see a fix nor a revert in Torvald's tree yet and neither does there seem to be any fix in the 5.0.x and 5.1.x stable series.
In the mean time we are getting a lot of bug reports about this: https://bugzilla.kernel.org/show_bug.cgi?id=203643 https://bugzilla.redhat.com/show_bug.cgi?id=1711468 https://bugzilla.redhat.com/show_bug.cgi?id=1713871 https://bugzilla.redhat.com/show_bug.cgi?id=1713980
And some reporters: https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4 Are indicating that the Fedora kernels with the workaround included still do not work...
Given that things are still broken for some users, I suggest that for Fedora we replace the workaround with a straight forward revert of d5bb334a8e17 for now. Also the rawhide kernels are missing the workaround, so those are currently broken regardless.
Note since Torvald's mastter branch still does not have a fix for this, Greg has gone with a straight forward revert for all the stable series including 5.1.x .
This means that the rawhide kernels are currently still broken, I suggest that we pick-up Greg's revert and add that as a downstream patch to the rawhide kernels for now.
Greg's patch has not been pushed to the linux-stable repo yet, so I will forward it to kernel@lists.fedoraproject.org.
Regards,
Hans
On Fri, Jun 14, 2019 at 11:18:24AM +0200, Hans de Goede wrote:
Hi,
On 10-06-19 15:36, Hans de Goede wrote:
Hi,
On 10-06-19 15:31, Hans de Goede wrote:
Hi All,
First of all this is a known issue and it seems a fix is in the works, but what I do not understand is why the commit causing this has not simply been reverted until the fix is done, esp. for the 5.0.x stable series where this was introduced in 5.0.15.
The problem I'm talking about is commit d5bb334a8e17 ("Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... basically completely breaking all somewhat older (and some current cheap no-name) bluetooth devices:
A revert of this was first proposed on May 22nd: https://lore.kernel.org/netdev/CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v... We are 18 days further now and this problem still exists, including in the 5.0.15+ and 5.1.x stable kernels.
A solution has been suggested: https://lore.kernel.org/linux-bluetooth/20190522070540.48895-1-marcel@holtma... and at least the Fedora 5.1.4+ kernels now carry this as a temporary fix, but as of today I do not see a fix nor a revert in Torvald's tree yet and neither does there seem to be any fix in the 5.0.x and 5.1.x stable series.
In the mean time we are getting a lot of bug reports about this: https://bugzilla.kernel.org/show_bug.cgi?id=203643 https://bugzilla.redhat.com/show_bug.cgi?id=1711468 https://bugzilla.redhat.com/show_bug.cgi?id=1713871 https://bugzilla.redhat.com/show_bug.cgi?id=1713980
And some reporters: https://bugzilla.redhat.com/show_bug.cgi?id=1713871#c4 Are indicating that the Fedora kernels with the workaround included still do not work...
Given that things are still broken for some users, I suggest that for Fedora we replace the workaround with a straight forward revert of d5bb334a8e17 for now. Also the rawhide kernels are missing the workaround, so those are currently broken regardless.
Note since Torvald's mastter branch still does not have a fix for this, Greg has gone with a straight forward revert for all the stable series including 5.1.x .
This means that the rawhide kernels are currently still broken, I suggest that we pick-up Greg's revert and add that as a downstream patch to the rawhide kernels for now.
Greg's patch has not been pushed to the linux-stable repo yet, so I will forward it to kernel@lists.fedoraproject.org.
Thanks for the reminder, I've added the patch to Rawhide so it should be in the next build. I included the revert in v5.1.9 (in updates-testing) as well.
- Jeremy
kernel@lists.fedoraproject.org
-
Hans de Goede -
Jeremy Cline