From: "Justin M. Forbes" jforbes@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_COMMON_CLK:
The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select this option.
Symbol: COMMON_CLK [=n] Type : bool Defined at drivers/clk/Kconfig:25 Prompt: Common Clock Framework Depends on: !HAVE_LEGACY_CLK [=n] Location: -> Device Drivers Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] Selected by [n]: - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI - PMC_ATOM [=n] && X86 && PCI [=y]
---
Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org --- .../configs/common/generic/CONFIG_COMMON_CLK | 1 + .../pending-common/generic/CONFIG_COMMON_CLK | 24 ------------------- 2 files changed, 1 insertion(+), 24 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_COMMON_CLK delete mode 100644 redhat/configs/pending-common/generic/CONFIG_COMMON_CLK
diff --git a/redhat/configs/common/generic/CONFIG_COMMON_CLK b/redhat/configs/common/generic/CONFIG_COMMON_CLK new file mode 100644 index 000000000000..077e3ea2a4bb --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_COMMON_CLK @@ -0,0 +1 @@ +# CONFIG_COMMON_CLK is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK b/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK deleted file mode 100644 index ce3f5f9ca539..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_COMMON_CLK: -# -# The common clock framework is a single definition of struct -# clk, useful across many platforms, as well as an -# implementation of the clock API in include/linux/clk.h. -# Architectures utilizing the common struct clk should select -# this option. -# -# Symbol: COMMON_CLK [=n] -# Type : bool -# Defined at drivers/clk/Kconfig:25 -# Prompt: Common Clock Framework -# Depends on: !HAVE_LEGACY_CLK [=n] -# Location: -# -> Device Drivers -# Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] -# Selected by [n]: -# - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] -# - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI -# - PMC_ATOM [=n] && X86 && PCI [=y] -# -# -# -# CONFIG_COMMON_CLK is not set
From: Justin Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_35911423...
CONFIG_COMMON_CLK is flipped automatically by other config options in ARK.
On 6/10/20 4:38 PM, GitLab Bridge on behalf of jmflinuxtx wrote:
From: "Justin M. Forbes" jforbes@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_COMMON_CLK:
The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select this option.
Symbol: COMMON_CLK [=n] Type : bool Defined at drivers/clk/Kconfig:25 Prompt: Common Clock Framework Depends on: !HAVE_LEGACY_CLK [=n] Location: -> Device Drivers Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] Selected by [n]:
- MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y]
- INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI
- PMC_ATOM [=n] && X86 && PCI [=y]
Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org
.../configs/common/generic/CONFIG_COMMON_CLK | 1 + .../pending-common/generic/CONFIG_COMMON_CLK | 24 ------------------- 2 files changed, 1 insertion(+), 24 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_COMMON_CLK delete mode 100644 redhat/configs/pending-common/generic/CONFIG_COMMON_CLK
diff --git a/redhat/configs/common/generic/CONFIG_COMMON_CLK b/redhat/configs/common/generic/CONFIG_COMMON_CLK new file mode 100644 index 000000000000..077e3ea2a4bb --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_COMMON_CLK @@ -0,0 +1 @@ +# CONFIG_COMMON_CLK is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK b/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK deleted file mode 100644 index ce3f5f9ca539..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_COMMON_CLK: -# -# The common clock framework is a single definition of struct -# clk, useful across many platforms, as well as an -# implementation of the clock API in include/linux/clk.h. -# Architectures utilizing the common struct clk should select -# this option. -# -# Symbol: COMMON_CLK [=n] -# Type : bool -# Defined at drivers/clk/Kconfig:25 -# Prompt: Common Clock Framework -# Depends on: !HAVE_LEGACY_CLK [=n] -# Location: -# -> Device Drivers -# Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] -# Selected by [n]: -# - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] -# - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI -# - PMC_ATOM [=n] && X86 && PCI [=y] -# -# -# -# CONFIG_COMMON_CLK is not set
This should be =y.
Nacked-by: Prarit Bhargava prarit@redhat.com
P.
From: "Justin M. Forbes" jforbes@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_COMMON_CLK:
The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select this option.
Symbol: COMMON_CLK [=n] Type : bool Defined at drivers/clk/Kconfig:25 Prompt: Common Clock Framework Depends on: !HAVE_LEGACY_CLK [=n] Location: -> Device Drivers Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] Selected by [n]: - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI - PMC_ATOM [=n] && X86 && PCI [=y]
Cc: Mark Salter msalter@redhat.com --- .../configs/common/generic/CONFIG_COMMON_CLK | 1 + .../pending-common/generic/CONFIG_COMMON_CLK | 24 ------------------- 2 files changed, 1 insertion(+), 24 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_COMMON_CLK delete mode 100644 redhat/configs/pending-common/generic/CONFIG_COMMON_CLK
diff --git a/redhat/configs/common/generic/CONFIG_COMMON_CLK b/redhat/configs/common/generic/CONFIG_COMMON_CLK new file mode 100644 index 000000000000..077e3ea2a4bb --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_COMMON_CLK @@ -0,0 +1 @@ +# CONFIG_COMMON_CLK is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK b/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK deleted file mode 100644 index ce3f5f9ca539..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_COMMON_CLK: -# -# The common clock framework is a single definition of struct -# clk, useful across many platforms, as well as an -# implementation of the clock API in include/linux/clk.h. -# Architectures utilizing the common struct clk should select -# this option. -# -# Symbol: COMMON_CLK [=n] -# Type : bool -# Defined at drivers/clk/Kconfig:25 -# Prompt: Common Clock Framework -# Depends on: !HAVE_LEGACY_CLK [=n] -# Location: -# -> Device Drivers -# Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] -# Selected by [n]: -# - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] -# - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI -# - PMC_ATOM [=n] && X86 && PCI [=y] -# -# -# -# CONFIG_COMMON_CLK is not set
From: Justin M. Forbes jforbes@fedoraproject.org
New configs in drivers/clk
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_COMMON_CLK:
The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select this option.
Symbol: COMMON_CLK [=n] Type : bool Defined at drivers/clk/Kconfig:25 Prompt: Common Clock Framework Depends on: !HAVE_LEGACY_CLK [=n] Location: -> Device Drivers Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] Selected by [n]: - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI - PMC_ATOM [=n] && X86 && PCI [=y]
Cc: Mark Salter msalter@redhat.com
diff a/redhat/configs/common/generic/CONFIG_COMMON_CLK b/redhat/configs/common/generic/CONFIG_COMMON_CLK --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_COMMON_CLK @@ -0,0 +1 @@ +CONFIG_COMMON_CLK=y diff a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK b/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK --- a/redhat/configs/pending-common/generic/CONFIG_COMMON_CLK +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_COMMON_CLK: -# -# The common clock framework is a single definition of struct -# clk, useful across many platforms, as well as an -# implementation of the clock API in include/linux/clk.h. -# Architectures utilizing the common struct clk should select -# this option. -# -# Symbol: COMMON_CLK [=n] -# Type : bool -# Defined at drivers/clk/Kconfig:25 -# Prompt: Common Clock Framework -# Depends on: !HAVE_LEGACY_CLK [=n] -# Location: -# -> Device Drivers -# Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL [=n] -# Selected by [n]: -# - MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y] -# - INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT [=n] && X86 && EFI && PCI [=y] && ACPI -# - PMC_ATOM [=n] && X86 && PCI [=y] -# -# -# -CONFIG_COMMON_CLK=y
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49409630...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Admin Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49409633...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/246943239 - created :hourglass_flowing_sand:
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49409675...
Hey Prarit,
I pushed an update to the MR to set this.
Thank you,
Patrick
On 1/26/21 6:54 AM, Justin Forbes (via Email Bridge) wrote:
From: Justin M. Forbes jforbes@fedoraproject.org
New configs in drivers/clk
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_COMMON_CLK:
The common clock framework is a single definition of struct clk, useful across many platforms, as well as an implementation of the clock API in include/linux/clk.h. Architectures utilizing the common struct clk should select this option.
Symbol: COMMON_CLK [=n] Type : bool Defined at drivers/clk/Kconfig:25 Prompt: Common Clock Framework Depends on: !HAVE_LEGACY_CLK [=n] Location: -> Device Drivers Selects: HAVE_CLK_PREPARE [=n] && CLKDEV_LOOKUP [=n] && SRCU [=y] && RATIONAL
[=n]
Selected by [n]:
- MFD_INTEL_LPSS [=n] && HAS_IOMEM [=y]
- INTEL_ATOMISP [=n] && STAGING [=n] && STAGING_MEDIA [=n] && MEDIA_SUPPORT
[=n] && X86 && EFI && PCI [=y] && ACPI
- PMC_ATOM [=n] && X86 && PCI [=y]
Cc: Mark Salter msalter@redhat.com
Acked-by: Prarit Bhargava prarit@redhat.com
P.
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49412739...
ACK/NACK Summary: NACKed - NACKed by Prarit Bhargava prarit@redhat.com★. Code owners are marked with a ★.
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49416326...
request-ack-nack-evaluation
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49416333...
ACK/NACK Summary: NACKed - NACKed by Prarit Bhargava prarit@redhat.com★. Code owners are marked with a ★.
From: Mark Salter on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/448#note_49545934...
Acked-by: Mark Salter msalter@redhat.com
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
GitLab Bridge on behalf of jmflinuxtx
-
GitLab Bridge on behalf of jmflinuxtx -
GitLab Bridge on behalf of Justin Forbes
-
Justin Forbes (via Email Bridge)
-
Prarit Bhargava