Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
dracut master now has hid_generic in the list of modules it needs to include. This change will be in the next dracut release for rawhide. However, if 3.5 kernels do get used for F17, it would be good to get the change backported to dracut used in F17 before the new kernel shows up.
Bruno Wolff III (bruno@wolff.to) said:
Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
Why not just build it in, then?
Bill
On Thu, Jul 12, 2012 at 11:35:46 -0400, Bill Nottingham notting@redhat.com wrote:
Bruno Wolff III (bruno@wolff.to) said:
Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
Why not just build it in, then?
Because at first I didn't know what the problem was. This could also could conceivably be a problem for fresh installs in a future where we are using 3.5 kernels for f17, but the module isn't included by default.
For now I added hid_generic to the list of kernel modules to include. I expect there will be a new dracut in rawhide soon as there have been a lot of releases lately.
The point of the original message was to suggest that if we use 3.5 kernels for F17, I think it would be a good idea to change the f17 version of dracut to include hid_generic by default. It isn't obvious to me that that will happen.
On Thu, Jul 12, 2012 at 11:03:55AM -0500, Bruno Wolff III wrote:
On Thu, Jul 12, 2012 at 11:35:46 -0400, Bill Nottingham notting@redhat.com wrote:
Bruno Wolff III (bruno@wolff.to) said:
Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
Why not just build it in, then?
Because at first I didn't know what the problem was. This could also could conceivably be a problem for fresh installs in a future where we are using 3.5 kernels for f17, but the module isn't included by default.
Bill meant "why not build it into the main kernel" e.g. not as a module. Not "build it into the initramfs".
For now I added hid_generic to the list of kernel modules to include. I expect there will be a new dracut in rawhide soon as there have been a lot of releases lately.
The point of the original message was to suggest that if we use 3.5 kernels for F17, I think it would be a good idea to change the f17 version of dracut to include hid_generic by default. It isn't obvious to me that that will happen.
That it's getting built as a module at all is a bit concerning to me. The Kconfig values for HID_GENERIC look like this:
config HID_GENERIC tristate "Generic HID driver" depends on HID default HID
so it should default to whatever option CONFIG_HID is set to. Now, admittedly we have CONFIG_HID=m in config-generic, but once that is put through the config file munging script, we wind up with:
CONFIG_HID=y CONFIG_HID_GENERIC=m
(and a general mismash of =m/=y options for HID_*)
So, something is ever so helpfully overriding our CONFIG_HID=m setting and forcing it to be =y, but maybe that is done after kconfig has parsed the hid Kconfig file and so HID_GENERIC is left =m.
Looks like that something is our CONFIG_USB_HID=y setting, which does a select HID and forces it to =y.
Dave, Justin, should we explicitly set CONFIG_HID=y and CONFIG_HID_GENERIC=y in config-generic and avoid this problem entirely?
josh
On Thu, Jul 12, 2012 at 01:55:05PM -0400, Josh Boyer wrote:
So, something is ever so helpfully overriding our CONFIG_HID=m setting and forcing it to be =y, but maybe that is done after kconfig has parsed the hid Kconfig file and so HID_GENERIC is left =m.
Looks like that something is our CONFIG_USB_HID=y setting, which does a select HID and forces it to =y.
Dave, Justin, should we explicitly set CONFIG_HID=y and CONFIG_HID_GENERIC=y in config-generic and avoid this problem entirely?
yeah, seems good to me.
Dave
On Thu, Jul 12, 2012 at 11:35:46AM -0400, Bill Nottingham wrote:
Bruno Wolff III (bruno@wolff.to) said:
Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
Why not just build it in, then?
Given the vast majority will need it, that doesn't seem like a bad idea to me.
I walked into this problem myself yesterday but hadn't had time to figure out the cause. Thanks for the heads-up Bruno.
Dave
On Thu, Jul 12, 2012 at 13:59:31 -0400, Dave Jones davej@redhat.com wrote:
On Thu, Jul 12, 2012 at 11:35:46AM -0400, Bill Nottingham wrote:
Bruno Wolff III (bruno@wolff.to) said:
Under the 3.5 kernel I need to have the hid_generic module loaded for my USB keyboards to work. I didn't with the 3.4 kernels. This caused a problem with being able to be able to enter the password for my encrypted rootfs.
Why not just build it in, then?
Given the vast majority will need it, that doesn't seem like a bad idea to me.
I walked into this problem myself yesterday but hadn't had time to figure out the cause. Thanks for the heads-up Bruno.
Harald helped too. he got me looking at the module lists to figure out what was different between 3.4 and 3.5.
kernel@lists.fedoraproject.org
-
Bill Nottingham -
Bruno Wolff III -
Dave Jones -
Josh Boyer