From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com --- .../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13 +CONFIG_FORCE_MAX_ZONEORDER=11
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
Acked-by: Brian Masney bmasney@redhat.com
I encountered this same error yesterday and fixed it in my local ARK tree.
I'll start a new thread on Fedora kernel list with the next issue I encountered testing some cross compiler changes.
Brian
On 5/19/20 10:08 AM, Brian Masney wrote:
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
Acked-by: Brian Masney bmasney@redhat.com
I encountered this same error yesterday and fixed it in my local ARK tree.
I'll start a new thread on Fedora kernel list with the next issue I encountered testing some cross compiler changes.
:) That's what I was doing as well. I'll leave you to it ;)
P.
Brian
On Tue, May 19, 2020 at 10:08:11AM -0400, Brian Masney wrote:
I encountered this same error yesterday and fixed it in my local ARK tree.
I'll start a new thread on Fedora kernel list with the next issue I encountered testing some cross compiler changes.
FWIW, the other error I encountered related to a missing filter-aarch64.sh.fedora file went away when I switched from the os-build to the ark-latest branch.
Brian
On Tue, May 19, 2020 at 12:01 PM Brian Masney bmasney@redhat.com wrote:
On Tue, May 19, 2020 at 10:08:11AM -0400, Brian Masney wrote:
I encountered this same error yesterday and fixed it in my local ARK tree.
I'll start a new thread on Fedora kernel list with the next issue I encountered testing some cross compiler changes.
FWIW, the other error I encountered related to a missing filter-aarch64.sh.fedora file went away when I switched from the os-build to the ark-latest branch.
That would be fixed with https://gitlab.com/cki-project/kernel-ark/-/merge_requests/300 which again has no reviews outside of my own and Jeremy who wrote it.
Justin
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
This works for os-build but fails for ark-latest because there is a patch in ark-patches that changes the default to 13.
The problem is we tried to keep the redhat/ changes separate from the redhat/fedora only patches in ark-patches. The goal was os-build could build standalone and the combination of ark-patches into ark-latest could build standalone.
Because of that arm64 change of the default to 13, we broke the os-build standalone build. And because the ark-patches does not have the redhat/ area, we can't make config changes on that branch.
Hence the problem and why it hasn't been solved yet. It is annoying and I would love to fix it, but this solution just moves the breakage from os-build to ark-latest. :-(
Therefore,
Nacked-by: Don Zickus dzickus@redhat.com
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
.../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13
+CONFIG_FORCE_MAX_ZONEORDER=11
2.26.2 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
On Tue, May 19, 2020 at 10:33:52AM -0400, Don Zickus wrote:
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
This works for os-build but fails for ark-latest because there is a patch in ark-patches that changes the default to 13.
The problem is we tried to keep the redhat/ changes separate from the redhat/fedora only patches in ark-patches. The goal was os-build could build standalone and the combination of ark-patches into ark-latest could build standalone.
Because of that arm64 change of the default to 13, we broke the os-build standalone build. And because the ark-patches does not have the redhat/ area, we can't make config changes on that branch.
I forgot to point out the patch that causes this: (git log -p origin/master..origin/ark-patches arch/arm64)
commit df97e71c24526cabc6a434d9f35ef493056b1bcf Author: Peter Robinson pbrobinson@gmail.com Date: Wed Feb 26 13:38:40 2020 -0500
Add option of 13 for FORCE_MAX_ZONEORDER
This is a hack, but it's what the other distros currently use for aarch64 with 4K pages so we'll do the same while upstream decides what the best outcome is (which isn't this).
Upstream Status: RHEL only Signed-off-by: Peter Robinson pbrobinson@gmail.com [Add a dependency on RHEL_DIFFERENCES] Signed-off-by: Jeremy Cline jcline@redhat.com
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 9e87f5847c92..f57bee916600 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1125,6 +1125,7 @@ config XEN config FORCE_MAX_ZONEORDER int default "14" if (ARM64_64K_PAGES && TRANSPARENT_HUGEPAGE) + default "13" if (ARCH_THUNDER && !ARM64_64K_PAGES && !RHEL_DIFFERENCES) default "12" if (ARM64_16K_PAGES && TRANSPARENT_HUGEPAGE) default "11" help
Hence the problem and why it hasn't been solved yet. It is annoying and I would love to fix it, but this solution just moves the breakage from os-build to ark-latest. :-(
Therefore,
Nacked-by: Don Zickus dzickus@redhat.com
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
.../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13
+CONFIG_FORCE_MAX_ZONEORDER=11
2.26.2 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
On 5/19/20 10:45 AM, Don Zickus wrote:
On Tue, May 19, 2020 at 10:33:52AM -0400, Don Zickus wrote:
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
This works for os-build but fails for ark-latest because there is a patch in ark-patches that changes the default to 13.
The problem is we tried to keep the redhat/ changes separate from the redhat/fedora only patches in ark-patches. The goal was os-build could build standalone and the combination of ark-patches into ark-latest could build standalone.
Because of that arm64 change of the default to 13, we broke the os-build standalone build. And because the ark-patches does not have the redhat/ area, we can't make config changes on that branch.
I forgot to point out the patch that causes this: (git log -p origin/master..origin/ark-patches arch/arm64)
commit df97e71c24526cabc6a434d9f35ef493056b1bcf Author: Peter Robinson pbrobinson@gmail.com Date: Wed Feb 26 13:38:40 2020 -0500
Add option of 13 for FORCE_MAX_ZONEORDER This is a hack, but it's what the other distros currently use for aarch64 with 4K pages so we'll do the same while upstream decides what the best outcome is (which isn't this). Upstream Status: RHEL only Signed-off-by: Peter Robinson <pbrobinson@gmail.com> [Add a dependency on RHEL_DIFFERENCES] Signed-off-by: Jeremy Cline <jcline@redhat.com>diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 9e87f5847c92..f57bee916600 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1125,6 +1125,7 @@ config XEN config FORCE_MAX_ZONEORDER int default "14" if (ARM64_64K_PAGES && TRANSPARENT_HUGEPAGE)
default "13" if (ARCH_THUNDER && !ARM64_64K_PAGES && !RHEL_DIFFERENCES) default "12" if (ARM64_16K_PAGES && TRANSPARENT_HUGEPAGE) default "11" help
Got it. But I'm confused and am struggling to figure out somethings with the new process. I'm still confused how to build a kernel in the kernel-ark tree.
Do I use os-build, ark-patches, or ark-latest? And, what commands do I issue? Also how do I force an eln build if I'm running on Fedora? Right now I'm hacking redhat/Makefile.common on the os-build branch to set "IS_FEDORA=:0".
I cannot believe this is so complicated. I know there are reasons for it but it strikes me that I can't figure it out and I've been paying attention.
P.
Hence the problem and why it hasn't been solved yet. It is annoying and I would love to fix it, but this solution just moves the breakage from os-build to ark-latest. :-(
Therefore,
Nacked-by: Don Zickus dzickus@redhat.com
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
.../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13
+CONFIG_FORCE_MAX_ZONEORDER=11
2.26.2 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
On Tue, May 19, 2020 at 10:03 AM Prarit Bhargava prarit@redhat.com wrote:
On 5/19/20 10:45 AM, Don Zickus wrote:
On Tue, May 19, 2020 at 10:33:52AM -0400, Don Zickus wrote:
On Tue, May 19, 2020 at 01:47:09PM -0000, GitLab Bridge on behalf of
prarit wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing
with
Processing
/home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files
Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had
CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER
for
Fedora") set this to 11, and follow-on ARK commit dd028d261347
("[redhat]
Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
This works for os-build but fails for ark-latest because there is a
patch in
ark-patches that changes the default to 13.
The problem is we tried to keep the redhat/ changes separate from the redhat/fedora only patches in ark-patches. The goal was os-build could build standalone and the combination of ark-patches into ark-latest
could
build standalone.
Because of that arm64 change of the default to 13, we broke the os-build standalone build. And because the ark-patches does not have the redhat/ area, we can't make config changes on that branch.
I forgot to point out the patch that causes this: (git log -p origin/master..origin/ark-patches arch/arm64)
commit df97e71c24526cabc6a434d9f35ef493056b1bcf Author: Peter Robinson pbrobinson@gmail.com Date: Wed Feb 26 13:38:40 2020 -0500
Add option of 13 for FORCE_MAX_ZONEORDER This is a hack, but it's what the other distros currently use for aarch64 with 4K pages so we'll do the same while upstream decides what the best outcome is (which isn't this). Upstream Status: RHEL only Signed-off-by: Peter Robinson <pbrobinson@gmail.com> [Add a dependency on RHEL_DIFFERENCES] Signed-off-by: Jeremy Cline <jcline@redhat.com>diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 9e87f5847c92..f57bee916600 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1125,6 +1125,7 @@ config XEN config FORCE_MAX_ZONEORDER int default "14" if (ARM64_64K_PAGES && TRANSPARENT_HUGEPAGE)
default "13" if (ARCH_THUNDER && !ARM64_64K_PAGES &&!RHEL_DIFFERENCES)
default "12" if (ARM64_16K_PAGES && TRANSPARENT_HUGEPAGE) default "11" helpGot it. But I'm confused and am struggling to figure out somethings with the new process. I'm still confused how to build a kernel in the kernel-ark tree.
Do I use os-build, ark-patches, or ark-latest? And, what commands do I issue? Also how do I force an eln build if I'm running on Fedora? Right now I'm hacking redhat/Makefile.common on the os-build branch to set "IS_FEDORA=:0".
I cannot believe this is so complicated. I know there are reasons for it but it strikes me that I can't figure it out and I've been paying attention.
Right, so as a maintainer, trying to build is a *massive* PITA unless you want to build what is already there. Luckily, there is a script that runs nightly and takes care of a lot of that PITA, creating ark-latest. To build from ark-latest, you can do.
git checkout ark-latest git reset --hard origin/ark-latest touch localversion make rh-dist-git-test or (preferred target)
Generally speaking ark-patches should work, and that is where people do patch work. os-build is really for config/spec/script changes. Sometimes ark-latest will be required though because ark-latest includes merge requests which have not been merged yet (labeled with "Include in Releases" in gitlab). If people could do review and get those merged, they would appear elsewhere and all of this would be easier. That label allows us to get a Fedora build done without having to wait for RHEL review, and I certainly don't have the time to spend chasing people down to make sure those reviews get done. There are currently 5 of those merge requests that I will be happy to merge once the reviews are done, Fedora and ELN have been building with them for a while.
Justin
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
For reference the reason we have this disparity goes back to why Fedora doesn't have 64K page sizes for aarch64. The reason is because with 64K pages it makes CMA 512Mb rather than the 64Mb (which I think can actually be 16) we have with 4K pages. I seem to remember its something to do with CMA using large pages and with 64K page sizes that makes the smallest large page to be 512Mb.
Losing 512Mb is obviously fatal on devices with small amounts of RAM like a bunch of the SBCs we support on Fedora so to support SBCs we had to move to 4K pages until we got a proper fix for this. Related it actually also affects RHEL for things like AWS images with small amounts of memory so I suspect it would be useful to be fixed in the RHEL use case too.
Peter
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
.../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13
+CONFIG_FORCE_MAX_ZONEORDER=11
2.26.2 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
+ Mark S.
On Tue, May 19, 2020 at 04:34:50PM +0100, Peter Robinson wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
For reference the reason we have this disparity goes back to why Fedora doesn't have 64K page sizes for aarch64. The reason is because with 64K pages it makes CMA 512Mb rather than the 64Mb (which I think can actually be 16) we have with 4K pages. I seem to remember its something to do with CMA using large pages and with 64K page sizes that makes the smallest large page to be 512Mb.
Losing 512Mb is obviously fatal on devices with small amounts of RAM like a bunch of the SBCs we support on Fedora so to support SBCs we had to move to 4K pages until we got a proper fix for this. Related it actually also affects RHEL for things like AWS images with small amounts of memory so I suspect it would be useful to be fixed in the RHEL use case too.
Thanks Peter for the context!
Mark should we enable this for ARK / RHEL-9?
Peter
Fixes: dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") Signed-off-by: Prarit Bhargava prarit@redhat.com Cc: honli@redhat.com Cc: jcline@redhat.com
.../fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER index b730690db048..8220d67904ea 100644 --- a/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER +++ b/redhat/configs/fedora/generic/arm/aarch64/CONFIG_FORCE_MAX_ZONEORDER @@ -1,4 +1,4 @@ # We technically want this to be 13 for Fedora with 4K pages but that's only # an option with an out of tree patch. Keep this 11 for compatibility until # we figure out what we want here -CONFIG_FORCE_MAX_ZONEORDER=13
+CONFIG_FORCE_MAX_ZONEORDER=11
2.26.2 _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-leave@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
For reference the reason we have this disparity goes back to why Fedora doesn't have 64K page sizes for aarch64. The reason is because with 64K pages it makes CMA 512Mb rather than the 64Mb (which I think can actually be 16) we have with 4K pages. I seem to remember its something to do with CMA using large pages and with 64K page sizes that makes the smallest large page to be 512Mb.
Losing 512Mb is obviously fatal on devices with small amounts of RAM like a bunch of the SBCs we support on Fedora so to support SBCs we had to move to 4K pages until we got a proper fix for this. Related it actually also affects RHEL for things like AWS images with small amounts of memory so I suspect it would be useful to be fixed in the RHEL use case too.
Thanks Peter for the context!
Mark should we enable this for ARK / RHEL-9?
I suspect 64K page size with the default CONFIG_FORCE_MAX_ZONEORDER for that is what we want for RHEL, which I would think is what it currently is.
The fix for both, which would allow Fedora to go back to 64K page sizes and be the same as elX, would be the fix to allow smaller CMA allocations.
On Tue, May 19, 2020 at 8:47 AM GitLab Bridge on behalf of prarit jcline@redhat.com wrote:
From: Prarit Bhargava prarit@redhat.com
The internal make command 'make rh-brew'/'make dist-brew' is failing with
Processing /home/prarit/git-kernel/kernel-ark/redhat/configs/kernel-aarch64-debug-fedora.config ... Error: Mismatches found in configuration files Found CONFIG_FORCE_MAX_ZONEORDER=11 after generation, had CONFIG_FORCE_MAX_ZONEORDER=13 in Source tree
ARK commit f5ca593e1c2e ("configs: Adjust CONFIG_FORCE_MAX_ZONEORDER for Fedora") set this to 11, and follow-on ARK commit dd028d261347 ("[redhat] Sync up ARK's Fedora config tree with Fedora's dist-git") erroneously overwrote the value back to 13.
Set CONFIG_FORCE_MAX_ZONEORDER back to 11 for aarch64.
Just to be official.
Nacked-by: Justin Forbes jforbes@fedoraproject.org
kernel@lists.fedoraproject.org
-
Brian Masney -
Don Zickus -
GitLab Bridge on behalf of prarit -
Justin Forbes -
Justin Forbes -
Peter Robinson -
Prarit Bhargava