From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_VEXPRESS_CONFIG:
Platform configuration infrastructure for the ARM Ltd. Versatile Express.
Symbol: VEXPRESS_CONFIG [=y] Type : tristate Defined at drivers/bus/Kconfig:224 Prompt: Versatile Express configuration bus Depends on: (ARM || ARM64 [=y]) && OF [=y] Location: -> Device Drivers -> Bus devices Selects: REGMAP [=y]
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_VEXPRESS_CONFIG | 1 + .../generic/CONFIG_VEXPRESS_CONFIG | 18 ------------------ 2 files changed, 1 insertion(+), 18 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG delete mode 100644 redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG
diff --git a/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG new file mode 100644 index 000000000000..389660309f56 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG @@ -0,0 +1 @@ +CONFIG_VEXPRESS_CONFIG=y diff --git a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG deleted file mode 100644 index a2c1cb307e90..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_VEXPRESS_CONFIG: -# -# Platform configuration infrastructure for the ARM Ltd. -# Versatile Express. -# -# Symbol: VEXPRESS_CONFIG [=y] -# Type : tristate -# Defined at drivers/bus/Kconfig:224 -# Prompt: Versatile Express configuration bus -# Depends on: (ARM || ARM64 [=y]) && OF [=y] -# Location: -# -> Device Drivers -# -> Bus devices -# Selects: REGMAP [=y] -# -# -# -CONFIG_VEXPRESS_CONFIG=y
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_VEXPRESS_CONFIG:
Platform configuration infrastructure for the ARM Ltd. Versatile Express.
Symbol: VEXPRESS_CONFIG [=y] Type : tristate Defined at drivers/bus/Kconfig:224 Prompt: Versatile Express configuration bus Depends on: (ARM || ARM64 [=y]) && OF [=y] Location: -> Device Drivers -> Bus devices Selects: REGMAP [=y]
Cc: Myron Stowe myron.stowe@redhat.com --- .../common/generic/CONFIG_VEXPRESS_CONFIG | 1 + .../generic/CONFIG_VEXPRESS_CONFIG | 18 ------------------ 2 files changed, 1 insertion(+), 18 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG delete mode 100644 redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG
diff --git a/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG new file mode 100644 index 000000000000..389660309f56 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG @@ -0,0 +1 @@ +CONFIG_VEXPRESS_CONFIG=y diff --git a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG deleted file mode 100644 index a2c1cb307e90..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_VEXPRESS_CONFIG: -# -# Platform configuration infrastructure for the ARM Ltd. -# Versatile Express. -# -# Symbol: VEXPRESS_CONFIG [=y] -# Type : tristate -# Defined at drivers/bus/Kconfig:224 -# Prompt: Versatile Express configuration bus -# Depends on: (ARM || ARM64 [=y]) && OF [=y] -# Location: -# -> Device Drivers -# -> Bus devices -# Selects: REGMAP [=y] -# -# -# -CONFIG_VEXPRESS_CONFIG=y
On Wed, 21 Oct 2020 17:47:50 -0000 GitLab Bridge on behalf of jeremycline cki-gitlab@redhat.com wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_VEXPRESS_CONFIG:
Platform configuration infrastructure for the ARM Ltd. Versatile Express.
Symbol: VEXPRESS_CONFIG [=y] Type : tristate Defined at drivers/bus/Kconfig:224 Prompt: Versatile Express configuration bus Depends on: (ARM || ARM64 [=y]) && OF [=y] Location: -> Device Drivers -> Bus devices Selects: REGMAP [=y]
Cc: Myron Stowe myron.stowe@redhat.com
.../common/generic/CONFIG_VEXPRESS_CONFIG | 1 + .../generic/CONFIG_VEXPRESS_CONFIG | 18 ------------------ 2 files changed, 1 insertion(+), 18 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG delete mode 100644 redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG
diff --git a/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG new file mode 100644 index 000000000000..389660309f56 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_VEXPRESS_CONFIG @@ -0,0 +1 @@ +CONFIG_VEXPRESS_CONFIG=y diff --git a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG b/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG deleted file mode 100644 index a2c1cb307e90..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_VEXPRESS_CONFIG +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_VEXPRESS_CONFIG: -# -# Platform configuration infrastructure for the ARM Ltd. -# Versatile Express. -# -# Symbol: VEXPRESS_CONFIG [=y] -# Type : tristate -# Defined at drivers/bus/Kconfig:224 -# Prompt: Versatile Express configuration bus -# Depends on: (ARM || ARM64 [=y]) && OF [=y] -# Location: -# -> Device Drivers -# -> Bus devices -# Selects: REGMAP [=y] -# -# -# -CONFIG_VEXPRESS_CONFIG=y
This is an ARM specific option, it be somewhere under redhat/configs/common/generic/arm should it not?
From: Mark Salter on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/421#note_53576732...
Myron is correct. This should go in redhat/configs/common/generic/arm
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/421#note_53995946...
Done.
Patrick
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/421#note_56580652...
Hey Myron,
Can you say why you removed approval for this MR? Is there a change you would like to see?
Patrick
From: Myron Stowe on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/421#note_56831593...
Hay Patrick,
The removal was because I thought the patch should be ARM specific and not generic. However, I now see that the patch was modified to be ARM specific - mostly a learning process for me with respect to GitLab. Sorry for the confusion and I'll hit the approve button next.
Myron
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/421#note_56862012...
No worries. Thank you!
kernel@lists.fedoraproject.org
-
GitLab Bridge on behalf of jeremycline -
GitLab Bridge on behalf of jeremycline -
Mark Salter (via Email Bridge)
-
Myron Stowe -
Myron Stowe (via Email Bridge)
-
Patrick Talbert (via Email Bridge)