From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_DEBUG_USER_ASCE:
Check on exit to user space that address space control elements are setup correctly.
If unsure, say N.
Symbol: DEBUG_USER_ASCE [=n] Type : bool Defined at arch/s390/Kconfig.debug:9 Prompt: Debug User ASCE Location: -> Kernel hacking -> s390 Debugging
---
Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_DEBUG_USER_ASCE | 1 + .../generic/CONFIG_DEBUG_USER_ASCE | 18 ------------------ 2 files changed, 1 insertion(+), 18 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_DEBUG_USER_ASCE delete mode 100644 redhat/configs/pending-common/generic/CONFIG_DEBUG_USER_ASCE
diff --git a/redhat/configs/common/generic/CONFIG_DEBUG_USER_ASCE b/redhat/configs/common/generic/CONFIG_DEBUG_USER_ASCE new file mode 100644 index 000000000000..8a8327065991 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_DEBUG_USER_ASCE @@ -0,0 +1 @@ +# CONFIG_DEBUG_USER_ASCE is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_DEBUG_USER_ASCE b/redhat/configs/pending-common/generic/CONFIG_DEBUG_USER_ASCE deleted file mode 100644 index aeaa452caae0..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_DEBUG_USER_ASCE +++ /dev/null @@ -1,18 +0,0 @@ -# CONFIG_DEBUG_USER_ASCE: -# -# Check on exit to user space that address space control -# elements are setup correctly. -# -# If unsure, say N. -# -# Symbol: DEBUG_USER_ASCE [=n] -# Type : bool -# Defined at arch/s390/Kconfig.debug:9 -# Prompt: Debug User ASCE -# Location: -# -> Kernel hacking -# -> s390 Debugging -# -# -# -# CONFIG_DEBUG_USER_ASCE is not set
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/791#note_55029747...
This should be an s390 entry instead of a generic one. The value should be fine.
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/791#note_55076226...
Hey Cornelia,
Thank you for this. I have moved the config option and pushed a V2. Let me know what you think.
Just FYI we could enable this option for debug s390x kernel builds if it could be useful there?
Patrick
From: Cornelia Huck on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/791#note_55086576...
So, I now see that DEBUG_USER_ASCE is actually removed again in commit 56e62a737028 ("s390: convert to generic entry"), and the same debug capability is now provided by the generic DEBUG_ENTRY config option.
I'm wondering whether this mr is actually applicable anymore?
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/791#note_55143807...
You are right. I will mark this Closed and move on to MR !900.
Thank you,
Patrick
kernel@lists.fedoraproject.org